picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

resolved: downgrade log messages about incoming LLMNR/mDNS packets on unexpected scopes 

This might very well happen due to races between joining multicast
groups and network configuration and such, let's not complain, but just
drop the messages at debug level.

Fixes: #7527
This commit is contained in:
Lennart Poettering 2017-12-06 12:44:05 +01:00
parent 6a483c5b2f
commit f1b1a5c4ca
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/resolve/resolved-llmnr.c
View File

@ -101,9 +101,12 @@ static int on_llmnr_packet(sd_event_source *s, int fd, uint32_t revents, void *u
return r;
scope = manager_find_scope(m, p);
if (!scope)
log_warning("Got LLMNR UDP packet on unknown scope. Ignoring.");
else if (dns_packet_validate_reply(p) > 0) {
if (!scope) {
log_debug("Got LLMNR UDP packet on unknown scope. Ignoring.");
return 0;
}
if (dns_packet_validate_reply(p) > 0) {
log_debug("Got LLMNR UDP reply packet for id %u", DNS_PACKET_ID(p));
dns_scope_check_conflicts(scope, p);
@ -327,7 +330,7 @@ static int on_llmnr_stream_packet(DnsStream *s) {
scope = manager_find_scope(s->manager, s->read_packet);
if (!scope)
log_warning("Got LLMNR TCP packet on unknown scope. Ignoring.");
log_debug("Got LLMNR TCP packet on unknown scope. Ignoring.");
else if (dns_packet_validate_query(s->read_packet) > 0) {
log_debug("Got LLMNR TCP query packet for id %u", DNS_PACKET_ID(s->read_packet));

2
src/resolve/resolved-mdns.c
View File

@ -121,7 +121,7 @@ static int on_mdns_packet(sd_event_source *s, int fd, uint32_t revents, void *us
scope = manager_find_scope(m, p);
if (!scope) {
log_warning("Got mDNS UDP packet on unknown scope. Ignoring.");
log_debug("Got mDNS UDP packet on unknown scope. Ignoring.");
return 0;
}