picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

resolved: remove one level of indentation in dns_transaction_validate_dnssec()

Browse source 
Invert an "if" check, so that we can use "continue" rather than another
code block indentation.
This commit is contained in:
Lennart Poettering 2016-01-07 12:45:38 +01:00
parent 35b011ed7c
commit f3cf586d56
1 changed files with 109 additions and 111 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/resolve/resolved-dns-transaction.c
View file

@ -2323,13 +2323,14 @@ int dns_transaction_validate_dnssec(DnsTransaction *t) {
/* Exit the loop, we dropped something from the answer, start from the beginning */ /* Exit the loop, we dropped something from the answer, start from the beginning */
changed = true; changed = true;
break; break;
}
} else if (dnskeys_finalized) { /* If we haven't read all DNSKEYs yet a
* negative result of the validation is
/* If we haven't read all DNSKEYs yet * irrelevant, as there might be more DNSKEYs
* a negative result of the validation * coming. */
* is irrelevant, as there might be if (!dnskeys_finalized)
* more DNSKEYs coming. */ continue;
if (result == DNSSEC_NO_SIGNATURE) { if (result == DNSSEC_NO_SIGNATURE) {
r = dns_transaction_requires_rrsig(t, rr); r = dns_transaction_requires_rrsig(t, rr);
@ -2343,7 +2344,6 @@ int dns_transaction_validate_dnssec(DnsTransaction *t) {
return r; return r;
t->scope->manager->n_dnssec_insecure++; t->scope->manager->n_dnssec_insecure++;
changed = true; changed = true;
break; break;
} }
@ -2414,7 +2414,6 @@ int dns_transaction_validate_dnssec(DnsTransaction *t) {
return r; return r;
t->scope->manager->n_dnssec_insecure++; t->scope->manager->n_dnssec_insecure++;
changed = true; changed = true;
break; break;
} }
@ -2451,7 +2450,6 @@ int dns_transaction_validate_dnssec(DnsTransaction *t) {
changed = true; changed = true;
break; break;
} }
}
if (changed) if (changed)
continue; continue;