picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

networkd: dhcp4 - fix unchecked return value

Browse source 
Found by coverity. CID #1237529 and #1237528.
This commit is contained in:
Tom Gundersen 2014-09-17 19:00:55 +02:00
parent ff02f101cb
commit f414a269b3
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/network/networkd-dhcp4.c
View file

@ -178,7 +178,7 @@ static int dhcp_lease_lost(Link *link) {
struct in_addr addr;
struct in_addr netmask;
struct in_addr gateway;
unsigned prefixlen;
unsigned prefixlen = 0;
int r;
assert(link);
@ -237,15 +237,18 @@ static int dhcp_lease_lost(Link *link) {
}
}
sd_dhcp_lease_get_address(link->dhcp_lease, &addr);
sd_dhcp_lease_get_netmask(link->dhcp_lease, &netmask);
prefixlen = in_addr_netmask_to_prefixlen(&netmask);
r = sd_dhcp_lease_get_address(link->dhcp_lease, &addr);
if (r >= 0) {
r = sd_dhcp_lease_get_netmask(link->dhcp_lease, &netmask);
if (r >= 0)
prefixlen = in_addr_netmask_to_prefixlen(&netmask);
address->family = AF_INET;
address->in_addr.in = addr;
address->prefixlen = prefixlen;
address->family = AF_INET;
address->in_addr.in = addr;
address->prefixlen = prefixlen;
address_drop(address, link, &link_address_drop_handler);
address_drop(address, link, &link_address_drop_handler);
}
}
if (link->network->dhcp_mtu) {