picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

efi: cache test results of boolean EFI state functions

Browse source 
EFI variable access is nowadays subject to rate limiting by the kernel.
Thus, let's cache the results of checking them, in order to minimize how
often we access them.

Fixes: #14828
This commit is contained in:
Lennart Poettering 2020-04-28 23:33:46 +02:00
parent d47df15b11
commit f46ba93944
1 changed files with 21 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/basic/efivars.c
View file

@ -244,10 +244,16 @@ int efi_set_variable_string(sd_id128_t vendor, const char *name, const char *v)
}
bool is_efi_boot(void) {
if (detect_container() > 0)
return false;
static int cache = -1;
return access("/sys/firmware/efi/", F_OK) >= 0;
if (cache < 0) {
if (detect_container() > 0)
cache = false;
else
cache = access("/sys/firmware/efi/", F_OK) >= 0;
}
return cache;
}
static int read_flag(const char *varname) {
@ -271,11 +277,21 @@ static int read_flag(const char *varname) {
}
bool is_efi_secure_boot(void) {
return read_flag("SecureBoot") > 0;
static int cache = -1;
if (cache < 0)
cache = read_flag("SecureBoot");
return cache > 0;
}
bool is_efi_secure_boot_setup_mode(void) {
return read_flag("SetupMode") > 0;
static int cache = -1;
if (cache < 0)
cache = read_flag("SetupMode");
return cache > 0;
}
int systemd_efi_options_variable(char **line) {