picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

v4l_id: use standard option parsing loop

Browse source 
Not terribly important, but the loop wasn't an actual loop,
making coverity unhappy.

CID #1261725.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2015-03-07 13:54:32 -05:00
parent 132764a223
commit fadce6caf5
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/udev/v4l_id/v4l_id.c
View file

@ -36,29 +36,28 @@ int main(int argc, char *argv[]) {
_cleanup_close_ int fd = -1;
char *device;
struct v4l2_capability v2cap;
int c;
for (;;) {
int option;
while ((c = getopt_long(argc, argv, "h", options, NULL)) >= 0)
option = getopt_long(argc, argv, "h", options, NULL);
if (option == -1)
break;
switch (option) {
switch (c) {
case 'h':
printf("%s [-h,--help] <device file>\n\n"
"Video4Linux device identification.\n\n"
" -h Print this message\n"
, program_invocation_short_name);
return 0;
default:
return 1;
}
}
device = argv[optind];
case '?':
return -EINVAL;
default:
assert_not_reached("Unhandled option");
}
device = argv[optind];
if (device == NULL)
return 2;
fd = open(device, O_RDONLY);
if (fd < 0)
return 3;