5722fb89bc
net-condition: introduce struct NetMatch
2020-10-29 15:04:52 +09:00
26f4d32365
meson: drop libsystemd_network from several binaries
...
This reduces the size of udevadm:
Before:
```
$ ll udevadm
-rwxrwxr-x 1 watanabe watanabe 1203800 Oct 29 01:36 udevadm
```
After:
```
$ ll udevadm
-rwxrwxr-x 1 watanabe watanabe 1094384 Oct 29 01:38 udevadm
```
2020-10-29 14:23:49 +09:00
01ab92af71
tree-wide: drop unnecessary inclusion of network-internal.h
2020-10-29 14:23:49 +09:00
7e19cc5462
net-condition: move net_match_config() and related conf parsers
2020-10-29 14:23:49 +09:00
1929ed0e58
sd-network: move link_get_type_string()
2020-10-29 14:23:49 +09:00
796aa313b3
network: move config_parse_bridge_port_priority()
2020-10-29 14:23:49 +09:00
f1f1714411
networkctl: use and print full hardware address
...
Intentionally not checking the iftype for the ieee_oui lookup to support
other ethernet-like devices.
2020-10-28 15:18:01 +01:00
14b66dbc92
dhcp4: fix DHCP on InfiniBand interfaces
...
With these patches applied, networkd is successfully able to get an
address from a DHCP server on an IPoIB interface.
1)
Makes networkd pass the actual interface type to the dhcp client,
instead of hardcoding it to Ethernet.
2)
Fixes some issues in handling the larger (20 Byte) IB MAC addresses in
the dhcp code.
3)
Add a new field to networkds Link struct, which holds the interface
broadcast address.
3.1)
Modify the DHCP code to also expect the broadcast address as parameter.
On an Ethernet-Interface the Broadcast address never changes and is always
all 6 bytes set to 0xFF.
On an IB one however it is not neccesarily always the same, thus
fetching the actual address from the interface is neccesary.
4)
Only the last 8 bytes of an IB MAC are stable, so when using an IB MAC to
generate a client ID, only pass those 8 bytes.
2020-10-28 14:44:43 +01:00
b8162cd200
network: store full hardware address in Link struct
...
This passes the legacy ethernet address to functions in a lot of places,
which all will need migrated to handle arbitrary size hardware addresses
eventually.
2020-10-28 14:44:43 +01:00
61eb77c4b6
network: drop link_load()
...
The link state file does not exist, as it is always removed on stop.
2020-10-28 18:16:01 +09:00
6fdcef2174
network: do not serialize/deserialize routes
...
The same as the previous commit. These are not used.
2020-10-28 18:16:01 +09:00
7b829a7b3b
network: do not serialize/deserialize addresses
...
The link state file is always removed when networkd is stopping. So,
the deserialization logic does not work. Moreover, the ADDRESSES=
entry is not used by sd-network, so serialization is also not necessary.
2020-10-28 18:15:57 +09:00
ca97e7cda0
network: do not serialize/deserialize ipv4ll address
...
The link state file is always removed on stop. So, we cannot deserialize
the address from the file. Moreover, currently the IPv4 link-local address
is always dropped by link_drop_foreign_addresses() on restart. Let's
drop the serialize/deserialize logic for IPv4 LL address.
2020-10-28 15:46:09 +09:00
778c879533
network: use sysctl_read_ip_property() where applicable
2020-10-28 15:44:10 +09:00
62f12d757c
network: downgrade log level in dhcp4_configure()
2020-10-28 15:44:10 +09:00
a41768533f
network: always enable sysctl property promote_secondaries
...
systemd-sysctl already enables promote_secondaries for all interface.
So, networkd also enables it unconditionally.
2020-10-28 15:44:10 +09:00
e69642dccc
network: mention that the error will be ignored
2020-10-28 15:44:10 +09:00
5360b089e1
network: drop dhcp4_init()
...
It is now called by only dhcp4_configure(). Let's merge them.
2020-10-28 15:44:10 +09:00
3def88503a
network: set previous DHCP4 address in link->addresses_foreign
...
Previously, the address was taken from the state file, but DHCP4_ADDRESS=
entry was dropped by 46986251d6
2020-10-28 15:44:05 +09:00
d0c4275c21
network: actually update radv mac
2020-10-27 18:01:22 +01:00
1132a714ec
network: drop routes managed by Manager when link is removed
...
Also, foreign routes managed by Manager are dropped in
link_drop_foreign_routes().
2020-10-23 23:07:12 +09:00
5f4d7aa458
network: specify route type in route_remove()
...
This factors out the common netlink message handling in route_remote()
and route_configure() to route_set_netlink_message().
2020-10-23 23:07:12 +09:00
bac319a795
network: link may be NULL
2020-10-23 23:07:12 +09:00
b1dc5946e2
network: ignore error in writing proxy_ndp
...
This partially reverts the commit fd773a11d8
2020-10-23 23:07:12 +09:00
9b3e49fc00
network: fix typo
2020-10-23 23:07:12 +09:00
9c914c0401
Merge pull request #17357 from yuwata/network-dhcp6-pd-announce-17353
...
network: add an option to control announcement of delegated prefix
2020-10-23 12:57:58 +09:00
e16e4b3bed
network: move set-MAC and set-nomaster operations out of link_up()
...
These should not be bundled into the link_up() operation, as that is
not (currently) called during interface configuration if the interface
already is IFF_UP, which is unrelated to the need to change the mac
to a user-defined value, or set 'nomaster' on the interface.
Additionally, there is no need to re-set the mac or re-assert nomaster
every time the interface is brought up; those should be only part of
normal initial interface configuration.
Fixes : #17391
2020-10-23 12:09:31 +09:00
69f30d4321
Merge pull request #17356 from yuwata/sd-xxx-stop
...
network: about sd_xxx_stop()
2020-10-21 18:07:38 +02:00
0c54bfd698
network: call netlink in the last of route_configure()
...
Otherwise, assertion will be hit when route_add() fails.
2020-10-20 15:44:24 +09:00
40075951dc
network: also compare and hash weight of the gateway
2020-10-20 15:32:55 +09:00
cc17f75f66
network: copy multipath route element earlier
...
`route_get()` compares input with existing routes, however previously,
the input may did not have information about gateway. So, the
comparison result might be incorrect, and the foregoing set_put() might
return -EEXIST.
2020-10-20 15:32:55 +09:00
8c212f76c2
network: make route_configure() return 0 on success
...
Previously, route_configure() always returns 1 on success, and never
returns 0. It is not necessary to return positive value.
2020-10-20 14:20:22 +09:00
27ff0490e6
network: rename IPv6PrefixDelegation= to IPv6SendRA=
2020-10-19 14:55:18 +09:00
4afd986753
network: introduce Announce= in [DHCPv6PrefixDelegation]
...
When disabled, the delegated prefixes are not emit by RA.
Closes #17353 .
2020-10-19 12:09:36 +09:00
e502f94dcf
network: introduce DHCPv6PrefixDelegation= setting
...
Then, the link can configure prefix delegated by DHCPv6 without emitting
RA.
2020-10-19 10:09:38 +09:00
8a08bbfc98
network: drop static prefixes and static route prefixes earlier if IPv6PrefixDelegation=no or dhcpv6
2020-10-19 10:09:38 +09:00
db5756f3f3
network: sort and rename elements in Network object
2020-10-19 10:09:38 +09:00
69e0f833a3
network: introduce network_adjust_radv()
2020-10-19 10:09:38 +09:00
a3c1a94947
network: clear DNS and domains for RA when an empty string is assigned
2020-10-19 10:09:38 +09:00
5e2767720a
network: use string_hash_ops_free for search domains
2020-10-19 10:09:38 +09:00
7abe175c00
network: also unref IPv4 ACD clients in Address objects
...
This should not change any behavior, as currently link_free_engines() is
always called after all addresses are dropped. But the function may be
used in other places in the future. So, let's also stop the clients.
2020-10-15 08:11:32 +09:00
1c49487284
network: move link_lldp_emit_stop() to link_free_engines()
...
This should not change any behavior.
2020-10-15 08:06:04 +09:00
9cc65242d7
network: also stop LLDP client in link_stop_engines()
2020-10-15 07:57:33 +09:00
2a99eed02c
network: stop DHCPv4 server in link_stop_clients()
...
Then, rename link_stop_clients() -> link_stop_engines().
2020-10-15 07:56:30 +09:00
a391901eb2
network: drop unnecessary conditions
...
sd_ipv4acd_stop() and sd_ipv4ll_stop() are idempotent.
2020-10-15 07:40:13 +09:00
c6a7531e0e
network: voidify sd_ipv4acd_stop() at one place
2020-10-15 07:39:40 +09:00
84add3cd2b
network: drop conditions to check existence of each engine
2020-10-15 07:38:45 +09:00
956dbf361b
network: warn if dynamic gateway is specified but corresponding protocol is disabled
2020-10-15 07:07:46 +09:00
22d37e5df6
network: introduce network_adjust_dhcp()
2020-10-15 07:06:58 +09:00
3773eb5485
network: introduce network_adjust_ipv6_accept_ra()
2020-10-15 07:06:36 +09:00
c27abcf4fb
network: when Gateway=_dhcp4, set several properties based on lease if they are not explicitly specified
...
Before this commit, event when Gateway=_dhcp4 or _ra is set, the
route was configured with 'protocol static', and other properties
specified by RouteTable=, RouteMTU=, or etc, were ignored.
This commit makes set the route protocol based on the protocol the
gateway address is obtained, and apply other settings if it is not
explicitly specified in the [Route] section.
2020-10-15 07:06:23 +09:00
5bb80a4603
network: determine a [Route] section will be used or not by gateway family instead of route family
...
By this commit, user can configure dynamic IPv6 Gateway with IPv4
destination.
2020-10-15 07:06:03 +09:00
c3d679c43f
network: when Gateway=_dhcp, assume gateway family based on other settings
2020-10-15 07:05:58 +09:00
b8caa4ef34
network: rename Gateway=_dhcp6 -> Gateway=_ipv6ra
2020-10-15 07:04:02 +09:00
1a3a6309a7
network: rename gateway_from_dhcp -> gateway_from_dhcp_or_ra
...
As for IPv6 case gateway is given by RA.
2020-10-15 06:58:53 +09:00
fd8f865c9f
Merge pull request #17342 from yuwata/network-dhcp-ipv4-acd-fixes
...
network: fixes several issues in IPv4 DAD for DHCP4
2020-10-14 23:12:41 +09:00
540e0bad3e
Merge pull request #17316 from yuwata/network-address-ipv4-peer-issue-17304
...
network: directly compare with in_addr element for IPv4 case
2020-10-14 15:02:14 +02:00
dfc637d0ff
Merge pull request #17341 from yuwata/sd-dhcp-client-fix-eexist-issue-16964
...
sd-dhcp: make sd_dhcp_client_set_request_option() not return -EEXIST
2020-10-14 18:55:39 +09:00
0e569a439a
network: start dynamic addressing clients like DHCP after setting netdevs
...
The function link_acquire_conf() may make the link state 'configuring'
when DHCP6 PD is enabled. Previously link_acquire_conf() was called
before link_enter_join_netdev(), and thus the assertion in the function
might be triggered.
Fixes #17329 .
2020-10-14 10:52:02 +02:00
5431227400
network: update MAC address in IPv4ACD client for DHCP4
2020-10-14 15:38:29 +09:00
a7df5cae54
network: also stop IPv4ACD client in link_stop_clients()
2020-10-14 15:38:29 +09:00
66f507e1ba
network: stop IPv4ACD client for DHCPv4 when lease is exprired
2020-10-14 15:38:29 +09:00
10fa21c0dc
network: move IPv4ACD client for DHCPv4 from Network to Link object
...
A .network file may matches multiple interfaces.
2020-10-14 15:38:29 +09:00
8ff85383b4
network: voidify link_stop_clients() in link_enter_failed()
2020-10-14 15:38:29 +09:00
4eb6a826b8
network: drop unused condition
2020-10-14 13:02:46 +09:00
b1476b5210
network: constify arguments
2020-10-13 20:30:38 +09:00
fe841414ef
network: read peer address, label, broadcast from rtnl message
...
Then, Address objects in Network and Link can be easily compared by
address_equal().
2020-10-13 20:30:35 +09:00
9b9c5fff16
network: directly compare with in_addr element for IPv4 case
...
When peer address is set, address_compare_func() (or address_equal())
does not work in link_is_static_address_configured(), as an Address object
stored in a Link does not contain peer addresses. So, we need to also
compare with in_addr element for IPv4 case.
Fixes #17304 .
2020-10-13 20:30:16 +09:00
d46b79bbe0
tree-wide: drop if braces around single line expressions as well
2020-10-09 15:11:55 +02:00
d7a0f1f4f9
tree-wide: assorted coccinelle fixes
2020-10-09 15:02:23 +02:00
081b300976
networkd: add assert to appease coverity
...
The code was OK, but not obviously so. Let's add an assert to help a
human or nonhuman reader figure it out.
Coverity CID#1433224.
2020-10-09 08:14:54 +02:00
ceea6c1aff
network: introduce IPV4_ADDRESS_FMT_STR macro
...
This also moves ADDRESS_FMT_VAL() macro to networkd-address.h, and
renames it to IPV4_ADDRESS_FMT_VAL().
2020-10-08 02:51:23 +09:00
d442bb3728
network: make Gateway= in [Route] section accept an empty string
2020-10-08 02:51:23 +09:00
d306d1d0ca
network: introduce Gateway=_dhcp4 and _dhcp6, and deprecate "_dhcp"
...
Fixes #17249 .
2020-10-08 02:51:23 +09:00
f9bb333832
network: manage multipath routes separately
2020-10-08 02:51:23 +09:00
2fe1d557e5
sd-netlink: introduce rtattr_read_nexthop()
2020-10-08 02:51:23 +09:00
d6ad41e27d
network: free Route object when route_remove() fails
...
When route_remove() succeeds, the Route object will be freed later by
manager_rtnl_process_route().
2020-10-08 02:51:23 +09:00
423c249c2e
network: constify arguments
2020-10-08 02:51:23 +09:00
6dd5398137
network: support IPv4 route with IPv6 gateway
2020-10-08 00:06:19 +09:00
ad208fac73
network: also manage routes without RTA_OIF attribute
2020-10-07 15:22:10 +02:00
fd7701bf31
network: ignore Scope= for IPv6 routes as it will not be used
2020-10-07 15:22:10 +02:00
8973df5c42
network: set default priority for IPv6 routes
...
See inet6_rtm_newroute() in kernel's net/ipv6/route.c.
2020-10-07 15:22:09 +02:00
13ffa39f8e
network: rename network_verify_xxx() -> network_drop_invalid_xxx()
...
As 'verify' implies a boolean result.
2020-10-07 03:22:03 +09:00
494b6b43cb
network: fix masquerade setting logic
...
Previously, address_establish() took Address object stored in Network
object. And address_release() took Address object stored in Link
object. Thus, address_release() always did nothing.
2020-10-07 03:13:26 +09:00
cd1caf30c0
network: always use RT_SCOPE_HOST for IPv4 loopback addresses
...
For IPv6 case, use RT_SCOPE_HOST only when scope is not explicitly specified.
2020-10-07 03:13:18 +09:00
d93d655c40
network: update MAC address in IPv4 ACD clients
...
When the MAC address of a link is updated, an address on the link may
be under checking address duplication. Or, (currently such code is not
implemented yet, but) address duplication check may be restarted later.
For that case, the IPv4 ACD clients must use the new updated MAC address.
2020-10-07 02:59:34 +09:00
490ccbd5e5
network: configure IPv4 DAD per link address
...
Previously, IPv4 DAD is configured in each Address object stored in
Network object. If a .network file matches multipe links, then it causes
an assertion. To prevent it, now IPv4 DAD is configured in each Address
object belogs to Link object.
2020-10-07 02:57:58 +09:00
693ec5ca83
network: constify one argument
2020-10-07 02:57:54 +09:00
cde1f0e8fc
network: introduce address_copy()
2020-10-07 02:54:01 +09:00
eaff204f09
network: do not update Address::flags in address_configure()
2020-10-07 02:50:51 +09:00
f5ee7d74af
network: fix indentation
2020-10-07 02:50:51 +09:00
4cf8500067
network: use sd_event stored in Manager
2020-10-07 02:50:51 +09:00
2ffd6d73f9
network: check feature is enabled in xxx_configure()
2020-10-07 02:50:51 +09:00
51f5dfd8ba
network: move link_enumerate_ipv6_tentative_addresses()
2020-10-07 02:50:51 +09:00
acc9fc2f51
network: drop unused function
2020-10-07 02:50:51 +09:00
5e0534f1c1
network: move sysctl related functions to networkd-sysctl.c
2020-10-07 02:50:51 +09:00
be9363ccab
network: introduce radv_update_mac()
2020-10-07 02:50:51 +09:00
eebba6dc24
network: introduce dhcp6_update_mac()
2020-10-07 02:50:51 +09:00
d947f7f977
network: introduce dhcp4_update_mac()
2020-10-07 02:50:50 +09:00
a3adb4a6a2
network: introduce ipv4ll_update_mac()
2020-10-07 02:50:50 +09:00
5460bde5c5
network: introduce link_serialize_dhcp6_client()
2020-10-07 02:50:50 +09:00
ca21a19a2e
network: introduce link_serialize_ipv4ll()
2020-10-07 02:50:50 +09:00
daad60d19e
network: introduce link_deserialize_ipv4ll()
2020-10-07 02:50:50 +09:00
571eeba909
network: introduce link_deserialize_dhcp4()
2020-10-07 02:50:50 +09:00
bbe694f91f
network: introduce network_verify_sr_iov()
2020-10-07 02:50:50 +09:00
f3a3ff2762
network: move link_configure_sr_iov()
2020-10-07 02:50:50 +09:00
209af9a67a
network: introduce network_verify_traffic_control()
2020-10-07 02:50:50 +09:00
200543791a
network: move link_configure_traffic_control()
2020-10-07 02:50:50 +09:00
34d7f2c99e
network: merge link_set_bridge_vlan() and br_vlan_configure()
2020-10-07 02:50:50 +09:00
256c75fd1f
network: move DUID related functions
2020-10-07 02:50:50 +09:00
086b8853d1
network: move link_radv_enabled()
2020-10-07 02:50:50 +09:00
5ae0fb7fb7
network: move link_dhcp4_server_enabled()
2020-10-07 02:50:50 +09:00
062c020fb6
network: move link_ipv6_accept_ra_enabled()
2020-10-07 02:50:50 +09:00
6f7a17ff0c
network: unify link_ipv{4,6}_forward_enabled()
2020-10-07 02:50:50 +09:00
67c311abd3
network: unify link_dhcp{4,6}_enabled()
2020-10-07 02:50:50 +09:00
ac49887e8c
network: move link_get_xxx_route_table()
2020-10-07 02:50:50 +09:00
bfbf150ee6
network: manage address pools by OrderedSet
2020-10-07 02:50:50 +09:00
3fe721c674
network: drop unused argument
2020-10-07 02:50:50 +09:00
ed76f58521
network: move functions related to address pool
2020-10-07 02:50:50 +09:00
093e35334d
network: header cleanup
2020-10-07 02:50:50 +09:00
67a58eb378
network: make several functions static
2020-10-07 02:50:50 +09:00
aa651e88de
network: manage addresses from pool by Set
2020-10-07 02:50:50 +09:00
9cd9fc8f44
network: drop list of static addresses
...
[Address] sections are managed by both LIST and Hashmap. Let's drop the
list and manage them by OrderedHashmap.
2020-10-07 02:50:50 +09:00
7818f8589a
network: make address_free() return NULL
2020-10-07 02:50:50 +09:00
2488e4d934
network: introduce link_stop_ipv4_dad()
2020-10-07 02:50:50 +09:00
b87d6a8284
network: move link_configure_ipv4_dad()
2020-10-07 02:50:50 +09:00
da4d3a612d
network: introduce link_deserialize_addresses()
2020-10-07 02:50:50 +09:00
3b31e2b718
network: introduce link_serialize_addresses()
2020-10-07 02:50:50 +09:00
32400c2ff0
network: introduce network_verify_addresses()
2020-10-07 02:50:50 +09:00
9a0ad16b26
network: update log messages
...
And drop unnecessary log for in_addr_to_string(), as its result is used
only for the consequent logs.
2020-10-07 02:49:17 +09:00
e1fc2c4371
network: move manager_rtnl_process_address()
2020-10-07 02:44:43 +09:00
d7fbb9f50c
network: introduce link_drop_addresses()
2020-10-07 02:44:43 +09:00
f8f2f880d4
network: introduce link_drop_foreign_addresses()
2020-10-07 02:44:43 +09:00
682c65b04c
network: introduce link_set_addresses()
2020-10-07 02:44:43 +09:00
e2263711ba
network: cleanup networkd-route.h
2020-10-07 02:44:43 +09:00
2a54a0446b
network: drop list of static routes
...
[Route] sections are managed by both LIST and Hashmap. Let's drop the
list.
2020-10-07 02:44:43 +09:00
833f3663a0
network: introduce hashmap_find_free_section_line()
2020-10-07 02:44:43 +09:00
74154c2e28
network: make several functions static
2020-10-07 02:44:43 +09:00
d9940a3f8a
network: introduce network_verify_routes()
2020-10-07 02:44:42 +09:00
565194127a
network: introduce link_serialize_routes()
2020-10-07 02:44:42 +09:00
731ff05b32
network: introduce link_deserialize_routes()
2020-10-07 02:44:42 +09:00
62f0ea5fae
network: introduce link_drop_routes()
2020-10-07 02:44:42 +09:00
779804dd60
network: introduce link_drop_foreign_routes()
2020-10-07 02:44:42 +09:00
169948e9d2
network: make route_free() return NULL
2020-10-07 02:44:42 +09:00
4468f01b67
network: move manager_rtnl_process_route()
2020-10-07 02:44:42 +09:00
141318f777
network: move link_request_set_routes()
2020-10-07 02:44:42 +09:00
be023c670b
network: make network_get_ipv6_dns() always set return value on success
2020-10-07 02:44:42 +09:00
a8d4a21091
network: fix indentation
2020-10-07 02:44:42 +09:00
b5ce40472c
network: cleanup networkd-radv.h
2020-10-07 02:44:42 +09:00
1a7deb2fcf
network: introduce network_verify_prefix() and network_verify_route_prefix()
2020-10-07 02:44:42 +09:00
Yu Watanabe