f4e1a42592
man: match parentheses
...
Files found with:
for f in *; do \
l=`tr -d '[^(]' < $f | wc -c`; \
r=`tr -d '[^)]' < $f | wc -c`; \
if [ $l -ne $r ]; then \
echo $f $l $r; \
fi; \
done
2020-07-07 13:31:39 +02:00
d1ca1f7c2a
xdg-autostart: avoid quadratic behaviour in strv parsing
...
The fuzzer test case has a giant line with ";;;;;;;;;;;..." which is turned into
a strv of empty strings. Unfortunately, when pushing each string, strv_push() needs
to walk the whole array, which leads to quadratic behaviour. So let's use
greedy_allocation here and also keep location in the string to avoid iterating.
build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812 51.10s user 0.01s system 99% cpu 51.295 total
↓
build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812 0.07s user 0.01s system 96% cpu 0.083 total
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22812 .
Other minor changes:
- say "was already defined" instead of "defined multiple times" to make it
clear that we're ignoring this second definition, and not all definitions
of the key
- unescaping needs to be done also for the last entry
2020-07-07 12:20:43 +02:00
a53f024d71
journald: minor wording tweak in message
...
For a user "from the kernel" might be rather unclear.
2020-07-07 12:14:41 +02:00
cd990847b9
tree-wide: more repeated words
2020-07-07 12:08:22 +02:00
0da425df65
networkd: use capitalized "IP" and "TOS" in messages
2020-07-07 12:06:26 +02:00
8ab0f03266
journal/compress: drop "future" code in zstd compression
...
We generally don't include stuff that is not used. This can be
easily ressurected if ever needed.
Fixes CID#1430210.
2020-07-07 12:06:26 +02:00
d7b34e3841
all: fix minor typos
...
[thaller@redhat.com: original patch by Yuri, extracted from [1]]
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/565
2020-07-07 18:52:49 +09:00
5d043c9fdf
update NEWS
2020-07-07 11:48:45 +02:00
cbe952fe1f
update TODO
2020-07-07 11:33:44 +02:00
737ec51444
TODO
2020-07-07 11:20:42 +02:00
a122502077
firstboot: add option to turn off welcome text display
2020-07-07 11:20:42 +02:00
dcfdd62184
man: document the new --image= switch of systemd-firstboot
2020-07-07 11:20:42 +02:00
3ff9fa591e
firstboot: add --image= switch
...
This is like --root=, but takes an image file path or device node path
and dissects the image directly, mounting it internally.
2020-07-07 11:20:42 +02:00
827ea52125
mount-util: use UMOUNT_NOFOLLOW in recursive umounter
...
When we only want to unmount mount points below some path then it is
against our interest to follow symlinks. Hence don't.
2020-07-07 11:20:42 +02:00
e49ee28522
mount-util: add destructor helper that umounts + rmdirs a path
2020-07-07 11:20:42 +02:00
e2ec9c4d3a
namespace-util: introduce helper for combining unshare() + MS_SLAVE remount
...
We have multiple places we do these two non-trivial operations together,
let's introduce a unified helper for doing both at once.
2020-07-07 11:20:42 +02:00
9ecf5d9340
fuzz: add test case that should already be resolved
2020-07-07 10:26:28 +02:00
cda667722c
core: refresh unit cache when building a transaction if UNIT_NOT_FOUND
...
When a command asks to load a unit directly and it is in state
UNIT_NOT_FOUND, and the cache is outdated, we refresh it and
attempto to load again.
Use the same logic when building up a transaction and a dependency in
UNIT_NOT_FOUND state is encountered.
Update the unit test to exercise this code path.
2020-07-07 10:09:24 +02:00
3f2e15abc5
sleep: one spelling unification
...
We use "writable" everywhere else.
2020-07-07 10:02:02 +02:00
77ecc1aaa5
Merge pull request #16380 from yuwata/network-dhcp6-update-prefix-route
...
Network: update acquired dhcp6 prefix routes
2020-07-07 09:05:08 +02:00
9389a271b7
Merge pull request #16381 from yuwata/dhcp4-renewing
...
dhcp4: fixes around renewing address
2020-07-07 08:59:35 +02:00
a240147bdc
Merge pull request #16383 from yuwata/network-dhcp6-radv-update-prefix
...
network: do not restart radv engine when adding prefix
2020-07-07 08:53:31 +02:00
7f6e342c93
hwdb: Add Google Pixel Slate (nocturne) ( #16377 )
2020-07-07 08:45:31 +02:00
58e6c62191
network: fix memleak
...
If init() is failed, the allocated memory was leaked.
2020-07-07 08:23:17 +02:00
1d596fdec2
network: do not restart radv engine when adding prefix
...
Replaces d469cea3bd
2020-07-07 11:20:35 +09:00
8fc2a5dff4
network: fix indentation
2020-07-07 11:18:28 +09:00
290696e512
Revert "network: Don't send RA with zero router lifetime when restarting radv"
...
This reverts commit d469cea3bd
2020-07-07 11:06:08 +09:00
c1495f8e9d
fix typo
...
I was thoroughly reading your nice coding style page and found out that you guys missed an 's'.
😁
2020-07-07 10:50:36 +09:00
d469cea3bd
network: Don't send RA with zero router lifetime when restarting radv
...
While investigating https://github.com/systemd/systemd/issues/16356 , I
discovered that networkd stops the radv service before adding or updating
prefixes and then starts it again. This causes networkd to send an RA with
a router lifetime of zero, causing the routes to flap on systems receiving
the RA for a fraction of a second before radv is started again and proper
RAs are sent. That has the potential to cause issues with latency-sensitive
traffic like gaming or VoIP. This patch adds a boolean argument to the
sd_radv_stop() function to control this behavior. The zero lifetime RA is
still sent whenever radv is actually being stopped, but when it is being
restarted for a prefix update (from networkd-dhcp6.c), the final RA is no
longer sent to avoid the route flapping.
2020-07-07 10:49:25 +09:00
921693a0f3
dhcp4: do not try to renew address when client has no lease
2020-07-07 10:18:58 +09:00
ceaec54a3c
dhcp4: do not renew address if client is not running yet
2020-07-07 10:18:22 +09:00
f050c94df0
network: always update acquired prefix route
...
Otherwise, routes become lifetime 0.
Fixes #16356 .
2020-07-07 09:20:44 +09:00
1419ff0401
network: decrease indentation level
2020-07-07 09:14:21 +09:00
cecd68c70f
network: fix indentation
2020-07-07 08:47:38 +09:00
c82012605b
Merge pull request #16374 from keszybz/docs-and-networkd
...
Docs and networkd
2020-07-07 08:29:56 +09:00
08bf20287c
hwdb: update again for v246
...
Just a few minor changes.
2020-07-07 08:26:13 +09:00
98ebef62c7
DHCPv4: client add support for DHCP server allow list
2020-07-06 22:28:54 +02:00
b3077c47a8
Merge pull request #16344 from keszybz/update-utmp-erofs
...
Make update-utmp not fail if it only fails to write wtmp records
2020-07-06 17:52:17 +02:00
c5bc4f77d9
hwdb: add another Logitech M705 mouse variant
...
There seems to be a newer version of Logitech M705 mouse in the wild.
Let's add it to the hwdb.
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
2020-07-06 17:17:52 +02:00
5544cd3199
Merge pull request #16373 from JackFangXN/master
...
userdbctl homectl use table_log_add_error()
2020-07-06 17:14:07 +02:00
9a61e8fca2
unit-name: fix a potential memory leak
...
Also, add a test which verifies the issue is indeed gone.
Fixes: CID#1429014
Followup to: ab19db01ae
2020-07-06 17:13:37 +02:00
1f68f77292
networkd: we should not loop when extract_first_word() fails
...
While at it, define iterator in the loop to reduce the indentation a bit.
2020-07-06 16:32:34 +02:00
8dc647fd30
man: do not say that tasks are threads and processes
...
This is confusing because the reader might think that processes and threads are
counted separately. Another issue pointed out in #16363 .
2020-07-06 16:32:33 +02:00
24c8d4d3f4
man: one more typo
...
Also from #16363 .
2020-07-06 16:11:27 +02:00
b37e4d9c87
Merge pull request #16370 from keszybz/tree-wide-spelling
...
Assorted spelling, markup, and grammar fixes
2020-07-06 15:57:47 +02:00
e26538dd04
network: tc: fix n_prio bounds check
...
Looks like a simple copy and paste error
Fixes https://github.com/systemd/systemd/issues/16367
2020-07-06 15:52:17 +02:00
f987a261b4
userdbctl homectl use table_log_add_error()
...
Signed-off-by: fangxiuning <fangxiuning123@126.com>
2020-07-06 21:32:22 +08:00
f04a98e13f
Fix two typos found by codespell
2020-07-06 15:09:23 +02:00
bdac560801
tree-wide: drop quotes from around [section]
...
For users, the square brackets already serve as markup and clearly delineate
the section name from surrounding text. Putting additional markup around that
only adds clutter. Also, we were very inconsistent in using the quotes. Let's
just drop them altogether.
2020-07-06 11:29:05 +02:00
e9dd698407
tree-wide: fixes for assorted grammar and spelling issues
...
Fixes #16363 . Also includes some changes where I generalized the pattern.
2020-07-06 11:29:05 +02:00
Topi Miettinen