Yu Watanabe
dcfbde3a43
sd-device: make sd_device_get_*() return -ENOENT if the values are not set
2018-09-23 17:18:19 +09:00
Zbigniew Jędrzejewski-Szmek
32397af3d4
Merge pull request #9928 from yuwata/libudev-cleanups
...
libudev: coding style updates
2018-09-15 22:36:38 +02:00
Yu Watanabe
8aae9a66fa
sd-device,libudev: make an argument for *_set_sysattr_value() const
2018-09-11 12:45:21 +09:00
Yu Watanabe
7f9e03952a
libudev-monitor: use assert_return() in many places
2018-09-11 12:45:21 +09:00
Yu Watanabe
e38242b03a
libudev-monitor: add missing error checks in udev_monitor_enable_receiving()
2018-09-11 12:45:21 +09:00
Yu Watanabe
a9808d8445
libudev-monitor: introduce udev_monitor_send_sd_device()
...
And use it in udev_monitor_send_device().
2018-09-11 12:45:21 +09:00
Yu Watanabe
23c457a7fb
libudev-monitor: re-implement udev_monitor_receive_sd_device()
2018-09-11 12:45:21 +09:00
Yu Watanabe
759d9f3f8d
libudev-monitor: use Hashmap or Set to store filters
2018-09-11 12:45:21 +09:00
Yu Watanabe
5e1e4c247b
libudev-monitor: use structured initializer
2018-09-11 12:45:21 +09:00
Yu Watanabe
a062a72f1b
libudev-monitor: rename monitor_set_nl_address() and make it return negative errno
2018-09-11 12:45:21 +09:00
Yu Watanabe
be1791ad6a
libudev-monitor: rename udev_has_devtmpfs() and move it to mount-util.c
...
As the function itself is quite generic.
2018-09-11 12:45:21 +09:00
Yu Watanabe
3d01fa902c
libudev-monitor: use structured initializer in bpf_*()
...
This also drop inline attribute from the functions.
2018-09-11 12:45:21 +09:00
Yu Watanabe
7f79720711
libudev-monitor: use 'unsigned' instead of 'unsigned int'
2018-09-11 12:45:21 +09:00
Yu Watanabe
02e7ae2fdc
libudev-device: create sd_device at first in udev_device_new_from_*()
2018-09-11 12:45:21 +09:00
Yu Watanabe
a7e9db150b
libudev-device: drop prototypes of unexistent functions
2018-09-11 12:45:21 +09:00
Yu Watanabe
536cbd7fa6
libudev: drop a prototype of unexistent function
2018-09-11 12:45:21 +09:00
Yu Watanabe
76387b9abb
libudev-device: coding style fixes
2018-09-11 12:45:21 +09:00
Yu Watanabe
33a03e6eff
libudev-device: fix return value of udev_device_has_tag()
2018-09-11 12:45:21 +09:00
Yu Watanabe
1b6374d285
libudev-device: use original negative errno
2018-09-11 12:45:21 +09:00
Yu Watanabe
71074e3a10
libudev-device: use structured initializer
2018-09-11 12:45:21 +09:00
Yu Watanabe
60fdee32bd
libudev-enumerate: use structured initializer
2018-09-11 12:45:21 +09:00
Yu Watanabe
2b19953a0d
libudev-hwdb: use assert_return_errno()
2018-09-11 12:45:21 +09:00
Yu Watanabe
68b80b8557
libudev-hwdb: use structured initializer
2018-09-11 12:45:21 +09:00
Yu Watanabe
b485aa5852
libudev-hwdb: drop unused 'struct udev *udev' in udev_hwdb struct
2018-09-11 12:45:21 +09:00
Yu Watanabe
f8cdabc0ec
libudev-queue: coding style fixes
2018-09-11 12:45:21 +09:00
Yu Watanabe
09f638ebd9
libudev-queue: drop prototypes of nonexistent functions
2018-09-11 12:45:21 +09:00
Yu Watanabe
2dac88a9d1
libudev-queue: use _cleanup_ attribute and TAKE_FD()
2018-09-11 12:45:21 +09:00
Yu Watanabe
d35c0e8d53
libudev-queue: use assert_return()
2018-09-11 12:45:21 +09:00
Yu Watanabe
ccda7f87f5
libudev-queue: use structured initializer
2018-09-11 12:45:21 +09:00
Yu Watanabe
bc54df90e4
libudev: modernize code a bit
2018-09-11 12:45:21 +09:00
Yu Watanabe
5ccb44a53f
libudev: use structured initializer
2018-09-11 12:45:21 +09:00
Yu Watanabe
2454727d5a
libudev: drop unused element in udev struct
2018-09-11 12:45:21 +09:00
Yu Watanabe
ff6f97f0cf
libudev: drop outdated comments
2018-09-11 12:45:21 +09:00
Yu Watanabe
3c6ac21929
libudev: use DEFINE_PUBLIC_TRIVIAL_REF_UNREF_FUNC() macro where applicable
2018-09-11 12:45:21 +09:00
Yu Watanabe
50d2158901
libudev-monitor: use safe_close() in udev_monitor_disconnect()
2018-09-11 12:45:21 +09:00
Yu Watanabe
1544d17f73
libudev-util: adjust type of returned value by util_string_hash32()
2018-09-10 18:27:36 +09:00
Yu Watanabe
755c3fe9a7
libudev-util: drop unnecessary argument 'struct udev *udev' from util_resolve_subsys_kernel()
2018-09-10 18:27:36 +09:00
Yu Watanabe
3782454c41
libudev: introduce udev_monitor_receive_sd_device()
2018-08-23 04:57:39 +09:00
Yu Watanabe
7c7be5515f
libudev: move cleanup functions from udev-util.h to libudev-private.h
2018-08-23 04:57:39 +09:00
Yu Watanabe
3938f568a2
libudev: accept NULL as the argument 'struct udev*' for udev_monitor_new() or friends
...
As udev_monitor struct or friends are now almost independent of udev
struct. So, generating these objects without udev struct is reasonable.
2018-08-23 04:57:39 +09:00
Yu Watanabe
afb76fdbff
tree-wide: drop double newline
2018-06-29 11:02:17 +09:00
Zbigniew Jędrzejewski-Szmek
d9b02e1697
tree-wide: drop copyright headers from frequent contributors
...
Fixes #9320 .
for p in Shapovalov Chevalier Rozhkov Sievers Mack Herrmann Schmidt Rudenberg Sahani Landden Andersen Watanabe; do
git grep -e 'Copyright.*'$p -l|xargs perl -i -0pe 's|/([*][*])?[*]\s+([*#]\s+)?Copyright[^\n]*'$p'[^\n]*\s*[*]([*][*])?/\n*|\n|gms; s|\s+([*#]\s+)?Copyright[^\n]*'$p'[^\n]*\n*|\n|gms'
done
2018-06-20 11:58:53 +02:00
Zbigniew Jędrzejewski-Szmek
0cd41d4dff
Drop my copyright headers
...
perl -i -0pe 's/\s*Copyright © .... Zbigniew Jędrzejewski.*?\n/\n/gms' man/*xml
git grep -e 'Copyright.*Jędrzejewski' -l | xargs perl -i -0pe 's/(#\n)?# +Copyright © [0-9, -]+ Zbigniew Jędrzejewski.*?\n//gms'
git grep -e 'Copyright.*Jędrzejewski' -l | xargs perl -i -0pe 's/\s*\/\*\*\*\s+Copyright © [0-9, -]+ Zbigniew Jędrzejewski[^\n]*?\s*\*\*\*\/\s*/\n\n/gms'
git grep -e 'Copyright.*Jędrzejewski' -l | xargs perl -i -0pe 's/\s+Copyright © [0-9, -]+ Zbigniew Jędrzejewski[^\n]*//gms'
2018-06-14 13:03:20 +02:00
Lennart Poettering
96b2fb93c5
tree-wide: beautify remaining copyright statements
...
Let's unify an beautify our remaining copyright statements, with a
unicode ©. This means our copyright statements are now always formatted
the same way. Yay.
2018-06-14 10:20:21 +02:00
Lennart Poettering
818bf54632
tree-wide: drop 'This file is part of systemd' blurb
...
This part of the copyright blurb stems from the GPL use recommendations:
https://www.gnu.org/licenses/gpl-howto.en.html
The concept appears to originate in times where version control was per
file, instead of per tree, and was a way to glue the files together.
Ultimately, we nowadays don't live in that world anymore, and this
information is entirely useless anyway, as people are very welcome to
copy these files into any projects they like, and they shouldn't have to
change bits that are part of our copyright header for that.
hence, let's just get rid of this old cruft, and shorten our codebase a
bit.
2018-06-14 10:20:20 +02:00
Lennart Poettering
56b00d0028
tree-wide: remove some double newlines in headers, too
2018-05-22 16:13:45 +02:00
Zbigniew Jędrzejewski-Szmek
11a1589223
tree-wide: drop license boilerplate
...
Files which are installed as-is (any .service and other unit files, .conf
files, .policy files, etc), are left as is. My assumption is that SPDX
identifiers are not yet that well known, so it's better to retain the
extended header to avoid any doubt.
I also kept any copyright lines. We can probably remove them, but it'd nice to
obtain explicit acks from all involved authors before doing that.
2018-04-06 18:58:55 +02:00
Yu Watanabe
1cc6c93a95
tree-wide: use TAKE_PTR() and TAKE_FD() macros
2018-04-05 14:26:26 +09:00
Lennart Poettering
ae2a15bc14
macro: introduce TAKE_PTR() macro
...
This macro will read a pointer of any type, return it, and set the
pointer to NULL. This is useful as an explicit concept of passing
ownership of a memory area between pointers.
This takes inspiration from Rust:
https://doc.rust-lang.org/std/option/enum.Option.html#method.take
and was suggested by Alan Jenkins (@sourcejedi).
It drops ~160 lines of code from our codebase, which makes me like it.
Also, I think it clarifies passing of ownership, and thus helps
readability a bit (at least for the initiated who know the new macro)
2018-03-22 20:21:42 +01:00
Zbigniew Jędrzejewski-Szmek
e8112e67e4
Make MANAGER_TEST_RUN_MINIMAL just allocate data structures
...
When running tests like test-unit-name, there is not point in setting
up the cgroup and signals and interacting with the environment. Similarly
when running fuzz testing of the parser.
Add new MANAGER_TEST_RUN_BASIC which takes the role of MANAGER_TEST_RUN_MINIMAL,
and redefine MANAGER_TEST_RUN_MINIMAL to just create the basic data structures.
2018-03-11 16:33:59 +01:00