5012d567a8
mount-util: make sure get_mount_flags() ever follows symlinks
...
It doesn't follow symlinks when we check for the mount flags via
libmount, hence it shouldn't do either when we go via statvfs().
2020-09-23 18:57:36 +02:00
28126409b2
mount-util: add helpers for mount() without following symlinks
2020-09-23 18:57:36 +02:00
e55299da4d
shutdown: also fsync() DM devices before going down
...
Similar reasons as the previous patch.
2020-09-23 18:33:48 +02:00
32c4626c4c
shutdown: also fsync() MD devices when going down
...
Let's make this explicit, just in case this suffers by the same issues
as the loopback devices, and drops in-flight IO when we disassemble it.
2020-09-23 18:33:48 +02:00
1a269c4ee3
shutdown: don't compare pointers with 0
2020-09-23 18:33:48 +02:00
4534b32c73
shutdown: fsync() before detaching loopback devices
...
This is a follow-up for cae1e8fb88c5a6b0960a2d0be3df8755f0c78462: we
also call the detach ioctls in the shutdown code, hence add the fsync()s
there too, just to be safe.
2020-09-23 18:33:48 +02:00
4265a66a5e
fs-util: check for /proc mounted in access_fd()
...
It's a very basic function very similar to other cases where we go via
/proc/self/fd/, hence do the explicit proc_mounted() check here too.
2020-09-23 18:20:38 +02:00
48d837cd92
fs-util: use strna() on returned strings of fd_get_path() if we don't check its return value
...
Let's make sure to use strna() on the strings returned by fd_get_path()
where we knowingly ignore any failures. We got this right in most cases,
but two were missing.
2020-09-23 18:20:38 +02:00
8fe8f3aaba
basic: update fd_get_path() to use proc_mounted() helper
...
We use it pretty much everywhere else, hence use it here too.
This also changes the error generated from EOPNOTSUPP to ENOSYS, to
match the other cases where we do such a check. One user checked for
EOPNOTSUPP which is updated to check for ENOSYS instead.
2020-09-23 18:20:38 +02:00
1e5bfa2ac8
fs-util: drop chmod_and_chown_unsafe() which is unused now
2020-09-23 18:00:19 +02:00
62c03398ba
sysusers: modernize file backup logic a bit
...
Let's use _cleanup_ magic to clean up files, let's fully operate by fds
whenever we can.
2020-09-23 18:00:19 +02:00
e59d030ff8
update TODO
2020-09-23 15:25:25 +02:00
8038b99d0d
run: let systemd resolve the path with RootDirectory=/RootImage=
...
Fixes #13338 .
2020-09-23 14:49:37 +02:00
526e3cbbdd
core: don't try to load units from non-absolute paths
...
The error message disagreed with the check that was actually performed. Adjust the check.
2020-09-23 14:49:37 +02:00
3142135098
catalog: add missing @ to German catalog file
2020-09-23 13:56:51 +02:00
6333aa9d46
sd-radv: fix indentation
...
Fix-up for 97efde65d8
2020-09-23 13:44:26 +02:00
d5bc4e6898
machine: fix error code propagation in two cases
2020-09-23 13:24:25 +02:00
6b6737119a
Merge pull request #17130 from keszybz/static-analyzer-cleanups
...
Trivial cleanups based on static analysis
2020-09-23 13:23:56 +02:00
f280aecd38
man: sd_bus_message_new: fix typo
2020-09-23 11:58:08 +02:00
1f0541dace
sd-path: include 'search' in search pathnames
2020-09-23 10:08:44 +02:00
cf18af825a
zsh: add systemd-path completions
2020-09-23 10:07:14 +02:00
2d52f8c46c
Merge pull request #17124 from bluca/copypasta
...
dissect-image: use correct path variable when reading verity signatures, do not refuse verity GPT without /usr partition
2020-09-23 09:43:39 +02:00
3cbf74652b
Merge pull request #17127 from poettering/errno-fixup
...
make more use of errno-util.h macros
2020-09-23 09:43:18 +02:00
a5d815bb7f
Merge pull request #16938 from poettering/homed-rtc-wrong
...
homed: don't refuse logins when RTC is wrong
2020-09-22 20:51:39 +02:00
2b2919a5ff
Merge pull request #17109 from fbuihuu/udev-opts-tweaks
...
Udev opts tweaks
2020-09-22 18:54:48 +02:00
abf6346c5e
test/run-integration-tests: do not run the tests if only "clean" is passed
2020-09-22 18:05:19 +02:00
fec5929f8b
shared/conf-parser: drop redundant cast to boolean
...
parse_boolean returns either 0 or 1 or error, and we checked for errors
earlier already.
2020-09-22 18:00:44 +02:00
0a9bf7fa59
logind: use _cleanup_ in one more place
2020-09-22 18:00:44 +02:00
d52e1c420c
sd-{login,netlink,network}: use TAKE_FD() in more places
2020-09-22 18:00:44 +02:00
90e207e41f
test-bus-chat: add missing return value in check
2020-09-22 17:58:11 +02:00
afa8ffae99
various: remove assignments of unread variables
2020-09-22 17:58:11 +02:00
4ffd4705fb
activate: reduce scope of iterator variable
2020-09-22 17:58:11 +02:00
89de370edd
core/namespace: drop bitfield annotations from boolean fields
...
Such microoptimization makes sense when the structure is used in many many copies,
but here's it's not, and the few bytes we save are not worth the extra code the
compiler has to generate:
return ns_info->mount_apivfs ||
ns_info->protect_control_groups ||
ns_info->protect_kernel_tunables ||
...
before:
49b187: 48 8b 45 f8 mov -0x8(%rbp),%rax
49b18b: 0f b6 00 movzbl (%rax),%eax
49b18e: 83 e0 80 and $0xffffff80,%eax
49b191: 84 c0 test %al,%al
49b193: 75 32 jne 49b1c7 <namespace_info_mount_apivfs+0x80>
49b195: 48 8b 45 f8 mov -0x8(%rbp),%rax
49b199: 0f b6 00 movzbl (%rax),%eax
49b19c: 83 e0 08 and $0x8,%eax
49b19f: 84 c0 test %al,%al
49b1a1: 75 24 jne 49b1c7 <namespace_info_mount_apivfs+0x80>
49b1a3: 48 8b 45 f8 mov -0x8(%rbp),%rax
49b1a7: 0f b6 00 movzbl (%rax),%eax
49b1aa: 83 e0 10 and $0x10,%eax
49b1ad: 84 c0 test %al,%al
49b1af: 75 16 jne 49b1c7 <namespace_info_mount_apivfs+0x80>
after:
49b024: 48 8b 45 f8 mov -0x8(%rbp),%rax
49b028: 0f b6 40 07 movzbl 0x7(%rax),%eax
49b02c: 84 c0 test %al,%al
49b02e: 75 2e jne 49b05e <namespace_info_mount_apivfs+0x7a>
49b030: 48 8b 45 f8 mov -0x8(%rbp),%rax
49b034: 0f b6 40 03 movzbl 0x3(%rax),%eax
49b038: 84 c0 test %al,%al
49b03a: 75 22 jne 49b05e <namespace_info_mount_apivfs+0x7a>
49b03c: 48 8b 45 f8 mov -0x8(%rbp),%rax
49b040: 0f b6 40 04 movzbl 0x4(%rax),%eax
49b044: 84 c0 test %al,%al
49b046: 75 16 jne 49b05e <namespace_info_mount_apivfs+0x7a>
2020-09-22 17:58:11 +02:00
36f8cf0163
Merge pull request #17086 from keszybz/developer-mode-default
...
Update dbus docs, make developer mode default
2020-09-22 16:29:28 +02:00
fce93d7aa3
ptyfwd: use ERRNO_IS_DISCONNECT() when checking for disconnection on foreign fds
2020-09-22 16:25:22 +02:00
065b47749d
tree-wide: use ERRNO_IS_PRIVILEGE() whereever appropriate
2020-09-22 16:25:22 +02:00
c848516f3f
dissect-image: do not refuse verity GPT without /usr partition
...
Only enforce that /usr verity partition is present if a /usr
partition is there
2020-09-22 15:24:59 +01:00
7025fa8b1a
dissect-image: use correct path variable when reading verity signatures
...
Copypasta slipped in via https://github.com/systemd/systemd/pull/17101
2020-09-22 13:19:19 +01:00
0b220a5f2a
Try stopping MD RAID devices in shutdown too
...
Currently the systemd-shutdown command attempts to stop swaps, DM
(crypt, LVM2) and loop devices, but it doesn't attempt to stop MD
RAID devices, which means that if the RAID is set up on crypt,
loop, etc. device, it won't be able to stop those underlying devices.
This code extends the shutdown application to also attempt stopping
the MD RAID devices.
Signed-off-by: Hubert Kario <hubert@kario.pl>
2020-09-22 10:41:59 +02:00
027f96c851
udevadm: rename option '--log-priority' into '--log-level'
...
Let's be consistent with systemctl(1).
'--log-priority' i still kept only for backward compatibility.
2020-09-22 09:05:57 +02:00
64a3494c3d
udev: rename kernel option 'log_priority' into 'log_level'
...
Let's be consistent with the rest of the project.
'log_priority' is still supported for backward compatibility.
2020-09-22 09:05:57 +02:00
06ca077ba2
meson: remove multi-line statement with trailing '\'
...
Error on meson 0.47:
```
meson.build:885:47: ERROR: Expecting colon got eol_cont.
crypt_header = conf.get('HAVE_CRYPT_H') == 1 ? \
^
```
This seems to have been fixed in meson 0.50 after a report from
https://github.com/mesonbuild/meson/issues/4720
2020-09-21 21:20:39 +02:00
a512e330ce
homed: in images that lack mkfs.btrfs automatically fall back to ext4
...
It's better to tweak suboptimal defaults than to just fail with
compiled-in defaults.
2020-09-21 18:02:35 +02:00
f2ba663ea5
homed: show actual file system in messages about file systems
2020-09-21 18:02:35 +02:00
3e0b54867e
user-record: don't refuse login when last pw change time is in the future
...
The RTC is like just off, it's a weird system state, let's continue
without requiring pw change.
2020-09-21 18:02:35 +02:00
61a29a020c
homed: ignore ratelimiting counters when timestamp is from future
...
This likely indicates that the system clock is simply wrong, hence allow
access in this case.
Fixes : #15917
2020-09-21 18:02:35 +02:00
51a95db6dc
homed: don't block logins into accounts with future change time
...
This might happen if the system clock is wrong, and we should allow
access in this case (though certainly log about it).
2020-09-21 18:02:31 +02:00
55e11ace68
Merge pull request #17101 from poettering/gpt-usr
...
add gpt types for /usr/, similar to how we have it for root partitions
2020-09-21 13:45:04 +02:00
198fda4f48
update-dbus-docs: skip test if python is too old
2020-09-20 13:15:44 +02:00
cd8de997f2
update TODO
2020-09-19 21:20:35 +02:00
Lennart Poettering