e986910e87
import: sparse_write() returns negative errno
2018-10-01 08:29:16 +02:00
5f723125ae
meson: avoid calling the shell to resolve efi_libdir
2018-09-30 16:22:07 -04:00
595343fb4c
meson: use an array option for efi-cc
...
Fixes: https://github.com/systemd/systemd/issues/10211
2018-09-30 15:43:39 -04:00
f21f31b24b
trivial: fix spelling in code comments
...
Based-on-patch-by: Rafael Fontenelle <rafaelff@gnome.org>
2018-09-30 21:32:33 +02:00
6083c4b763
libsystemd: export all functions in sd-hwdb.h
...
sd-hwdb.h is now also installed in /usr/include/systemd.
2018-09-30 20:39:02 +02:00
ca7a9afc7e
test-sd-hwdb: add a simple test for export sd-hwdb functions
2018-09-30 20:39:02 +02:00
3f608087bd
libsystemd: export all functions in sd-device.h
...
sd-device.h is now also installed in /usr/include/systemd.
2018-09-30 20:39:02 +02:00
213e759ad5
dhcp6: fix memleak about sd_event
2018-09-30 14:17:33 +02:00
1f0e310952
test: Add tests for networkd ( #10147 )
2018-09-29 14:36:25 +02:00
455e799943
Merge pull request #10200 from evverx/fuzz-dhcp6-client
...
Add a fuzzer for dhcp6-client
2018-09-29 13:41:52 +02:00
c1bc37a18b
tests: add a reproducer for the heap-buffer-overflow fixed in cb1bdeaf56
...
==14==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020001c761a at pc 0x000000540abc bp 0x7ffd0caf2c50 sp 0x7ffd0caf2c48
READ of size 2 at 0x6020001c761a thread T0
#0 0x540abb in client_parse_message /work/build/../../src/systemd/src/libsystemd-network/sd-dhcp6-client.c:849:73
#1 0x53f3bc in client_receive_advertise /work/build/../../src/systemd/src/libsystemd-network/sd-dhcp6-client.c:1083:13
#2 0x53d57f in client_receive_message /work/build/../../src/systemd/src/libsystemd-network/sd-dhcp6-client.c:1182:21
#3 0x7f71d8c3eeee in source_dispatch /work/build/../../src/systemd/src/libsystemd/sd-event/sd-event.c:3042:21
#4 0x7f71d8c3e431 in sd_event_dispatch /work/build/../../src/systemd/src/libsystemd/sd-event/sd-event.c:3455:21
#5 0x7f71d8c3fa8d in sd_event_run /work/build/../../src/systemd/src/libsystemd/sd-event/sd-event.c:3512:21
#6 0x531f2b in fuzz_client /work/build/../../src/systemd/src/fuzz/fuzz-dhcp6-client.c:44:9
#7 0x531bc1 in LLVMFuzzerTestOneInput /work/build/../../src/systemd/src/fuzz/fuzz-dhcp6-client.c:53:9
#8 0x57bef8 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:570:15
#9 0x579d97 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool*) /src/libfuzzer/FuzzerLoop.cpp:479:3
#10 0x57dcc2 in fuzzer::Fuzzer::MutateAndTestOne() /src/libfuzzer/FuzzerLoop.cpp:707:19
#11 0x580cd6 in fuzzer::Fuzzer::Loop(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, fuzzer::fuzzer_allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) /src/libfuzzer/FuzzerLoop.cpp:838:5
#12 0x55e998 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:764:6
#13 0x551a4c in main /src/libfuzzer/FuzzerMain.cpp:20:10
#14 0x7f71d784182f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#15 0x41e928 in _start (/out/fuzz-dhcp6-client+0x41e928)
2018-09-29 03:58:47 +00:00
ac41b5e8c5
tests: add a reproducer for the heap-buffer-overflow fixed in b387d3c132
2018-09-29 03:58:40 +00:00
b387d3c132
dhcp6: fix an off-by-one error in dhcp6_option_parse_domainname
...
==14==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60200055fa9c at pc 0x0000005458f1 bp 0x7ffc78940d90 sp 0x7ffc78940d88
READ of size 1 at 0x60200055fa9c thread T0
#0 0x5458f0 in dhcp6_option_parse_domainname /work/build/../../src/systemd/src/libsystemd-network/dhcp6-option.c:555:29
#1 0x54706e in dhcp6_lease_set_domains /work/build/../../src/systemd/src/libsystemd-network/sd-dhcp6-lease.c:242:13
#2 0x53fce0 in client_parse_message /work/build/../../src/systemd/src/libsystemd-network/sd-dhcp6-client.c:984:29
#3 0x53f3bc in client_receive_advertise /work/build/../../src/systemd/src/libsystemd-network/sd-dhcp6-client.c:1083:13
#4 0x53d57f in client_receive_message /work/build/../../src/systemd/src/libsystemd-network/sd-dhcp6-client.c:1182:21
#5 0x7f0f7159deee in source_dispatch /work/build/../../src/systemd/src/libsystemd/sd-event/sd-event.c:3042:21
#6 0x7f0f7159d431 in sd_event_dispatch /work/build/../../src/systemd/src/libsystemd/sd-event/sd-event.c:3455:21
#7 0x7f0f7159ea8d in sd_event_run /work/build/../../src/systemd/src/libsystemd/sd-event/sd-event.c:3512:21
#8 0x531f2b in fuzz_client /work/build/../../src/systemd/src/fuzz/fuzz-dhcp6-client.c:44:9
#9 0x531bc1 in LLVMFuzzerTestOneInput /work/build/../../src/systemd/src/fuzz/fuzz-dhcp6-client.c:53:9
#10 0x57bec8 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:570:15
#11 0x579d67 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool*) /src/libfuzzer/FuzzerLoop.cpp:479:3
#12 0x57dc92 in fuzzer::Fuzzer::MutateAndTestOne() /src/libfuzzer/FuzzerLoop.cpp:707:19
#13 0x580ca6 in fuzzer::Fuzzer::Loop(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, fuzzer::fuzzer_allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) /src/libfuzzer/FuzzerLoop.cpp:838:5
#14 0x55e968 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:764:6
#15 0x551a1c in main /src/libfuzzer/FuzzerMain.cpp:20:10
#16 0x7f0f701a082f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#17 0x41e928 in _start (/out/fuzz-dhcp6-client+0x41e928)
2018-09-29 03:07:29 +00:00
45a7becfea
tests: make fuzz-dhcp6-client work in containers provided by the OSS-Fuzz project
...
The containers come with an empty machine-id, which causes the fuzzer
to fail as soon as it starts.
See https://github.com/systemd/systemd/pull/9014#discussion_r189594104
2018-09-29 02:57:04 +00:00
d89a400ed6
fuzz: add a fuzzer for dhcp6_client
2018-09-29 02:27:07 +00:00
6cc2b88275
man: add systemctl suspend-then-hibernate ( #10194 )
...
This commit tries to document the systemctl suspend-then-hibernate documentation in the systemctl(1) manpage.
Fixes #10192 .
2018-09-28 15:56:48 +02:00
83043e8dc8
Merge pull request #10190 from evverx/fuzz-ndisc-rs
...
Add a fuzzer for sd-ndisc and a reproducer for an infinite loop in ndisc_handle_datagram
2018-09-28 15:54:04 +02:00
df7cacae69
meson: use the host architecture compiler/linker for src/boot/efi
...
cross building systemd to arm64 presently fails, because the build
system uses plain gcc and plain ld (build architecture compiler and
linker respectively) for building src/boot/efi. These values come from
the efi-cc and efi-ld options respectively. It rather should be using
host tools here.
Fixes: b710072da4
2018-09-28 14:42:56 +02:00
22041e475f
Merge pull request #10186 from yuwata/fix-10149
...
network: Fix memleaks found by test
2018-09-28 14:20:12 +02:00
b87dadcdb2
networkd-routing-policy-rule.c: drop unnecessary check
...
set_get() already does that.
2018-09-27 18:14:56 +02:00
431a4bc8c0
dhcp6: fix memleak
...
Let's drop client_set_lease() because just writing what it does in both
places is simpler.
Fixes #10157 .
2018-09-27 18:14:19 +02:00
2f3db9c907
uft8: add comment, requested by @keszybz
2018-09-27 17:21:18 +02:00
328756170e
update TODO
2018-09-27 17:11:40 +02:00
cb1bdeaf56
dhcp6: fix buffer size checking
2018-09-27 23:48:51 +09:00
23976cb928
dhcp6: use offsetof instead of sizeof
2018-09-27 23:41:23 +09:00
e2975f8548
sd-dhcp-lease: fix memleaks
2018-09-27 18:04:59 +09:00
09348d4081
sd-dhecp-lease: use free_and_replace() at one more
2018-09-27 18:04:08 +09:00
727ba17f55
network: fix memleak around Network.dhcp_vendor_class_identifier
2018-09-27 17:48:34 +09:00
598c85cc46
network: fix alignment
2018-09-27 17:48:34 +09:00
eeab051b28
network: strdup iif and oif when creating RoutingPolicyRule object
2018-09-27 17:48:34 +09:00
8e37fcbd21
network: use TAKE_PTR() at one more place
2018-09-27 17:48:34 +09:00
1b3194d8f2
network: fix memleak about routing policy
2018-09-27 17:48:34 +09:00
9d66b48c7c
network: use structured initializer at one more place
2018-09-27 17:48:34 +09:00
b6de93096e
Merge pull request #10173 from poettering/sd-boot-utf
...
the utf8.c changes from PR #9437 (i.e. the boot counting PR)
2018-09-27 08:21:20 +02:00
ff6c6cc117
nspawn: when --quiet is passed, simply downgrade log messages to LOG_DEBUG ( #10181 )
...
With this change almost all log messages that are suppressed through
--quiet are not actually suppressed anymore, but simply downgraded to
LOG_DEBUG. Previously we did it this way for some log messages and fully
suppressed them for others. With this it's pretty much systematic.
Inspired by #10122 .
2018-09-26 23:40:39 +02:00
6cf0a20491
udev/net: add support for the equivalent of "ethtool advertise" to .link files
...
This work adds support for the equivalent of "ethtool advertise" to .link files?
http://lists.freedesktop.org/archives/systemd-devel/2015-April/030112.html
2018-09-26 22:21:42 +02:00
bbb393877b
tests: add a reproducer for another infinite loop in ndisc_handle_datagram
2018-09-26 18:54:35 +00:00
df30e78e02
tests: add a reproducer for an infinite loop in ndisc_handle_datagram
...
=0 ndisc_router_parse (rt=0x60d000000110) at ../src/libsystemd-network/ndisc-router.c:126
=1 0x000055555558dc67 in ndisc_handle_datagram (nd=0x608000000020, rt=0x60d000000110) at ../src/libsystemd-network/sd-ndisc.c:170
=2 0x000055555558e65d in ndisc_recv (s=0x611000000040, fd=4, revents=1, userdata=0x608000000020) at ../src/libsystemd-network/sd-ndisc.c:233
=3 0x00007ffff63913a8 in source_dispatch (s=0x611000000040) at ../src/libsystemd/sd-event/sd-event.c:3042
=4 0x00007ffff6395eab in sd_event_dispatch (e=0x617000000080) at ../src/libsystemd/sd-event/sd-event.c:3455
=5 0x00007ffff6396b12 in sd_event_run (e=0x617000000080, timeout=18446744073709551615) at ../src/libsystemd/sd-event/sd-event.c:3512
=6 0x0000555555583f5c in LLVMFuzzerTestOneInput (data=0x6060000000e0 "\206", size=53) at ../src/fuzz/fuzz-ndisc-rs.c:422
=7 0x0000555555586356 in main (argc=2, argv=0x7fffffffe3d8) at ../src/fuzz/fuzz-main.c:33
2018-09-26 18:54:35 +00:00
f3241c61f1
ndisc: fix two infinite loops
2018-09-26 18:54:21 +00:00
0f0a1dad7d
tests: add a fuzzer for sd-ndisc
2018-09-26 16:39:03 +00:00
4885626b56
emergency: make sure console password agents don't interfere with the emergency shell
...
If for any reason local-fs.target fails at startup while a password is
requested by systemd-cryptsetup@.service, we end up with the emergency shell
competing with systemd-ask-password-console.service for the console.
This patch makes sure that:
- systemd-ask-password-console.service is stopped before entering in emergency
mode so it won't make any access to the console while the emergency shell is
running.
- systemd-ask-password-console.path is also stopped so any attempts to restart
systemd-cryptsetup in the emergency shell won't restart
systemd-ask-password-console.service and kill the emergency shell.
- systemd-ask-password-wall.path is stopped so
systemd-ask-password-wall.service won't be started as this service pulls
the default dependencies in.
Fixes : #10131
2018-09-26 18:13:32 +02:00
89f180201c
nspawn: chown() the legacy hierarchy when it's used in a container
...
This is a follow-up to 720f0a2f3chttps://github.com/systemd/systemd/issues/10026
Closes https://github.com/systemd/systemd/issues/9563
2018-09-26 17:29:17 +02:00
c87700a133
Make Watchdog Signal Configurable
...
Allows configuring the watchdog signal (with a default of SIGABRT).
This allows an alternative to SIGABRT when coredumps are not desirable.
Appropriate references to SIGABRT or aborting were renamed to reflect
more liberal watchdog signals.
Closes #8658
2018-09-26 16:14:29 +02:00
ee8d493cbd
Merge pull request #10158 from keszybz/seccomp-log-tightening
...
Seccomp log tightening
2018-09-26 15:56:32 +02:00
0eeba7a39f
Merge pull request #10168 from keszybz/coverity-fixes
...
Coverity fixes
2018-09-26 15:37:22 +02:00
dd5ab7d913
networkd-dhcp6: Set initial value of route to NULL
...
Start with route set to NULL should there be no route created. Remove
the explicit route_free as the _cleanup_ will take care of that after
the continue;.
2018-09-26 15:15:37 +02:00
0fbc35524c
libsystemd: add missing 'global' specifier in libsystemd.sym
2018-09-25 23:30:58 +02:00
6d7b543342
RFC tmpfiles: Allow configuration to ignore execution errors
...
This is an implementation that covers making errors encountered when writing
file content optionally fatal. If this is something that folks would want I'll
add handling of this for all the other directives. I'd appreciate suggestions
on how this might better be structured as well (use of a goto fail or such) as
I'm not super happy with the approach.
2018-09-25 23:30:30 +02:00
97c7469bbe
Merge pull request #10169 from poettering/putenv-error-handling
...
add missing putenv() error handling
2018-09-25 19:50:49 +02:00
80b0a59729
utf8: add utf8_to_utf16() helper
2018-09-25 15:57:47 +02:00
Yu Watanabe