Zbigniew Jędrzejewski-Szmek
206056cf01
Merge pull request #14211 from yuwata/support-nlmsgerr_attr_msg
...
Support NLMSGERR_ATTR_MSG
2019-12-04 09:15:23 +01:00
Yu Watanabe
e813de549b
network: do not return error but return UINT64_MAX if speed meter is disabled
...
Fixes #14222 .
2019-12-04 09:11:34 +01:00
Yu Watanabe
e4a1e68d7a
sd-netlink: support NLMSGERR_ATTR_MSG
...
From v4.12 the kernel appends some attributes to netlink acks
containing a textual description of the error and other fields.
This makes sd-netlink parse the attributes.
2019-11-30 16:13:51 +09:00
Lennart Poettering
19fa17c7c4
sd-bus: invalidate connection when Hello() fails
...
Fixes : #13969
2019-11-16 13:47:32 +01:00
Yu Watanabe
3126d64e5f
sd-device-enumerator: do not return error when a device is removed
...
Fixes #13814 .
2019-11-05 22:13:11 +01:00
Yu Watanabe
8e1e87a5de
tree-wide: drop double newline
2019-11-04 00:30:32 +09:00
Yu Watanabe
92133d2878
tree-wide: drop socket.h when socket-util.h is included
2019-11-04 00:30:32 +09:00
Yu Watanabe
455fa9610c
tree-wide: drop string.h when string-util.h or friends are included
2019-11-04 00:30:32 +09:00
Yu Watanabe
f5947a5e92
tree-wide: drop missing.h
2019-10-31 17:57:03 +09:00
Lennart Poettering
f598255951
sd-event: don't invalidate source type on disconnect
...
This fixes fd closing if fd ownership is requested.
2019-10-30 17:43:57 +01:00
Susant Sahani
0f5bd7fe24
network: introduce TrafficControl
...
Add network delay to a interface
2019-10-30 09:33:51 +09:00
Franck Bui
21b40f1662
fileio: introduce read_full_virtual_file() for reading virtual files in sysfs, procfs
...
Virtual filesystems such as sysfs or procfs use kernfs, and kernfs can work
with two sorts of virtual files.
One sort uses "seq_file", and the results of the first read are buffered for
the second read. The other sort uses "raw" reads which always go direct to the
device.
In the later case, the content of the virtual file must be retrieved with a
single read otherwise subsequent read might get the new value instead of
finding EOF immediately. That's the reason why the usage of fread(3) is
prohibited in this case as it always performs a second call to read(2) looking
for EOF which is subject to the race described previously.
Fixes : #13585 .
2019-10-25 15:24:49 +02:00
Yu Watanabe
78404d22cc
network: support matching based on wifi interfece type
2019-10-25 16:43:18 +09:00
Yu Watanabe
f2106b1789
Merge pull request #13836 from systemd/assert-cleanups-and-constification
...
Assert cleanups and constification
2019-10-25 13:36:00 +09:00
Zbigniew Jędrzejewski-Szmek
a5648b8094
basic/fs-util: change CHASE_OPEN flag into a separate output parameter
...
chase_symlinks() would return negative on error, and either a non-negative status
or a non-negative fd when CHASE_OPEN was given. This made the interface quite
complicated, because dependning on the flags used, we would get two different
"types" of return object. Coverity was always confused by this, and flagged
every use of chase_symlinks() without CHASE_OPEN as a resource leak (because it
would this that an fd is returned). This patch uses a saparate output parameter,
so there is no confusion.
(I think it is OK to have functions which return either an error or an fd. It's
only returning *either* an fd or a non-fd that is confusing.)
2019-10-24 22:44:24 +09:00
Zbigniew Jędrzejewski-Szmek
de157fe2a7
sd-netlink: constify object pointers passed to getters
...
sd-netlink is not public yet, so we can change the interface.
I did not touch interfaces of functions like sd_netlink_wait() and
sd_rtnl_message_new_link() which do not modify the object that is passed in,
because in the future we might want to change the code to e.g. take a
reference to the parent object or otherwise require a non-const reference.
2019-10-24 11:48:08 +02:00
Zbigniew Jędrzejewski-Szmek
730b76bd2c
sd-device: allow sd_device_get_devtype to be called with NULL arg and do not assert
...
We shouldn't call assert() on user-specified arguments in public functions.
While at it, let's return 1 if the type exists, and 0 otherwise.
2019-10-24 11:48:08 +02:00
Yu Watanabe
a1d736e25c
sd-netlink: add nl80211 type systems
2019-10-15 01:57:19 +09:00
Yu Watanabe
31e78d1042
sd-netlink: introduce sd_genl_message_get_family()
2019-10-15 01:57:19 +09:00
Yu Watanabe
2be081ffd6
sd-netlink: support NLMSG_DONE
2019-10-15 01:57:19 +09:00
Yu Watanabe
4e8f0ef921
sd-netlink: save dynamic general netlink message type
2019-10-15 01:57:19 +09:00
Yu Watanabe
2cac03f71d
sd-netlink: drop unnecessarily exported variables
2019-10-15 01:57:19 +09:00
Yu Watanabe
59d4103fd5
sd-netlink: introduce sd_netlink_message_read_string_strdup()
2019-10-15 01:57:19 +09:00
Yu Watanabe
6bf8e24bad
sd-netlink: use structured initializer
2019-10-15 01:57:19 +09:00
Yu Watanabe
ddcda37016
sd-netlink: drop unused variable
2019-10-15 01:57:19 +09:00
Yu Watanabe
338ff28d5f
sd-netlink: add missing license identifier
2019-10-15 01:57:19 +09:00
Susant Sahani
c16c780804
network: introduce ip nexthop routing
...
Used to manipulate entries in the kernel's nexthop tables.
Example:
```
[NextHop]
Id=3
Gateway=192.168.5.1
```
2019-10-14 21:32:48 +09:00
Zbigniew Jędrzejewski-Szmek
86e94d95d0
Merge pull request #13246 from keszybz/add-SystemdOptions-efi-variable
...
Add efi variable to augment /proc/cmdline
2019-10-03 12:19:44 +02:00
Frantisek Sumsal
a5d27871f7
sd-event: explicitly ignore waitipid()'s return value
...
Fixes CID#1393252
2019-10-01 10:25:12 +02:00
Yu Watanabe
82d1264048
Merge pull request #11883 from yuwata/network-dhcp-renew
...
network: dhcp renew
2019-09-22 07:44:23 +02:00
Yu Watanabe
ae65d7dbe3
network: introduce new bus method Renew() and RenewLink()
2019-09-21 20:27:36 +09:00
Susant Sahani
299d578f7f
network: DHCP server Add support to transmit SIP server
...
1. DHCP server trasmit
2. Client parses and saves in leases
Implements http://www.rfc-editor.org/rfc/rfc3361.txt
```
Frame 134: 348 bytes on wire (2784 bits), 348 bytes captured (2784 bits) on interface 0
Ethernet II, Src: 42:65:85:d6:4e:32 (42:65:85:d6:4e:32), Dst: 1e:04:f8:b8:2f:d4 (1e:04:f8:b8:2f:d4)
Internet Protocol Version 4, Src: 192.168.5.1, Dst: 192.168.5.11
User Datagram Protocol, Src Port: 67, Dst Port: 68
Dynamic Host Configuration Protocol (ACK)
Message type: Boot Reply (2)
Hardware type: Ethernet (0x01)
Hardware address length: 6
Hops: 0
Transaction ID: 0x7cc87cb4
Seconds elapsed: 0
Bootp flags: 0x0000 (Unicast)
Client IP address: 0.0.0.0
Your (client) IP address: 192.168.5.11
Next server IP address: 0.0.0.0
Relay agent IP address: 0.0.0.0
Client MAC address: 1e:04:f8:b8:2f:d4 (1e:04:f8:b8:2f:d4)
Client hardware address padding: 00000000000000000000
Server host name not given
Boot file name not given
Magic cookie: DHCP
Option: (53) DHCP Message Type (ACK)
Length: 1
DHCP: ACK (5)
Option: (51) IP Address Lease Time
Length: 4
IP Address Lease Time: (3600s) 1 hour
Option: (1) Subnet Mask (255.255.255.0)
Length: 4
Subnet Mask: 255.255.255.0
Option: (3) Router
Length: 4
Router: 192.168.5.1
Option: (6) Domain Name Server
Length: 4
Domain Name Server: 192.168.5.1
Option: (42) Network Time Protocol Servers
Length: 4
Network Time Protocol Server: 192.168.1.1
Option: (120) SIP Servers <=====here
Length: 9
SIP Server Encoding: IPv4 Address (1)
SIP Server Address: 192.168.1.1
SIP Server Address: 192.168.5.2
Option: (101) TCode
Length: 13
TZ TCode: Europe/Berlin
Option: (54) DHCP Server Identifier (192.168.5.1)
Length: 4
DHCP Server Identifier: 192.168.5.1
Option: (255) End
Option End: 255
```
```
cat /run/systemd/netif/state ✔ ⚡ 3148 16:40:51
OPER_STATE=routable
CARRIER_STATE=carrier
ADDRESS_STATE=routable
DNS=192.168.94.2 192.168.5.1
NTP=192.168.5.1
SIP=192.168.1.1 192.168.5.2
```
aa
2019-09-20 21:22:23 +09:00
Yu Watanabe
48fb0d1301
sd-netlink: fix invalid assertion
...
It is natural that n_attiributes is less than type. But in that case,
the message does not contain any message about the type. So, we should
not abort execution with assertion, but just return -ENODATA.
2019-09-17 21:53:42 +09:00
Zbigniew Jędrzejewski-Szmek
d4d99bc6e4
basic/cgroup-util: let cgroup_unified_flush() return the detected hierarchy
...
This avoid the use of the global variable.
Also rename cgroup_unified_update() to cgroup_unified_cached() and
cgroup_unified_flush() to cgroup_unified() to better reflect their new roles.
2019-09-16 18:06:20 +02:00
Susant Sahani
611224d9fe
sd-network: add support to get DHCP4 address
2019-09-09 20:01:33 +05:30
Zbigniew Jędrzejewski-Szmek
61252bae91
sd-bus: adjust indentation of comments
2019-08-27 19:49:09 +02:00
Zbigniew Jędrzejewski-Szmek
11791cdecc
test-bus-vtable: also print introspection for the fallback vtable
...
This doesn't really test anything, it's just a trivial test that we
get the expected output for a fallback vtable.
2019-08-27 19:49:09 +02:00
Zbigniew Jędrzejewski-Szmek
d0696f3b75
Merge pull request #13365 from keszybz/fix-commits-from-pr-13246
...
Fix commits from #13246
2019-08-22 09:13:25 +02:00
Zbigniew Jędrzejewski-Szmek
8788a56863
test-event: stop debugging spew
...
Ubuntu autopkgtests print output from all tests, and test-event produces
a lot of it. Let's cut it down to reasonable size.
2019-08-20 12:01:23 +02:00
William A. Kennington III
d1bdafd214
networkd: Keep track of static neighbors
...
We need to keep track of the static neighbors that are configured on the
interface so that we can delete stale entries that were removed.
2019-08-12 20:28:19 +09:00
Zbigniew Jędrzejewski-Szmek
5d276aa201
sd-hwdb: use return value from ordered_hashmap_iterate()
...
Why not? Coverity CID#1402329.
2019-08-03 17:43:51 +02:00
Shreyas Behera
037dbb80d1
Add IFLA_BR_MCAST_IGMP_VERSION
2019-07-25 09:54:52 +09:00
Lennart Poettering
733cbd00b0
netlink: move local-addresses.[ch] to src/shared
...
This code is not part of the public API of sd-netlink, nor used by it
internally and hence should not be in the sd-netlink directory.
Also, move the test case for it to src/test/.
2019-07-24 09:06:50 +02:00
Yu Watanabe
1647f24100
sd-netlink: update comment
2019-07-19 07:14:58 +09:00
Zbigniew Jędrzejewski-Szmek
7b9103a622
sd-device: voidify and simplify calls to ordered_hashmap_iterate()
...
Coverity CID#1402356 and CID#1402335.
2019-07-17 11:35:04 +02:00
Zbigniew Jędrzejewski-Szmek
3d4d5abf2a
sd-bus: voidify two calls to hashmap_iterate()
...
Coverity CID#1402304 and CID#1402307.
2019-07-17 11:35:04 +02:00
Yu Watanabe
8cec0a5c32
tree-wide: drop duplicated blank lines
...
```
$ for i in */*.[ch] */*/*.[ch]; do sed -e '/^$/ {N; s/\n$//g}' -i $i; done
$ git checkout HEAD -- basic/linux shared/linux
```
2019-07-15 18:41:27 +02:00
Lennart Poettering
b910cc72c0
tree-wide: get rid of strappend()
...
It's a special case of strjoin(), so no need to keep both. In particular
as typing strjoin() is even shoert than strappend().
2019-07-12 14:31:12 +09:00
Lennart Poettering
be9d8212a5
Merge pull request #13017 from yuwata/network-neighbor-lladdr-13015
...
network: rename Neighbor.MACAddress= and also support IPv4 address
2019-07-11 19:23:29 +02:00
Yu Watanabe
49808e0e2d
network: NDA_LLADDR attribute can also take struct in_addr
2019-07-11 22:22:29 +09:00