picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
34,388 Commits 2 Branches 0 Tags 166 MiB
Commit Graph

34388 Commits

Author SHA1 Message Date
Yu Watanabe 845d247a3d tree-wide: use 'signed int' instead of 'int' for bit field variables 
Suggested by LGTM: https://lgtm.com/rules/1506024027114/
 2018-06-28 10:16:51 +02:00
Lennart Poettering 12d71b77e2
Merge pull request #9452 from evverx/coverity.sh 
coverity.sh: use a comma to separate module names
 2018-06-28 10:07:59 +02:00
Yu Watanabe f43580f17d resolve: warn when our stub listener is disabled but resolv.conf uses it 
Closes #9450.
 2018-06-28 10:06:15 +02:00
Yu Watanabe 48f5da19b6 meson: do not compare objects of different types 
This fixes the following warning:
```
meson.build:1140: WARNING: Trying to compare values of different types (DependencyHolder, list) using !=.
The result of this is undefined and will become a hard error in a future Meson release.
```

Follow-up for f02582f69fe1e7663a87ba80bd4f90d5d23ee75f(#9410).
 2018-06-28 10:05:19 +02:00
Evegeny Vereshchagin 283c265387 sd-bus: stop using the result of an assignment as an operand of && 
This makes OBJECT_PATH_FOREACH_PREFIX consistent with PATH_FOREACH_PREFIX
and also fixes 7 alerts reported by LGTM at
ac0a087003/files/src/libsystemd/sd-bus/bus-objects.c?sort=name&dir=ASC&mode=heatmap&showExcluded=true#V1383
 2018-06-28 13:17:29 +09:00
Lennart Poettering 874b5ad248 core: tiny comment fix 2018-06-28 11:55:44 +09:00
Lennart Poettering a7e2e50d35 summary: update nspawn description string a bit 
nspawn as it is now is a generally useful tool, hence let's drop the
comments about it being useful for debug and so on only.

The new wording just makes the first sentence of the main page also the
summary.
 2018-06-28 11:55:44 +09:00
Filipe Brandenburger d7af62d52c sleep: fix one more printf format of a fiemap field 
Use PRIu64 constant to get the format right on LP-64 architectures,
cast to (uint64_t) to solve incompatibility of __u64.

This was missed in ad4bc33522, so fix it
with this follow up.
 2018-06-28 03:29:21 +09:00
Mike Gilbert 358248caa3 basic: add missing comma in raw_clone assembly for sparc 
Fixes: 96f64eb574
Closes: https://github.com/systemd/systemd/issues/9444
 2018-06-27 09:16:04 -07:00
Lorenz Hübschle-Schneider b90cbe6638 cryptsetup: Add dependency on loopback setup to generated units 
For loopback volumes, the generated unit needs to depend on
systemd-tmpfiles-setup-dev.service to ensure that loopback
support is loaded.

Fixes #9308
 2018-06-27 16:57:17 +02:00
Yu Watanabe 04e075b572 bus-util: make log level lower in request_name_destroy_callback() 
Fixes #9442.
 2018-06-27 16:56:50 +02:00
Lennart Poettering a5de5c43e6
Merge pull request #9440 from yuwata/fix-js 
journal-gateway: update browse.html
 2018-06-27 10:37:36 +02:00
Lennart Poettering 7f818901a2
Merge pull request #9438 from yuwata/lgtm-fixes-2 
small fixes suggested by LGTM
 2018-06-27 10:36:50 +02:00
Yu Watanabe a661dc36f6 resolve: reduce number of conversions between ifname and ifindex 
This also fixes minor memleak introduced in
654457e560c5723b90b419f7651b87040aade07e.
 2018-06-26 23:09:36 -07:00
Filipe Brandenburger 5a01b3f35d resolvconf: fixes for the compatibility interface 
Also use compat_main() when called as `resolvconf`, since the interface
is closer to that of `systemd-resolve`.

Use a heap allocated string to set arg_ifname, since a stack allocated
one would be lost after the function returns. (This last one broke the
case where an interface name was suffixed with a dot, such as in
`resolvconf -a tap0.dhcp`.)

Tested:
  $ build/resolvconf -a nonexistent.abc </etc/resolv.conf
  Unknown interface 'nonexistent': No such device

Fixes #9423.
 2018-06-26 23:09:36 -07:00
Yu Watanabe e68131526b analyze: actually select longest activated-time of services 
Discovered by LGTM.
 2018-06-27 14:54:19 +09:00
Yu Watanabe 944072fedd journal-gateway: use localStorage["cursor"] only when it has valid value 
Discovered by LGTM.
 2018-06-27 14:50:23 +09:00
Yu Watanabe c497e449f4 journal-gateway: explicitly declare local variables 
Suggested by LGTM.
 2018-06-27 14:22:28 +09:00
Yu Watanabe affaed1e55 sd-bus: fix implicit downcast of bitfield reported by LGTM 2018-06-27 13:28:28 +09:00
Filipe Brandenburger ad4bc33522 sleep: fix printf format of fiemap fields 
Use PRIu64 and PRIu32 constants to also get the format right on LP-64
architectures.

For the 64-bit fields, we need a cast to (uint64_t), since __u64 is
defined as a `long long unsigned` and PRIu64 expects a `long unsigned`.
In practice, both are the same, so the cast should be OK.
 2018-06-26 20:39:07 +02:00
Evegeny Vereshchagin a7e9daf40c README.md: add an LGTM badge 
Now that @yuwata has fixed a lot of alerts, the badge looks
much better than before, so let's show it :-)
 2018-06-26 18:15:09 +02:00
Neal Gompa a6bb550458 rpm: Add misspelled %_environmentdir macro for temporary compatibility 
This should be removed after systemd 240 is released.

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
 2018-06-26 07:43:41 -04:00
Yu Watanabe e0f691e1fd tree-wide: use localtime_r() instead of localtime() 
Follow-up for e46acb7950.
 2018-06-26 14:26:39 +09:00
Yu Watanabe ad16158c10 netdev: do not assign unused values 2018-06-26 14:26:19 +09:00
Jan Janssen aa2cc005d7 crypt-util: Translate libcryptsetup log level instead of using log_debug() 
This makes sure that errors reported by libcryptsetup are shown to the
user instead of getting swallowed up by log_debug().
 2018-06-26 14:26:07 +09:00
Evegeny Vereshchagin f3a020d153 coverity.sh: fail if uploading data to Coverity Scan is forbidden 2018-06-25 22:22:29 +00:00
Evegeny Vereshchagin 1e79d09ef9 coverity.sh: use a comma to separate module names 
Otherwise Python bails out with
```
Traceback (most recent call last):
  File "<string>", line 1, in <module>
NameError: name 'json' is not defined
```

See https://travis-ci.org/systemd/systemd/jobs/397490437
 2018-06-25 22:02:41 +00:00
Evegeny Vereshchagin 096eec29cd coverity.sh: make the script compatible with Python 3 2018-06-25 21:59:28 +00:00
Evegeny Vereshchagin eeeaebf9c5 coverity.sh: fix a couple indents 2018-06-25 21:57:43 +00:00
Yu Watanabe b34a21083b man: add missing option for system.conf 2018-06-26 04:07:44 +09:00
Yu Watanabe e761599ffd core: add missing option and drop nonexistent option in system.conf 2018-06-26 04:07:19 +09:00
Yu Watanabe 2dcacc7363 journal: add missing option in journald.conf 2018-06-26 04:05:42 +09:00
Yu Watanabe a4d5708c79 journal-remote: add license and reference to man page in conf files 2018-06-26 04:04:45 +09:00
Yu Watanabe 3632149409 network: provide default networkd.conf 2018-06-26 03:34:49 +09:00
Lennart Poettering e46acb7950 timedate: use gmtime_r() and localtime_r() 
gmtime() and localtime() operate on a static buffer. let's avoid this,
as we never know whether some library might use these calls in some
backrgound thread.

Discovered by lgtm:

https://lgtm.com/projects/g/systemd/systemd/
 2018-06-25 19:20:34 +02:00
Zbigniew Jędrzejewski-Szmek e49807606d
Merge pull request #9411 from poettering/systemctl-is-running-fixes 
tiny systemctl fixes
 2018-06-25 19:03:31 +02:00
Neal Gompa 6ea4cb975f rpm: Fix typo in %_environmentdir 
Signed-off-by: Neal Gompa <ngompa13@gmail.com>
 2018-06-25 12:56:50 -04:00
Yu Watanabe 48847676ca man: add comments about MTUBytes= and MACAddress= for tuntap devices 
Closes #9407.
 2018-06-25 18:54:38 +02:00
Zbigniew Jędrzejewski-Szmek dfe23d4145
Merge pull request #4522 from lucaswerkmeister/unescape-template 
escape: support --unescape with --template
 2018-06-25 18:48:01 +02:00
Lennart Poettering 5e4c5bde5c busctl: make parameter const 
it's initialized from an argv[] entry, hence let's be make it
non-writable by default.
 2018-06-25 18:26:17 +02:00
Yu Watanabe f02582f69f meson: check whether gnutls supports TCP fast open 
Fixes #9403
 2018-06-26 00:30:29 +09:00
Lennart Poettering bfeec178db systemctl: if we can't detect the system-is-running state, assume it's not running 2018-06-25 17:10:27 +02:00
Lennart Poettering e686a616e8 systemctl: log errors to LOG_DEBUG rather than eating them up entirely 2018-06-25 17:10:27 +02:00
Lennart Poettering 9897b09ba7 systemctl: add 'static' to constant state array 2018-06-25 17:10:27 +02:00
Zbigniew Jędrzejewski-Szmek 7f1fc7c6d4 bls: allow firmware-supported file systems 
This copies the text from Matthew Garrett's version verbatim. At
least MacOS uses HFS+ for their ESP.
 2018-06-25 15:39:54 +02:00
Ludwin Janvier 99d4345b30 [hwdb] Add support for HP ProBook 650 wifi switch key (#9260) 
Add support for HP ProBook 650 wifi switch key
 2018-06-25 13:18:13 +02:00
Filipe Brandenburger b02a7e1aea resolved: assert t->server is set in dns_transaction_emit_tcp. 
Uncovered by Coverity. Fixes CID 1393390.
 2018-06-25 13:17:25 +02:00
Filipe Brandenburger 53a2383b8b core/job: add check for return of job_type_merge_and_collapse() 
Using an assertion is fine, since calls to job_merge_into_installed()
are protected by a check for job_type_is_conflicting().

Uncovered by Coverity, fixes CID 996307.
 2018-06-25 13:16:38 +02:00
M0Rf30 a2680b6f27 hwdb: added accelerometer quirk for Aspire Switch 10 (sw5-011) 2018-06-25 13:13:10 +02:00
Lennart Poettering 2919425bab
Merge pull request #9398 from yuwata/lgtm-fixes 
fixes error handlings and several cleanups suggested by LGTM
 2018-06-25 13:12:44 +02:00