Commit graph

12 commits

Author SHA1 Message Date
Lennart Poettering c8a202b7d4 everywhere: always use O_CLOEXEC where it makes sense 2014-02-13 14:59:56 +01:00
Lennart Poettering 9f6445e34a log: log_error() and friends add a newline after each line anyway, so avoid including it in the log strings 2013-12-24 16:39:37 +01:00
Thomas Hindoe Paaboel Andersen 9091e686f4 Add more _printf_'s for format-nonliterals
Clang is a bit more strict wrt format-nonliterals:
http://clang.llvm.org/docs/LanguageExtensions.html#format-string-checking

Adding these extra printf attributes also makes gcc able to find more
problems. E.g. this patch uncovers a format issue in udev-builtin-path_id.c

Some parts looked intetional about breaking the format-nonliteral check.
I added some supression for warnings there.
2013-12-14 13:32:22 +01:00
Kay Sievers 1cb8df46cb udev: ata_id: log faling ioctls as "debug" 2013-10-30 14:50:04 +01:00
Zbigniew Jędrzejewski-Szmek 1e8e0a3221 udev/ata_id: zero out variable properly
b8a2b0f76 'use initalization instead of explicit zeroing'
introduced a bug where only the first sizeof(uint_t*) bytes
would be zeroed out, instead of the whole array.
2013-04-14 18:52:24 -04:00
Zbigniew Jędrzejewski-Szmek b8a2b0f76b udev/ata_id: use initalization instead of explicit zeroing 2013-04-10 18:59:42 -04:00
Kay Sievers 1298001ec5 use the same email address everywhere 2012-11-12 19:47:43 +01:00
Kay Sievers daa9cf546c udev: ata_id - fixup all 8 not only 6 bytes of the fw_rev string
The last two digits are in the wrong order:
  $ hdparm -I /dev/sda | grep Revision
  4PC10362

  $ /lib/udev/ata_id -x /dev/sda | grep REVISION
  4PC10326
2012-07-05 16:56:58 +02:00
Kay Sievers b49d9b50cf udev: fix a few issues detected by the llvm static analyzer 2012-04-13 15:10:12 +02:00
Kay Sievers baa30fbc2c udev: switch to systemd logging functions 2012-04-08 16:06:20 +02:00
Kay Sievers 51fc11c10d udev: ata_id - remove assert() until we switch over to systemd logging 2012-04-04 13:29:37 +02:00
Kay Sievers 3e2147858f move imported udev into place 2012-04-04 05:05:07 +02:00
Renamed from src/udev/src/ata_id/ata_id.c (Browse further)