Lennart Poettering
dc90e0faae
basic: add new helper call empty_or_dash_to_null()
...
We have a function like this at two places already. Let's unify it in
one generic location and let's port a number of users over.
2019-04-08 12:11:11 +02:00
Lennart Poettering
e7b88b7bc1
tree-wide: introduce empty_or_dash() helper
...
At quite a few places we check isempty() || streq(…, "-"), let's add a
helper to simplify that, and replace that by a single function call.
2019-04-08 12:03:33 +02:00
Zbigniew Jędrzejewski-Szmek
6e5dcce4b1
Voidify more mkdir_p calls
2019-03-27 11:53:12 +01:00
Zbigniew Jędrzejewski-Szmek
ca78ad1de9
headers: remove unneeded includes from util.h
...
This means we need to include many more headers in various files that simply
included util.h before, but it seems cleaner to do it this way.
2019-03-27 11:53:12 +01:00
Lennart Poettering
d8b4d14df4
util: split out nulstr related stuff to nulstr-util.[ch]
2019-03-14 13:25:52 +01:00
Lennart Poettering
f05e1d0d9f
util: split out kbd related stuff
...
This stuff is neither generic enough to be in def.h, nor really has much
to do with locale, hence give it its own .c/.h file pair.
2019-03-14 13:25:51 +01:00
Lennart Poettering
0a9707187b
util: split out memcmp()/memset() related calls into memory-util.[ch]
...
Just some source rearranging.
2019-03-13 12:16:43 +01:00
Zbigniew Jędrzejewski-Szmek
f68a26221c
tests: use the test helpers in more places
...
This is mostly cosmetic. It makes those test binaries support SYSTEMD_LOG_*
environment variables.
2019-03-04 14:15:38 +01:00
Lennart Poettering
ee589a1882
Merge pull request #11041 from yuwata/update-missing-v2
...
missing: separate missing.h more
2018-12-04 16:19:02 +01:00
Yu Watanabe
36dd5ffd5d
util: drop missing.h from util.h
2018-12-04 10:00:34 +01:00
Yu Watanabe
f2a3de0116
tree-wide: add whitespace between type and variable name
2018-12-04 09:29:54 +01:00
Lennart Poettering
686d13b9f2
util-lib: split out env file parsing code into env-file.c
...
It's quite complex, let's split this out.
No code changes, just some file rearranging.
2018-12-02 13:22:29 +01:00
Lennart Poettering
e4de72876e
util-lib: split out all temporary file related calls into tmpfiles-util.c
...
This splits out a bunch of functions from fileio.c that have to do with
temporary files. Simply to make the header files a bit shorter, and to
group things more nicely.
No code changes, just some rearranging of source files.
2018-12-02 13:22:29 +01:00
Yu Watanabe
c6f09e6a2d
locale: define main through macro
2018-11-23 06:22:30 +09:00
Yu Watanabe
af7865c1b7
locale: store polkit_registry in Context
2018-11-23 06:22:30 +09:00
Yu Watanabe
6804d7a849
locale: rename context_free() to context_clear()
2018-11-23 06:22:30 +09:00
Zbigniew Jędrzejewski-Szmek
baaa35ad70
coccinelle: make use of SYNTHETIC_ERRNO
...
Ideally, coccinelle would strip unnecessary braces too. But I do not see any
option in coccinelle for this, so instead, I edited the patch text using
search&replace to remove the braces. Unfortunately this is not fully automatic,
in particular it didn't deal well with if-else-if-else blocks and ifdefs, so
there is an increased likelikehood be some bugs in such spots.
I also removed part of the patch that coccinelle generated for udev, where we
returns -1 for failure. This should be fixed independently.
2018-11-22 10:54:38 +01:00
Zbigniew Jędrzejewski-Szmek
294bf0c34a
Split out pretty-print.c and move pager.c and main-func.h to shared/
...
This is high-level functionality, and fits better in shared/ (which is for
our executables), than in basic/ (which is also for libraries).
2018-11-20 18:40:02 +01:00
Yu Watanabe
847da1ac1b
locale: make "arg_host" const
2018-11-20 18:40:02 +01:00
Zbigniew Jędrzejewski-Szmek
39daad0a81
localectl: define main through macro
2018-11-20 16:48:21 +01:00
Lennart Poettering
6bf3c61c57
log: introduce new helper call log_setup_service()
...
Let's reduce the common boilerplate and have a single setup function
used by all service code to setup logging.
2018-11-20 11:18:22 +01:00
Zbigniew Jędrzejewski-Szmek
cd5a29ce98
Merge pull request #10742 from poettering/c-utf8
...
default to C.UTF-8 locale, and many improvements to env var file parsing/kernel cmdline parsing
2018-11-15 12:47:17 +01:00
Lennart Poettering
042cad5737
Merge pull request #10753 from keszybz/pager-no-interrupt
...
Add mode in journalctl where ^C is handled by the pager
2018-11-14 20:09:39 +01:00
Lennart Poettering
e6755a3350
locale-util: introduce common helper locale_variables_free() for freeing locale variable arrays
2018-11-14 17:01:55 +01:00
Lennart Poettering
13df9c398d
fileio: automatically add NULL sentinel to parse_env_file()
...
Let's modernize things a bit.
2018-11-14 17:01:55 +01:00
Lennart Poettering
608eea8ea0
localed: be more careful with the used types
2018-11-14 17:01:55 +01:00
Lennart Poettering
aa8fbc74e3
fileio: drop "newline" parameter for env file parsers
...
Now that we don't (mis-)use the env file parser to parse kernel command
lines there's no need anymore to override the used newline character
set. Let's hence drop the argument and just "\n\r" always. This nicely
simplifies our code.
2018-11-14 17:01:54 +01:00
Lennart Poettering
01771226c2
tree-wide: replace all remaining uses of parse_env_file() for parsing /proc/cmdline
...
Let's always go through the proc-cmdline.c APIs.
2018-11-14 17:01:54 +01:00
Lennart Poettering
26a9337690
localed: no need to log twice about reload requests
2018-11-14 17:01:54 +01:00
Lennart Poettering
936d113663
localed: show proper bus error if we can in log message
2018-11-14 17:01:54 +01:00
Lennart Poettering
46e8b9470a
localed: don't silently eat up errors, log something
2018-11-14 17:01:54 +01:00
Zbigniew Jędrzejewski-Szmek
0221d68a13
basic/pager: convert the pager options to a flags argument
...
Pretty much everything uses just the first argument, and this doesn't make this
common pattern more complicated, but makes it simpler to pass multiple options.
2018-11-14 16:25:11 +01:00
Lennart Poettering
4b670f8688
hostnamed,localed,timedate: properly propagate errors from sd_event_add_signal()
...
main() can't doesn't expect negative error codes as return.
2018-11-12 17:51:34 +01:00
Yu Watanabe
17acb7ef9a
Merge pull request #10450 from poettering/foreach-line-excorcism
...
FOREACH_LINE excorcism
2018-10-19 08:44:51 +09:00
Lennart Poettering
271c8ec50f
localectl: FOREACH_LINE excorcism
2018-10-18 16:23:45 +02:00
Lennart Poettering
1d47b56995
keymap-util: fgets() excorcism
2018-10-18 13:40:03 +02:00
Lennart Poettering
37ec0fdd34
tree-wide: add clickable man page link to all --help texts
...
This is a bit like the info link in most of GNU's --help texts, but we
don't do info but man pages, and we make them properly clickable on
terminal supporting that, because awesome.
I think it's generally advisable to link up our (brief) --help texts and
our (more comprehensive) man pages a bit, so this should be an easy and
straight-forward way to do it.
2018-08-20 11:33:04 +02:00
Yu Watanabe
4ae25393f3
tree-wide: shorten error logging a bit
...
Continuation of 4027f96aa0
.
2018-08-07 10:14:33 +09:00
Yu Watanabe
65d3426677
locale: increment reference count of sd_bus_message
2018-07-26 12:13:35 +09:00
Yu Watanabe
50008ae48a
locale: set sd_event_add_signal()
2018-07-20 14:59:36 +09:00
Yu Watanabe
f18edd8a0a
tree-wide: add multiple inclusion guard
2018-06-25 13:04:59 +09:00
Zbigniew Jędrzejewski-Szmek
d9b02e1697
tree-wide: drop copyright headers from frequent contributors
...
Fixes #9320 .
for p in Shapovalov Chevalier Rozhkov Sievers Mack Herrmann Schmidt Rudenberg Sahani Landden Andersen Watanabe; do
git grep -e 'Copyright.*'$p -l|xargs perl -i -0pe 's|/([*][*])?[*]\s+([*#]\s+)?Copyright[^\n]*'$p'[^\n]*\s*[*]([*][*])?/\n*|\n|gms; s|\s+([*#]\s+)?Copyright[^\n]*'$p'[^\n]*\n*|\n|gms'
done
2018-06-20 11:58:53 +02:00
Zbigniew Jędrzejewski-Szmek
0cd41d4dff
Drop my copyright headers
...
perl -i -0pe 's/\s*Copyright © .... Zbigniew Jędrzejewski.*?\n/\n/gms' man/*xml
git grep -e 'Copyright.*Jędrzejewski' -l | xargs perl -i -0pe 's/(#\n)?# +Copyright © [0-9, -]+ Zbigniew Jędrzejewski.*?\n//gms'
git grep -e 'Copyright.*Jędrzejewski' -l | xargs perl -i -0pe 's/\s*\/\*\*\*\s+Copyright © [0-9, -]+ Zbigniew Jędrzejewski[^\n]*?\s*\*\*\*\/\s*/\n\n/gms'
git grep -e 'Copyright.*Jędrzejewski' -l | xargs perl -i -0pe 's/\s+Copyright © [0-9, -]+ Zbigniew Jędrzejewski[^\n]*//gms'
2018-06-14 13:03:20 +02:00
Lennart Poettering
96b2fb93c5
tree-wide: beautify remaining copyright statements
...
Let's unify an beautify our remaining copyright statements, with a
unicode ©. This means our copyright statements are now always formatted
the same way. Yay.
2018-06-14 10:20:21 +02:00
Lennart Poettering
0c69794138
tree-wide: remove Lennart's copyright lines
...
These lines are generally out-of-date, incomplete and unnecessary. With
SPDX and git repository much more accurate and fine grained information
about licensing and authorship is available, hence let's drop the
per-file copyright notice. Of course, removing copyright lines of others
is problematic, hence this commit only removes my own lines and leaves
all others untouched. It might be nicer if sooner or later those could
go away too, making git the only and accurate source of authorship
information.
2018-06-14 10:20:20 +02:00
Lennart Poettering
818bf54632
tree-wide: drop 'This file is part of systemd' blurb
...
This part of the copyright blurb stems from the GPL use recommendations:
https://www.gnu.org/licenses/gpl-howto.en.html
The concept appears to originate in times where version control was per
file, instead of per tree, and was a way to glue the files together.
Ultimately, we nowadays don't live in that world anymore, and this
information is entirely useless anyway, as people are very welcome to
copy these files into any projects they like, and they shouldn't have to
change bits that are part of our copyright header for that.
hence, let's just get rid of this old cruft, and shorten our codebase a
bit.
2018-06-14 10:20:20 +02:00
Yu Watanabe
60091993a9
locale: add _unused_ attribute for dummy variable
...
This suppresses the following warning by clang:
```
[588/1179] Compiling C object 'systemd-localed@exe/src_locale_localed.c.o'.
../src/locale/localed.c:271:39: warning: unused variable 'dummy' [-Wunused-variable]
_cleanup_(locale_free) char **dummy = new_locale;
^
```
2018-06-06 12:27:52 +02:00
Yu Watanabe
4156e767f6
locale: assume locale is for LANG= when variable name is not specified
...
Closes #6070 .
2018-05-31 17:57:41 +09:00
Yu Watanabe
df4fd2c757
locale: re-read configuration files if changed
...
Closes #8491 .
2018-05-31 16:24:45 +09:00
Yu Watanabe
6a837b035f
locale: use _cleanup_free_ and free_and_replace
2018-05-31 16:17:18 +09:00