Unix file modes should be stored in a mode_t, not a standard type. At
the moment it is actually unsigned, in fact, not a signed integer.
Attached patch does an s/int mode/mode_t mode/ and cleans up the
results.
> But the test.block script doesn't catch any partitions on the block
> devices :)
Never happy!
[19:07:52]root@phantasy:~/src/udev/udev# ./test.block
[19:13:37]root@phantasy:~/src/udev/udev# ls /udev/hd*
ls: /udev/hd*: No such file or directory
[19:13:42]root@phantasy:~/src/udev/udev# ./test.block
[19:13:53]root@phantasy:~/src/udev/udev# ls /udev/hd*
/udev/hda /udev/hda2 /udev/hda4 /udev/hda6 /udev/hdd
/udev/hda1 /udev/hda3 /udev/hda5 /udev/hdc
test.block now recurses /sys/block, looking for partitions. Should add
all drives and all partitions.
> Hm, I would also like to add the /etc/hotplug.d/default/udev.hotplug
> symlink, but rpm doesn't seem to like symlinks in the %files section.
> Anyone know how to do this properly?
The problem is that the symlink is left dangling to an absolute location
in the build root, which won't exist on the installer's system. RPM 4.0
and on catches this.
Attached patch fixes it up and makes it work.
This patch changes test.tty and test.block to add/remove each tty and
block device, respectively, on the system. Great way to
populate/unpopulate udev rapidly.
Its just a simple for loop over the sysfs entries.
Some spec file changes. Primarily, this makes the thing build without a
build root if so desired (i.e. build right out of /usr/src/redhat and
the standard file system). It should still build from a build root,
too.
Also:
- Add some Prereqs
- Pass RPM_OPT_FLAGS to make so we build with the RPM build
policy (i.e., optimizations, architecture, etc.)
- Specify the exact files in %files to make sure we install
everything properly and avoid a warning
This patch adds a callout config type to udev, so external programs can be
called to get serial numbers or id's that are not available as a sysfs
attribute.
This patch:
1) removes the three database files for just one udevdb.tdb file.
2) adds udevdb_init() and udevdb_exit() functions
3) initializes database now in main() in udev.c.
Please look it over.
The merge of tdb ended up breaking the ability to cross compile again, here's
a bk patch that yanks CC out of the tdb Makefile, and in turn falls back on
the exported CC value from the top-level Makefile which correctly sets it
based off of the CROSS value.
Here's an "idea" of what I had in mind for udevdb. Let me preface the
code with a few remarks:
1) I was expecting to write this udevdb for udev to keep track of
devices. I was planning an external package that depends upon udev
to provide an external API to the udevdb database. The calls for the
interface would be read only access. Not sure how you want to do
packaging, if having a separate package is ok or having it included
in udev.
2) I created it as it is because udev isn't a daemon. So, the open
database call doesn't take any parameters. My plan was to create a
udevdb_init function that took arguments for initializing the db
to start, where you could specify in memory only or a file location.
This can all be filled in.
3) I hacked the Makefile to get it to work. Not sure how you'd want
that in the future.
4) This assumes TDB has been installed elsewhere, you would need to
edit your Makefile and point it to the header and library locations.
How do you want to do TDB in udev? Do you want to just reference it
and make udev dependent on that package being installed. Or should
we do what samba does and include a limited tdb version in udev?
5) Again, I hacked udev into your existing code. In the future, I'd
probably make a function around the filling out the udevice before
calling the store command. Didn't know if you wanted to change
your add device function to use struct udevice rather than having
everything separate.
6) Not sure what we should include in the udevice structure that's stored
by udev. I made a stab at a first shot - we can add and remove of course,
this was a first pass. I've come to realize - with you including libsysfs
in udev, the "external" interface that references udevdb could make
use of getting information from through libsysfs from sysfs and doesn't
need to be in udevdb.
7) I could write a namedevdb for namedev's device management if you
wanted.
Here's a relatively rudimentary patch that addes udev.spec. With this, you can
rpm -ta the tarball and generate rpms. I've also attached the ones I build on
my RH 7.3 host incase they are of interest to you.
I noticed that libsysfs doesn't inherently grab cross compilation arguments
that are set in the top-level Makefile, so I've come up with the following
patch to fix this. With the patch, I can succesfully cross compile for other
architectures (such as sh) by doing 'make ARCH=sh CROSS=sh-linux-' in the
top-level directory.
greg@kroah.com