Lennart Poettering
e5c36295d8
unit: enqueue cgroup empty check event if the last ref on a unit is dropped
2018-11-09 17:08:59 +01:00
Lennart Poettering
c20076a8c1
pid1: add a new AbandonScope() method call on the Manager object
...
This is the same as Abandon() on the Scope object, but saves clients
from first translating a unit name into a unit object path. This logic
matches how all the other unit methods have counterparts on the Manager
object too (e.g. StopUnit() on the Manager object matching Stop() on the
Unit object), this one was simply forgotten so far.
2018-11-09 17:08:59 +01:00
Frantisek Sumsal
7a30256588
tests: keep SYS_PTRACE when running under ASan
2018-11-09 16:26:19 +01:00
Yu Watanabe
e512c6c1aa
network: fix potential segfault in network_free()
2018-11-09 11:45:12 +09:00
Yu Watanabe
d493d82647
network: fix offset for IPv6MTUByte=
...
Fixes oss-fuzz#11302 and oss-fuzz#11314.
2018-11-09 11:44:51 +09:00
Evgeny Vereshchagin
911efe0fbf
Merge pull request #10678 from evverx/more-travis-tweaks
...
travis: also rebuild everything with ASan and UBSan and install dependencies necessary for running parse-hwdb.py
2018-11-09 01:43:57 +03:00
Lennart Poettering
c2baf11c36
cgroup: actually reset the cgroup invalidation mask after we made our changes
...
Previously we never unmasked the mask after it was set once. Let's fix
that.
2018-11-08 15:20:52 +01:00
Lennart Poettering
6529ccfa20
unit: replace three non-type-safe macros by type-safe inline functions
...
Behaviour is prett ymuch the same, but there's some additional type
checking done on the input parameters.
(In the case of UNIT_WRITE_FLAGS_NOOP() the C compiler won't actually do
the type checking necessarily, but static chckers at least could)
2018-11-08 13:55:25 +01:00
Evgeny Vereshchagin
86f4edef54
test: initialize hwdb so that the test won't try to free memory it has never allocated
...
See https://github.com/systemd/systemd/pull/10678#issuecomment-436790906 .
2018-11-08 13:49:45 +01:00
Zbigniew Jędrzejewski-Szmek
abdcb688a8
Merge pull request #10676 from poettering/rdrand-everywhere
...
prefer RDRAND over getrandom() and /dev/urandom when we don't need the very best randomness
2018-11-08 13:33:02 +01:00
Lennart Poettering
010c9a247d
Merge pull request #10651 from yuwata/fix-10598
...
conf-parser: ignore trailing back-slash in comment
2018-11-08 12:36:06 +01:00
Lennart Poettering
2cf6db4fb5
Merge pull request #10687 from mrc0mmand/fix-test-capabilities
...
Fix test-capability
2018-11-08 12:35:39 +01:00
Frantisek Sumsal
c446b8486d
tests: drop the precondition check for inherited flag
...
Docker's default capability set has the inherited flag already
set - that breaks tests which expect otherwise. Let's just
drop the check and run the test anyway.
Fixes #10663
2018-11-08 11:07:21 +01:00
Yu Watanabe
64af816228
core/device: use LIST_FOREACH_AFTER() or friend
2018-11-08 10:58:25 +01:00
Lennart Poettering
bbf1120623
unit: make UNIT() cast function deal with NULL pointers
...
Fixes : #10681
2018-11-08 10:47:08 +01:00
Yu Watanabe
9adbfeb38a
conf-parser: ignore trailing back-slash in comment
...
Fixes #10598 .
2018-11-08 18:09:04 +09:00
Lennart Poettering
cc83d5197c
random-util: optionally allow randomness to be generated via RDRAND
...
We only use this when we don't require the best randomness. The primary
usecase for this is UUID generation, as this means we don't drain
randomness from the kernel pool for them. Since UUIDs are usually not
secrets RDRAND should be goot enough for them to avoid real-life
collisions.
2018-11-08 09:44:27 +01:00
Lennart Poettering
6fb6f13896
random-util: introduce RANDOM_DONT_DRAIN
...
Originally, the high_quality_required boolean argument controlled two
things: whether to extend any random data we successfully read with
pseudo-random data, and whether to return -ENODATA if we couldn't read
any data at all.
The boolean got replaced by RANDOM_EXTEND_WITH_PSEUDO, but this name
doesn't really cover the second part nicely. Moreover hiding both
changes of behaviour under a single flag is confusing. Hence, let's
split this part off under a new flag, and use it from random_bytes().
2018-11-08 09:44:27 +01:00
Lennart Poettering
776cf7461f
random-util: if zero random bytes are requested we can always fulfill the request
2018-11-08 09:44:27 +01:00
Lennart Poettering
68534345b8
random-util: optionally enable blocking getrandom() behaviour
...
When generating the salt for the firstboot password logic, let's use
getrandom() blocking mode, and insist in the very best entropy.
2018-11-08 09:44:27 +01:00
Lennart Poettering
94d457e8d9
random-util: change high_quality_required bool parameter into a flags parameter
...
No change in behaviour, just some refactoring.
2018-11-08 09:44:27 +01:00
Lennart Poettering
afff8f16ae
random-util: fix indentation
2018-11-08 09:44:27 +01:00
Lennart Poettering
d68ccc0841
random-util: handle if getrandom() returns 0
...
This should normally not happen, but given that the man page suggests
something about this in the context of interruption, let's handle this
and propagate an I/O error.
2018-11-08 09:44:27 +01:00
Lennart Poettering
3335dc2d75
random-util: rename acquire_random_bytes() → genuine_random_bytes()
...
It's more descriptive, since we also have a function random_bytes()
which sounds very similar.
Also rename pseudorandom_bytes() to pseudo_random_bytes(). This way the
two functions are nicely systematic, one returning genuine random bytes
and the other pseudo random ones.
2018-11-08 09:44:27 +01:00
Lennart Poettering
8d2411f693
Merge pull request #10682 from yuwata/fix-oss-fuzz-network-issues
...
network: fix memleak
2018-11-08 09:37:35 +01:00
Yu Watanabe
b9c04eafb8
core: introduce exec_params_clear()
...
Follow-up for 1ad6e8b302
.
Fixes #10677 .
2018-11-08 09:36:37 +01:00
Yu Watanabe
28c3428df0
network: adds missing strv_free()
...
Fixes oss-fuzz#11285.
2018-11-08 12:30:03 +09:00
Yu Watanabe
7a99f98b50
network: make config_parse_radv_search_domains() log error in dns_name_apply_idna()
2018-11-08 12:29:38 +09:00
Zbigniew Jędrzejewski-Szmek
e1b2d44366
Merge pull request #10670 from yuwata/oss-fuzz-netdev-fixes
...
network: ignore multiple assignment of netdev kind
2018-11-07 19:31:31 +01:00
Steven Allen
86cf4554ef
logind: fix compilation without utmp ( #10674 )
2018-11-07 17:29:21 +01:00
Jan Synacek
1432d2dbdf
ask-password: improve log message when inotify limit is reached
...
When inotify_add_watch() fails because of the inotify limit, errno is
set to ENOSPC and then gets shown to users as "No space left on device".
That is very confusing and requires in-depth knowledge of the C library.
Therefore, show user-friendly message when inotify limit is reached.
Fixes #6030 .
2018-11-07 15:48:43 +01:00
Zbigniew Jędrzejewski-Szmek
e44c5a3ba6
Merge pull request #10594 from poettering/env-reload-fix
...
change handling of environment block of PID1's manager object
2018-11-07 12:49:13 +01:00
Zbigniew Jędrzejewski-Szmek
e67813dde0
Merge pull request #10610 from yuwata/udev-rules-cleanups
...
udev-rules: replace udev_device by sd_device
2018-11-07 11:34:33 +01:00
Yu Watanabe
1909e9f11d
network: drop unused members in Wireguard object
2018-11-07 18:14:11 +09:00
Yu Watanabe
62facba19a
network: ignore multiple assignment of netdev kind
...
Fixes oss-fuzz#11279 and oss-fuzz#11280.
2018-11-07 17:23:50 +09:00
Yu Watanabe
c6d8bbb66e
in-addr-util: make in_addr_default_prefix_from_string() or friend set 0 to prefixlen when family == AF_INET6 ( #10665 )
...
Follow-up for a4798d4e6d
.
Fixes #10662 .
2018-11-07 15:31:26 +09:00
Yu Watanabe
b74a0b6ae7
test: replace udev_device by sd_device in test-udev
2018-11-07 13:35:03 +09:00
Yu Watanabe
77ad202c72
udevadm-test: replace udev_device by sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
cf28ad4689
udev-event: make udev_event_new() take sd_device instead of udev_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
cf697ec00e
udev-rules: replace udev_device by sd_device in udev_rules_apply_to_event()
2018-11-07 13:35:03 +09:00
Yu Watanabe
dbea7f24d2
udev-rules: replace two udev_list_entry_foreach() by corresponding FOREACH_DEVICE_*() macros
2018-11-07 13:35:03 +09:00
Yu Watanabe
1017d66bf5
udev-rules: use structured initializer
2018-11-07 13:35:03 +09:00
Yu Watanabe
92b80c6baa
udev-rules: drop unused member file_list in struct udev_rules
2018-11-07 13:35:03 +09:00
Yu Watanabe
1ce7fecb4f
udev-rules: make import_parent_into_properties() take sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
13c7b75f2f
udev-rules: make import_file_into_properties() take sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
29b5eb5adf
udev-rules: make import_property_from_string() take sd_device
...
Also, this makes the function return negative errno, though its
return value is always ignored.
2018-11-07 13:35:03 +09:00
Yu Watanabe
f3d241feb2
udev: use sd_device for udev_event.dev_parent
2018-11-07 13:35:03 +09:00
Yu Watanabe
5ba7e79885
udev-rules: make match_attr() take sd_device instead of udev_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
480ecb7d28
udev: use sd_device for udev_event.dev_db
...
Also, this adds sd_device_unref for the object in udev_event_free()
for safety and readability of code.
2018-11-07 13:35:03 +09:00
Yu Watanabe
e0bb2ff94b
udev-event: make udev_event_new() take sd_netlink and take a reference of that
2018-11-07 13:35:03 +09:00