dea7f5cc87
The desktop file specification allows entries like ";;;;;;", full of empty strings. But looking at the actual list of supported keys [1], empty entries are meaningless (unless we would allow e.g. the desktop name to be the empty string. But that doesn't seem very useful either). So let's just simplify our life and skip any empty substrings entirely. This would also resolve the fuzzer case: $ valgrind build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812 test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812... ok ==2899241== HEAP SUMMARY: ==2899241== in use at exit: 0 bytes in 0 blocks ==2899241== total heap usage: 484,385 allocs, 484,385 frees, 12,411,330 bytes allocated ↓ ==2899650== HEAP SUMMARY: ==2899650== in use at exit: 0 bytes in 0 blocks ==2899650== total heap usage: 1,325 allocs, 1,325 frees, 1,463,602 bytes allocated
94 lines
3.1 KiB
C
94 lines
3.1 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
|
|
#include "alloc-util.h"
|
|
#include "fd-util.h"
|
|
#include "fs-util.h"
|
|
#include "string-util.h"
|
|
#include "strv.h"
|
|
#include "tests.h"
|
|
#include "tmpfile-util.h"
|
|
#include "xdg-autostart-service.h"
|
|
|
|
static void test_translate_name(void) {
|
|
_cleanup_free_ char *t;
|
|
|
|
assert_se(t = xdg_autostart_service_translate_name("a-b.blub.desktop"));
|
|
assert_se(streq(t, "app-a\\x2db.blub-autostart.service"));
|
|
}
|
|
|
|
static void test_xdg_format_exec_start_one(const char *exec, const char *expected) {
|
|
_cleanup_free_ char* out = NULL;
|
|
|
|
xdg_autostart_format_exec_start(exec, &out);
|
|
log_info("In: '%s', out: '%s', expected: '%s'", exec, out, expected);
|
|
assert_se(streq(out, expected));
|
|
}
|
|
|
|
static void test_xdg_format_exec_start(void) {
|
|
test_xdg_format_exec_start_one("/bin/sleep 100", "/bin/sleep \"100\"");
|
|
|
|
/* All standardised % identifiers are stripped. */
|
|
test_xdg_format_exec_start_one("/bin/sleep %f \"%F\" %u %U %d %D\t%n %N %i %c %k %v %m", "/bin/sleep");
|
|
|
|
/* Unknown % identifier currently remain, but are escaped. */
|
|
test_xdg_format_exec_start_one("/bin/sleep %X \"%Y\"", "/bin/sleep \"%%X\" \"%%Y\"");
|
|
|
|
test_xdg_format_exec_start_one("/bin/sleep \";\\\"\"", "/bin/sleep \";\\\"\"");
|
|
}
|
|
|
|
static const char* const xdg_desktop_file[] = {
|
|
"[Desktop Entry]\n"
|
|
"Exec\t =\t /bin/sleep 100\n" /* Whitespace Before/After = must be ignored */
|
|
"OnlyShowIn = A;B;\n"
|
|
"NotShowIn=C;;D\\\\\\;;E\n", /* "C", "", "D\;", "E" */
|
|
|
|
"[Desktop Entry]\n"
|
|
"Exec=a\n"
|
|
"Exec=b\n",
|
|
|
|
"[Desktop Entry]\n"
|
|
"Hidden=\t true\n",
|
|
};
|
|
|
|
static void test_xdg_desktop_parse(unsigned i, const char *s) {
|
|
_cleanup_(unlink_tempfilep) char name[] = "/tmp/test-xdg-autostart-parser.XXXXXX";
|
|
_cleanup_fclose_ FILE *f = NULL;
|
|
_cleanup_(xdg_autostart_service_freep) XdgAutostartService *service = NULL;
|
|
|
|
log_info("== %s[%i] ==", __func__, i);
|
|
|
|
assert_se(fmkostemp_safe(name, "r+", &f) == 0);
|
|
assert_se(fwrite(s, strlen(s), 1, f) == 1);
|
|
rewind(f);
|
|
|
|
assert_se(service = xdg_autostart_service_parse_desktop(name));
|
|
|
|
switch (i) {
|
|
case 0:
|
|
assert_se(streq(service->exec_string, "/bin/sleep 100"));
|
|
assert_se(strv_equal(service->only_show_in, STRV_MAKE("A", "B")));
|
|
assert_se(strv_equal(service->not_show_in, STRV_MAKE("C", "D\\;", "E")));
|
|
assert_se(!service->hidden);
|
|
break;
|
|
case 1:
|
|
/* The second entry is not permissible and will be ignored (and error logged). */
|
|
assert_se(streq(service->exec_string, "a"));
|
|
break;
|
|
case 2:
|
|
assert_se(service->hidden);
|
|
break;
|
|
}
|
|
}
|
|
|
|
int main(int argc, char *argv[]) {
|
|
test_setup_logging(LOG_DEBUG);
|
|
|
|
test_translate_name();
|
|
test_xdg_format_exec_start();
|
|
|
|
for (size_t i = 0; i < ELEMENTSOF(xdg_desktop_file); i++)
|
|
test_xdg_desktop_parse(i, xdg_desktop_file[i]);
|
|
|
|
return 0;
|
|
}
|