ec2c7b5659
If the local peer does not dispatch its incoming queue, the bus-proxy will slowly fill its outgoing queue. Once its full, it will continously complain that it cannot forward its messages. As it turns out, pulseaudio does have an idle background dbus connection that is not integrated into any mainloop (and given that gdbus and libdbus1 both support background shared connections, PA is probably not the only example), therefore, the bus-proxy will loudly complain if it cannot forward NameOwnerChanged events once the queue is full. This commit makes the proxy track queue-state and complain only once the queue runs full, not if it is already full. A PA bug-report (and patch) has been filed, and other applications should be fixed similarly. Hence, lets keep the error message, instead of dropping it. It's unused resources we really want to get rid of, so silencing the message does not really help (which is actually what dbus-daemon does).
52 lines
1.4 KiB
C
52 lines
1.4 KiB
C
/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
|
|
|
|
#pragma once
|
|
|
|
/***
|
|
This file is part of systemd.
|
|
|
|
Copyright 2014 David Herrmann
|
|
|
|
systemd is free software; you can redistribute it and/or modify it
|
|
under the terms of the GNU Lesser General Public License as published by
|
|
the Free Software Foundation; either version 2.1 of the License, or
|
|
(at your option) any later version.
|
|
|
|
systemd is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public License
|
|
along with systemd; If not, see <http://www.gnu.org/licenses/>.
|
|
***/
|
|
|
|
#include "sd-bus.h"
|
|
#include "bus-xml-policy.h"
|
|
|
|
typedef struct Proxy Proxy;
|
|
|
|
struct Proxy {
|
|
sd_bus *local_bus;
|
|
struct ucred local_creds;
|
|
int local_in;
|
|
int local_out;
|
|
|
|
sd_bus *destination_bus;
|
|
|
|
Set *owned_names;
|
|
SharedPolicy *policy;
|
|
|
|
bool got_hello : 1;
|
|
bool queue_overflow : 1;
|
|
};
|
|
|
|
int proxy_new(Proxy **out, int in_fd, int out_fd, const char *dest);
|
|
Proxy *proxy_free(Proxy *p);
|
|
|
|
int proxy_set_policy(Proxy *p, SharedPolicy *policy, char **configuration);
|
|
int proxy_hello_policy(Proxy *p, uid_t original_uid);
|
|
int proxy_run(Proxy *p);
|
|
|
|
DEFINE_TRIVIAL_CLEANUP_FUNC(Proxy*, proxy_free);
|