![Lennart Poettering](/assets/img/avatar_default.png)
This reworks the SELinux and SMACK label fixing calls in a number of ways: 1. The two separate boolean arguments of these functions are converted into a flags type LabelFixFlags. 2. The operations are now implemented based on O_PATH. This should resolve TTOCTTOU races between determining the label for the file system object and applying it, as it it allows to pin the object while we are operating on it. 3. When changing a label fails we'll query the label previously set, and if matches what we want to set anyway we'll suppress the error. Also, all calls to label_fix() are now (void)ified, when we ignore the return values. Fixes: #8566
61 lines
1.7 KiB
C
61 lines
1.7 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
/***
|
|
This file is part of systemd.
|
|
|
|
Copyright 2010 Lennart Poettering
|
|
Copyright 2013 Kay Sievers
|
|
|
|
systemd is free software; you can redistribute it and/or modify it
|
|
under the terms of the GNU Lesser General Public License as published by
|
|
the Free Software Foundation; either version 2.1 of the License, or
|
|
(at your option) any later version.
|
|
|
|
systemd is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public License
|
|
along with systemd; If not, see <http://www.gnu.org/licenses/>.
|
|
***/
|
|
|
|
#include <stdio.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
|
|
#include "label.h"
|
|
#include "macro.h"
|
|
#include "mkdir.h"
|
|
#include "selinux-util.h"
|
|
#include "smack-util.h"
|
|
|
|
int mkdir_label(const char *path, mode_t mode) {
|
|
int r;
|
|
|
|
assert(path);
|
|
|
|
r = mac_selinux_create_file_prepare(path, S_IFDIR);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
r = mkdir_errno_wrapper(path, mode);
|
|
mac_selinux_create_file_clear();
|
|
if (r < 0)
|
|
return r;
|
|
|
|
return mac_smack_fix(path, 0);
|
|
}
|
|
|
|
int mkdir_safe_label(const char *path, mode_t mode, uid_t uid, gid_t gid, MkdirFlags flags) {
|
|
return mkdir_safe_internal(path, mode, uid, gid, flags, mkdir_label);
|
|
}
|
|
|
|
int mkdir_parents_label(const char *path, mode_t mode) {
|
|
return mkdir_parents_internal(NULL, path, mode, mkdir_label);
|
|
}
|
|
|
|
int mkdir_p_label(const char *path, mode_t mode) {
|
|
return mkdir_p_internal(NULL, path, mode, mkdir_label);
|
|
}
|