Evgeny Vereshchagin 3bd82598a1 udev: stop freeing value after using it for setting sysattr (#6094) ... This prevents udev from double-freeing and crashing. See https://github.com/systemd/systemd/issues/6040#issuecomment-306589836 ==351== Invalid free() / delete / delete[] / realloc() ==351== at 0x4C2C14B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==351== by 0x13CBE8: hashmap_clear_free_free (hashmap.c:900) ==351== by 0x13CBE8: hashmap_free_free_free (hashmap.c:852) ==351== by 0x147F4F: sd_device_unref (sd-device.c:88) ==351== by 0x130CCC: udev_device_unref (libudev-device.c:552) ==351== by 0x130CD5: udev_device_unref (libudev-device.c:553) ==351== by 0x11FBBB: worker_spawn (udevd.c:488) ==351== by 0x1216E5: event_run (udevd.c:584) ==351== by 0x1216E5: event_queue_start (udevd.c:823) ==351== by 0x122213: on_uevent (udevd.c:927) ==351== by 0x141F2F: source_dispatch (sd-event.c:2272) ==351== by 0x142D52: sd_event_dispatch (sd-event.c:2631) ==351== by 0x142D52: sd_event_run (sd-event.c:2690) ==351== by 0x142D52: sd_event_loop (sd-event.c:2710) ==351== by 0x1159CB: run (udevd.c:1643) ==351== by 0x1159CB: main (udevd.c:1772) ==351== Address 0x81745b0 is 0 bytes inside a block of size 1 free'd ==351== at 0x4C2C14B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==351== by 0x1447F0: freep (alloc-util.h:57) ==351== by 0x1447F0: sd_device_set_sysattr_value (sd-device.c:1859) ==351== by 0x132081: udev_device_set_sysattr_value (libudev-device.c:849) ==351== by 0x12E777: set_trackpoint_sensitivity (udev-builtin-keyboard.c:180) ==351== by 0x12E777: builtin_keyboard.lto_priv.170 (udev-builtin-keyboard.c:263) ==351== by 0x14D03F: udev_builtin_run.constprop.75 (udev-builtin.c:133) ==351== by 0x11FAEB: udev_event_execute_run (udev-event.c:957) ==351== by 0x11FAEB: worker_spawn (udevd.c:461) ==351== by 0x1216E5: event_run (udevd.c:584) ==351== by 0x1216E5: event_queue_start (udevd.c:823) ==351== by 0x122213: on_uevent (udevd.c:927) ==351== by 0x141F2F: source_dispatch (sd-event.c:2272) ==351== by 0x142D52: sd_event_dispatch (sd-event.c:2631) ==351== by 0x142D52: sd_event_run (sd-event.c:2690) ==351== by 0x142D52: sd_event_loop (sd-event.c:2710) ==351== by 0x1159CB: run (udevd.c:1643) ==351== by 0x1159CB: main (udevd.c:1772) ==351== Block was alloc'd at ==351== at 0x4C2CF35: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==351== by 0x144853: sd_device_set_sysattr_value (sd-device.c:1888) ==351== by 0x132081: udev_device_set_sysattr_value (libudev-device.c:849) ==351== by 0x12E777: set_trackpoint_sensitivity (udev-builtin-keyboard.c:180) ==351== by 0x12E777: builtin_keyboard.lto_priv.170 (udev-builtin-keyboard.c:263) ==351== by 0x14D03F: udev_builtin_run.constprop.75 (udev-builtin.c:133) ==351== by 0x11FAEB: udev_event_execute_run (udev-event.c:957) ==351== by 0x11FAEB: worker_spawn (udevd.c:461) ==351== by 0x1216E5: event_run (udevd.c:584) ==351== by 0x1216E5: event_queue_start (udevd.c:823) ==351== by 0x122213: on_uevent (udevd.c:927) ==351== by 0x141F2F: source_dispatch (sd-event.c:2272) ==351== by 0x142D52: sd_event_dispatch (sd-event.c:2631) ==351== by 0x142D52: sd_event_run (sd-event.c:2690) ==351== by 0x142D52: sd_event_loop (sd-event.c:2710) ==351== by 0x1159CB: run (udevd.c:1643) ==351== by 0x1159CB: main (udevd.c:1772)		2017-06-06 21:47:47 -04:00
..
sd-bus	sd-bus: silence format warnings in kdbus code (#6072)	2017-06-03 11:41:17 +02:00
sd-daemon	Add sd_is_socket_sockaddr (#4885)	2016-12-14 11:51:26 +01:00
sd-device	udev: stop freeing value after using it for setting sysattr (#6094)	2017-06-06 21:47:47 -04:00
sd-event	Fix includes (#5980)	2017-05-19 10:01:35 -04:00
sd-hwdb	sd-hwdb: drop caching of search string	2016-11-30 15:51:08 -05:00
sd-id128	core: store the invocation ID in the per-service keyring	2016-12-13 20:59:36 +01:00
sd-login	sd-login: sd_get_machine_names(): do not return -EINVAL when output parameter is NULL	2017-05-31 19:22:38 -04:00
sd-netlink	sd-netlink: Make use of IN_SET (#5977)	2017-05-18 12:56:36 +02:00
sd-network	Fix missing space in comments (#5439)	2017-02-24 18:14:02 +01:00
sd-path	tree-wide: drop NULL sentinel from strjoin	2016-10-23 11:43:27 -04:00
sd-resolve	sd-resolve: use close_many() (#3643)	2016-07-02 08:17:26 -07:00
sd-utf8	tree-wide: remove Emacs lines from all files	2016-02-10 13:41:57 +01:00
.gitignore	libsystemd: remove list of symbols to export only in the future	2015-06-17 16:21:13 +02:00
libsystemd.pc.in	Adjust pkgconfig files to point at rootlibdir (#4584)	2016-11-08 09:36:41 +01:00
libsystemd.sym	Export sd_bus_message_append_ap. It is renamed to sd_bus_message_appendv to follow systemd naming conventions. (#5753)	2017-04-25 09:32:24 +02:00
Makefile	libsystemd-bus: rename to libsystemd	2014-01-13 18:54:19 +01:00
meson.build	meson: reindent all files with 8 spaces	2017-04-23 21:47:29 -04:00