42541a71a2
We had atomic counters, but all other operations were non-serialized. This means that concurrent access to the bus object was only safe if _all_ threads were doing read-only access. Even sending of messages from threads would not be possible, because after sending of the message we usually want to remove it from the send queue in the bus object, which would race. Let's just kill this.
80 lines
2.3 KiB
C
80 lines
2.3 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
|
|
#include <stdio.h>
|
|
|
|
#include "sd-bus.h"
|
|
|
|
#include "bus-internal.h"
|
|
#include "bus-message.h"
|
|
#include "bus-util.h"
|
|
#include "tests.h"
|
|
|
|
static bool use_system_bus = false;
|
|
|
|
static void test_bus_new(void) {
|
|
_cleanup_(sd_bus_unrefp) sd_bus *bus = NULL;
|
|
|
|
assert_se(sd_bus_new(&bus) == 0);
|
|
assert_se(bus->n_ref == 1);
|
|
}
|
|
|
|
static int test_bus_open(void) {
|
|
_cleanup_(sd_bus_flush_close_unrefp) sd_bus *bus = NULL;
|
|
int r;
|
|
|
|
r = sd_bus_open_user(&bus);
|
|
if (IN_SET(r, -ECONNREFUSED, -ENOENT)) {
|
|
r = sd_bus_open_system(&bus);
|
|
if (IN_SET(r, -ECONNREFUSED, -ENOENT))
|
|
return r;
|
|
use_system_bus = true;
|
|
}
|
|
|
|
assert_se(r >= 0);
|
|
assert_se(bus->n_ref >= 1); /* we send a hello message when opening, so the count is above 1 */
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void test_bus_new_method_call(void) {
|
|
sd_bus *bus = NULL;
|
|
_cleanup_(sd_bus_message_unrefp) sd_bus_message *m = NULL;
|
|
|
|
assert_se(use_system_bus ? sd_bus_open_system(&bus) >= 0 : sd_bus_open_user(&bus) >= 0);
|
|
|
|
assert_se(sd_bus_message_new_method_call(bus, &m, "a.service.name", "/an/object/path", "an.interface.name", "AMethodName") >= 0);
|
|
|
|
assert_se(m->n_ref == 1); /* We hold the only reference to the message */
|
|
assert_se(bus->n_ref >= 2);
|
|
sd_bus_flush_close_unref(bus);
|
|
assert_se(m->n_ref == 1);
|
|
}
|
|
|
|
static void test_bus_new_signal(void) {
|
|
sd_bus *bus = NULL;
|
|
_cleanup_(sd_bus_message_unrefp) sd_bus_message *m = NULL;
|
|
|
|
assert_se(use_system_bus ? sd_bus_open_system(&bus) >= 0 : sd_bus_open_user(&bus) >= 0);
|
|
|
|
assert_se(sd_bus_message_new_signal(bus, &m, "/an/object/path", "an.interface.name", "Name") >= 0);
|
|
|
|
assert_se(m->n_ref == 1); /* We hold the only reference to the message */
|
|
assert_se(bus->n_ref >= 2);
|
|
sd_bus_flush_close_unref(bus);
|
|
assert_se(m->n_ref == 1);
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
test_setup_logging(LOG_INFO);
|
|
|
|
test_bus_new();
|
|
|
|
if (test_bus_open() < 0)
|
|
return log_tests_skipped("Failed to connect to bus");
|
|
|
|
test_bus_new_method_call();
|
|
test_bus_new_signal();
|
|
|
|
return EXIT_SUCCESS;
|
|
}
|