8150acb160
Let's show a message at the time of logout i.e. entering the "closing" state, not just e.g. once the user closes `tmux` and the session can be removed completely. (At least when KillUserProcesses=no applies. My thinking was we can spare the log noise if we're killing the processes anyway). These are two independent events. I think the logout event is quite significant in the session lifecycle. It will be easier for a user who does not know logind details to understand why "Removed session" doesn't appear at logout time, if we have a specific message we can show at this time :). Tested using tmux and KillUserProcesses=no. I can also confirm the extra message doesn't show when using KillUserProcesses=yes. Maybe it looks a bit mysterious when you use KillOnlyUsers= / KillExcludeUsers=, but hopefully not alarmingly so. I was looking at systemd-logind messages on my system, because I can reproduce two separate problems with Gnome on Fedora 28 where sessions are unexpectedly in state "closing". (One where a GUI session limps along in a degraded state[1], and another where spice-vdagent is left alive after logout, keeping the session around[2]). It logged when sessions were created and removed, but it didn't log when the session entered the "closing" state. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1583240#c1 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1583261 Closes #9096 |
||
---|---|---|
.. | ||
70-power-switch.rules | ||
70-uaccess.rules | ||
71-seat.rules.in | ||
73-seat-late.rules.m4 | ||
inhibit.c | ||
loginctl.c | ||
logind-acl.c | ||
logind-acl.h | ||
logind-action.c | ||
logind-action.h | ||
logind-button.c | ||
logind-button.h | ||
logind-core.c | ||
logind-dbus.c | ||
logind-device.c | ||
logind-device.h | ||
logind-gperf.gperf | ||
logind-inhibit.c | ||
logind-inhibit.h | ||
logind-seat-dbus.c | ||
logind-seat.c | ||
logind-seat.h | ||
logind-session-dbus.c | ||
logind-session-device.c | ||
logind-session-device.h | ||
logind-session.c | ||
logind-session.h | ||
logind-user-dbus.c | ||
logind-user.c | ||
logind-user.h | ||
logind-utmp.c | ||
logind.c | ||
logind.conf.in | ||
logind.h | ||
meson.build | ||
org.freedesktop.login1.conf | ||
org.freedesktop.login1.policy | ||
org.freedesktop.login1.service | ||
pam_systemd.c | ||
pam_systemd.sym | ||
sysfs-show.c | ||
sysfs-show.h | ||
systemd-user.m4 | ||
test-inhibit.c | ||
test-login-shared.c | ||
test-login-tables.c | ||
user-runtime-dir.c |