5102765695
When we a reply message gets longer than the client supports we need to truncate the response and set the TC bit, and we already do that. However, we are not supposed to send incomplete RRs in that case, but instead truncate right at a record boundary. Do that. This fixes the "Message parser reports malformed message packet." warning the venerable "host" tool outputs when a very large response is requested. See: #6520
134 lines
4.3 KiB
C
134 lines
4.3 KiB
C
/***
|
|
This file is part of systemd
|
|
|
|
Copyright 2016 Zbigniew Jędrzejewski-Szmek
|
|
|
|
systemd is free software; you can redistribute it and/or modify it
|
|
under the terms of the GNU Lesser General Public License as published by
|
|
the Free Software Foundation; either version 2.1 of the License, or
|
|
(at your option) any later version.
|
|
|
|
systemd is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public License
|
|
along with systemd; If not, see <http://www.gnu.org/licenses/>.
|
|
***/
|
|
|
|
#include <net/if.h>
|
|
#include <glob.h>
|
|
|
|
#include "alloc-util.h"
|
|
#include "fileio.h"
|
|
#include "glob-util.h"
|
|
#include "log.h"
|
|
#include "macro.h"
|
|
#include "resolved-dns-packet.h"
|
|
#include "resolved-dns-rr.h"
|
|
#include "string-util.h"
|
|
#include "strv.h"
|
|
#include "tests.h"
|
|
#include "unaligned.h"
|
|
|
|
#define HASH_KEY SD_ID128_MAKE(d3,1e,48,90,4b,fa,4c,fe,af,9d,d5,a1,d7,2e,8a,b1)
|
|
|
|
static void verify_rr_copy(DnsResourceRecord *rr) {
|
|
_cleanup_(dns_resource_record_unrefp) DnsResourceRecord *copy = NULL;
|
|
const char *a, *b;
|
|
|
|
assert_se(copy = dns_resource_record_copy(rr));
|
|
assert_se(dns_resource_record_equal(copy, rr) > 0);
|
|
|
|
assert_se(a = dns_resource_record_to_string(rr));
|
|
assert_se(b = dns_resource_record_to_string(copy));
|
|
|
|
assert_se(streq(a, b));
|
|
}
|
|
|
|
static uint64_t hash(DnsResourceRecord *rr) {
|
|
struct siphash state;
|
|
|
|
siphash24_init(&state, HASH_KEY.bytes);
|
|
dns_resource_record_hash_func(rr, &state);
|
|
return siphash24_finalize(&state);
|
|
}
|
|
|
|
static void test_packet_from_file(const char* filename, bool canonical) {
|
|
_cleanup_free_ char *data = NULL;
|
|
size_t data_size, packet_size, offset;
|
|
|
|
assert_se(read_full_file(filename, &data, &data_size) >= 0);
|
|
assert_se(data);
|
|
assert_se(data_size > 8);
|
|
|
|
log_info("============== %s %s==============", filename, canonical ? "canonical " : "");
|
|
|
|
for (offset = 0; offset < data_size; offset += 8 + packet_size) {
|
|
_cleanup_(dns_packet_unrefp) DnsPacket *p = NULL, *p2 = NULL;
|
|
_cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL, *rr2 = NULL;
|
|
const char *s, *s2;
|
|
uint64_t hash1, hash2;
|
|
|
|
packet_size = unaligned_read_le64(data + offset);
|
|
assert_se(packet_size > 0);
|
|
assert_se(offset + 8 + packet_size <= data_size);
|
|
|
|
assert_se(dns_packet_new(&p, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX) >= 0);
|
|
|
|
assert_se(dns_packet_append_blob(p, data + offset + 8, packet_size, NULL) >= 0);
|
|
assert_se(dns_packet_read_rr(p, &rr, NULL, NULL) >= 0);
|
|
|
|
verify_rr_copy(rr);
|
|
|
|
s = dns_resource_record_to_string(rr);
|
|
assert_se(s);
|
|
puts(s);
|
|
|
|
hash1 = hash(rr);
|
|
|
|
assert_se(dns_resource_record_to_wire_format(rr, canonical) >= 0);
|
|
|
|
assert_se(dns_packet_new(&p2, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX) >= 0);
|
|
assert_se(dns_packet_append_blob(p2, rr->wire_format, rr->wire_format_size, NULL) >= 0);
|
|
assert_se(dns_packet_read_rr(p2, &rr2, NULL, NULL) >= 0);
|
|
|
|
verify_rr_copy(rr);
|
|
|
|
s2 = dns_resource_record_to_string(rr);
|
|
assert_se(s2);
|
|
assert_se(streq(s, s2));
|
|
|
|
hash2 = hash(rr);
|
|
assert_se(hash1 == hash2);
|
|
}
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
int i, N;
|
|
_cleanup_globfree_ glob_t g = {};
|
|
char **fnames;
|
|
|
|
log_parse_environment();
|
|
|
|
if (argc >= 2) {
|
|
N = argc - 1;
|
|
fnames = argv + 1;
|
|
} else {
|
|
assert_se(glob(get_testdata_dir("/test-resolve/*.pkts"), GLOB_NOSORT, NULL, &g) == 0);
|
|
N = g.gl_pathc;
|
|
fnames = g.gl_pathv;
|
|
}
|
|
|
|
for (i = 0; i < N; i++) {
|
|
test_packet_from_file(fnames[i], false);
|
|
puts("");
|
|
test_packet_from_file(fnames[i], true);
|
|
if (i + 1 < N)
|
|
puts("");
|
|
}
|
|
|
|
return EXIT_SUCCESS;
|
|
}
|