picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
Systemd/src/shared
History
Alan Jenkins 5c19ff79de seccomp-util: fix alarming debug message (#8002, #8001) 
Booting with `systemd.log_level=debug` and looking in `dmesg -u` showed
messages like this:

    systemd[433]: Failed to add rule for system call n/a() / 156, ignoring:
    Numerical argument out of domain

This commit fixes it to:

    systemd[449]: Failed to add rule for system call _sysctl() / 156,
    ignoring: Numerical argument out of domain

Some of the messages could be even more misleading, e.g. we were reporting
that utimensat() / 320 was skipped as non-existent on x86, when actually
the syscall number 320 is kexec_file_load() on x86 .

The problem was that syscall NRs are looked up (and correctly passed to
libseccomp) as native syscall NRs.  But we forgot that when we tried to
go back from the syscall NR to the name.

I think the natural way to write this would be
seccomp_syscall_resolve_num(nr), however there is no such function.
I couldn't work out a short comment that would make this clearer.  FWIW
I wrote it up as a ticket for libseccomp instead.
https://github.com/seccomp/libseccomp/issues/104
2018-01-31 17:20:14 +00:00
..
linux Add SPDX license identifiers to source files under the GPL 2017-11-19 19:08:15 +01:00
linux-3.13 Avoid strict DM interface version dependencies (#5519) 2017-03-02 19:11:37 +01:00
acl-util.c acl: fix typo in comment (#7580) 2017-12-08 13:34:25 +01:00
acl-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
acpi-fpdt.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
acpi-fpdt.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
apparmor-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
apparmor-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
ask-password-api.c io-util: make flush_fd() return how many bytes where flushed 2018-01-05 13:55:08 +01:00
ask-password-api.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
base-filesystem.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
base-filesystem.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
boot-timestamps.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
boot-timestamps.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
bootspec.c log: minimize includes in log.h 2018-01-11 14:44:31 +01:00
bootspec.h efi: rework find_esp() error propagation/logging a bit 2017-12-11 23:18:56 +01:00
bus-unit-util.c coccinelle: let's use STRLEN() rather strlen() at one more place 2018-01-24 11:07:47 +01:00
bus-unit-util.h bus-unit-util: add socket unit related options 2017-12-23 18:48:16 +09:00
bus-util.c bus-util: fix format of NextElapseUSecRealtime= and LastTriggerUSec= 2018-01-25 14:49:24 +01:00
bus-util.h bus-util: add bool property setter 2018-01-22 18:06:56 +01:00
cgroup-show.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
cgroup-show.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
clean-ipc.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
clean-ipc.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
condition.c cocci: use strempty() at more places 2018-01-10 17:11:19 +01:00
condition.h condition: introduce condition_takes_path() 2018-01-02 02:23:26 +09:00
conf-parser.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
conf-parser.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
dev-setup.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
dev-setup.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
dissect-image.c gpt-auto: discard boot0/1 hw partitions along rpmb 2018-01-25 14:25:27 +01:00
dissect-image.h log: minimize includes in log.h 2018-01-11 14:44:31 +01:00
dns-domain.c resolved: fix "in-between" logic when boundaries are equal (#7590) 2017-12-14 14:08:21 +09:00
dns-domain.h shared: introduce dnssd_srv_type_is_valid() function 2017-12-08 14:29:27 +02:00
dropin.c shared/dropin: ignore ENAMETOOLONG when checking drop-in directories (#7525) 2017-12-01 20:34:49 +01:00
dropin.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
efivars.c efivars: if OsIndicationsSupported does not exist, assume that reboot-to-firmware is not available 2017-11-24 12:00:09 +01:00
efivars.h efivars: include errno.h when EFI support is disabled (#7900) 2018-01-17 20:25:42 +11:00
fdset.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
fdset.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
firewall-util.c shared: silence gcc warning (#7402) 2017-11-21 08:24:12 +01:00
firewall-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
fstab-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
fstab-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
generator.c generator: add helper function for writing unit files 2017-12-15 16:47:11 +01:00
generator.h generator: add helper function for writing unit files 2017-12-15 16:47:11 +01:00
gpt.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
ima-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
ima-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
import-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
import-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
initreq.h build-sys: move more files from core/ to share/ that are generic enough 2013-11-22 16:31:40 +01:00
install-printf.c specifier: unify specifier implementations for user-related specifiers 2017-11-29 12:32:56 +01:00
install-printf.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
install.c install: search preset files in /run (#7715) 2018-01-05 13:15:42 +01:00
install.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
journal-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
journal-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
libshared.sym shared: Add a linker script so that all functions are tagget @SD_SHARED instead of @Base (#6669) 2017-08-28 18:49:03 +02:00
logs-show.c Merge pull request #7881 from keszybz/pcre 2018-01-28 15:29:10 +01:00
logs-show.h journalctl: add highlighting for matched substring 2018-01-28 14:50:01 +01:00
loop-util.c log: minimize includes in log.h 2018-01-11 14:44:31 +01:00
loop-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
machine-image.c machine-image: convert image_hashmap_free() to an static inline helper 2017-11-28 21:30:43 +01:00
machine-image.h machine-image: convert image_hashmap_free() to an static inline helper 2017-11-28 21:30:43 +01:00
machine-pool.c tree-wide: make use of wait_for_terminate_and_check() at various places 2018-01-04 13:27:27 +01:00
machine-pool.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
meson.build Merge pull request #7191 from Mic92/systemd 2018-01-09 14:35:54 +01:00
nsflags.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
nsflags.h nsflags: add namespace_flag_to_string_many_with_check() 2018-01-02 02:23:43 +09:00
output-mode.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
output-mode.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
pager.c pager: let's move static variables up, to the rest of them 2018-01-04 13:27:27 +01:00
pager.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
path-lookup.c shared: export xdg_user_dirs() and xdg_user_*_dir() 2017-12-06 10:18:11 +01:00
path-lookup.h shared: export xdg_user_dirs() and xdg_user_*_dir() 2017-12-06 10:18:11 +01:00
ptyfwd.c run: run pty forwarder at higher event priority than the bus 2017-12-05 18:33:24 +01:00
ptyfwd.h run: run pty forwarder at higher event priority than the bus 2017-12-05 18:33:24 +01:00
resolve-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
resolve-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
seccomp-util.c seccomp-util: fix alarming debug message (#8002, #8001) 2018-01-31 17:20:14 +00:00
seccomp-util.h core,seccomp: fix logic to parse syscall filter in dbus-execute.c 2017-12-23 18:45:32 +09:00
sleep-config.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
sleep-config.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
spawn-ask-password-agent.c pager,agent: insist that we are called from the main thread 2018-01-04 13:27:27 +01:00
spawn-ask-password-agent.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
spawn-polkit-agent.c pager,agent: insist that we are called from the main thread 2018-01-04 13:27:27 +01:00
spawn-polkit-agent.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
specifier.c shared: use _cleanup_ in specifier_printf (#7586) 2017-12-08 19:28:02 +03:00
specifier.h specifier: unify specifier implementations for user-related specifiers 2017-11-29 12:32:56 +01:00
switch-root.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
switch-root.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
sysctl-util.c sysctl: use raw file descriptor in sysctl_write (#7753) 2017-12-30 12:16:49 +01:00
sysctl-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
test-tables.h log: minimize includes in log.h 2018-01-11 14:44:31 +01:00
tests.c tree-wide: use EXIT_SUCCESS/EXIT_FAILURE in exit() where we can 2017-12-25 11:48:21 +01:00
tests.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
tomoyo-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
tomoyo-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
udev-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
udev-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
uid-range.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
uid-range.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
utmp-wtmp.c coccinelle: O_NDELAY → O_NONBLOCK 2018-01-24 11:09:29 +01:00
utmp-wtmp.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
vlan-util.c Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
vlan-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
volatile-util.c log: minimize includes in log.h 2018-01-11 14:44:31 +01:00
volatile-util.h Add SPDX license identifiers to source files under the LGPL 2017-11-19 19:08:15 +01:00
watchdog.c watchdog: allow a device path to be specified 2017-12-08 11:26:30 -06:00
watchdog.h watchdog: allow a device path to be specified 2017-12-08 11:26:30 -06:00
wireguard-netlink.h networkd: add support for wireguard interface type 2018-01-09 14:00:49 +01:00