3ca1fab70a
They are not really boolean, because we have both ipv4 and ipv6, but
for each protocol we have either unset, no, and yes.
From https://github.com/systemd/systemd/issues/13316#issuecomment-582906817:
LinkLocalAddressing must be a boolean option, at least for ipv4:
- LinkLocalAddressing=no => no LL at all.
- LinkLocalAddressing=yes + Static Address => invalid configuration, warn and
interpret as LinkLocalAddressing=no, no LL at all.
(we check that during parsing and reject)
- LinkLocalAddressing=yes + DHCP => LL process should be subordinated to the
DHCP one, an LL address must be acquired at start or after a short N
unsuccessful DHCP attemps, and must not stop DHCP to keeping trying. When a
DHCP address is acquired, drop the LL address. If the DHCP address is lost,
re-adquire a new LL address.
(next patch will move in this direction)
- LinkLocalAddressing=fallback has no reason to exist, because LL address must
always be allocated as a fallback option when using DHCP. Having both DHCP
and LL address at the same time is an RFC violation, so
LinkLocalAdressing=yes correctly implemented is already the "fallback"
behavior. The fallback option must be deprecated and if present in older
configs must be interpreted as LinkLocalAddressing=yes.
(removed)
- And for IPv6, the LinkLocalAddress option has any sense at all? IPv6-LL
address aren't required to be always set for every IPv6 enabled interface (in
this case, coexisting with static or dynamic address if any)? Shouldn't be
always =yes?
(good question)
This effectively reverts 29e81083bd. There is no
special "fallback" mode now, so the check doesn't make sense anymore.
111 lines
6.3 KiB
C
111 lines
6.3 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
#pragma once
|
|
|
|
#include <errno.h>
|
|
#include <stddef.h>
|
|
#include <stdio.h>
|
|
#include <sys/types.h>
|
|
|
|
#include "macro.h"
|
|
#include "parse-util.h"
|
|
#include "string-util.h"
|
|
|
|
ssize_t string_table_lookup(const char * const *table, size_t len, const char *key);
|
|
|
|
/* For basic lookup tables with strictly enumerated entries */
|
|
#define _DEFINE_STRING_TABLE_LOOKUP_TO_STRING(name,type,scope) \
|
|
scope const char *name##_to_string(type i) { \
|
|
if (i < 0 || i >= (type) ELEMENTSOF(name##_table)) \
|
|
return NULL; \
|
|
return name##_table[i]; \
|
|
}
|
|
|
|
#define _DEFINE_STRING_TABLE_LOOKUP_FROM_STRING(name,type,scope) \
|
|
scope type name##_from_string(const char *s) { \
|
|
return (type) string_table_lookup(name##_table, ELEMENTSOF(name##_table), s); \
|
|
}
|
|
|
|
#define _DEFINE_STRING_TABLE_LOOKUP_FROM_STRING_WITH_BOOLEAN(name,type,yes,scope) \
|
|
scope type name##_from_string(const char *s) { \
|
|
if (!s) \
|
|
return -1; \
|
|
int b = parse_boolean(s); \
|
|
if (b == 0) \
|
|
return (type) 0; \
|
|
if (b > 0) \
|
|
return yes; \
|
|
return (type) string_table_lookup(name##_table, ELEMENTSOF(name##_table), s); \
|
|
}
|
|
|
|
#define _DEFINE_STRING_TABLE_LOOKUP_TO_STRING_FALLBACK(name,type,max,scope) \
|
|
scope int name##_to_string_alloc(type i, char **str) { \
|
|
char *s; \
|
|
if (i < 0 || i > max) \
|
|
return -ERANGE; \
|
|
if (i < (type) ELEMENTSOF(name##_table) && name##_table[i]) { \
|
|
s = strdup(name##_table[i]); \
|
|
if (!s) \
|
|
return -ENOMEM; \
|
|
} else { \
|
|
if (asprintf(&s, "%i", i) < 0) \
|
|
return -ENOMEM; \
|
|
} \
|
|
*str = s; \
|
|
return 0; \
|
|
}
|
|
|
|
#define _DEFINE_STRING_TABLE_LOOKUP_FROM_STRING_FALLBACK(name,type,max,scope) \
|
|
scope type name##_from_string(const char *s) { \
|
|
unsigned u = 0; \
|
|
type i; \
|
|
if (!s) \
|
|
return (type) -1; \
|
|
i = (type) string_table_lookup(name##_table, ELEMENTSOF(name##_table), s); \
|
|
if (i >= 0) \
|
|
return i; \
|
|
if (safe_atou(s, &u) >= 0 && u <= max) \
|
|
return (type) u; \
|
|
return (type) -1; \
|
|
} \
|
|
|
|
#define _DEFINE_STRING_TABLE_LOOKUP(name,type,scope) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_TO_STRING(name,type,scope) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_FROM_STRING(name,type,scope)
|
|
|
|
#define _DEFINE_STRING_TABLE_LOOKUP_WITH_BOOLEAN(name,type,yes,scope) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_TO_STRING(name,type,scope) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_FROM_STRING_WITH_BOOLEAN(name,type,yes,scope)
|
|
|
|
#define DEFINE_STRING_TABLE_LOOKUP(name,type) _DEFINE_STRING_TABLE_LOOKUP(name,type,)
|
|
#define DEFINE_PRIVATE_STRING_TABLE_LOOKUP(name,type) _DEFINE_STRING_TABLE_LOOKUP(name,type,static)
|
|
#define DEFINE_PRIVATE_STRING_TABLE_LOOKUP_TO_STRING(name,type) _DEFINE_STRING_TABLE_LOOKUP_TO_STRING(name,type,static)
|
|
#define DEFINE_PRIVATE_STRING_TABLE_LOOKUP_FROM_STRING(name,type) _DEFINE_STRING_TABLE_LOOKUP_FROM_STRING(name,type,static)
|
|
|
|
#define DEFINE_STRING_TABLE_LOOKUP_WITH_BOOLEAN(name,type,yes) _DEFINE_STRING_TABLE_LOOKUP_WITH_BOOLEAN(name,type,yes,)
|
|
|
|
/* For string conversions where numbers are also acceptable */
|
|
#define DEFINE_STRING_TABLE_LOOKUP_WITH_FALLBACK(name,type,max) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_TO_STRING_FALLBACK(name,type,max,) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_FROM_STRING_FALLBACK(name,type,max,)
|
|
|
|
#define DEFINE_PRIVATE_STRING_TABLE_LOOKUP_TO_STRING_FALLBACK(name,type,max) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_TO_STRING_FALLBACK(name,type,max,static)
|
|
#define DEFINE_PRIVATE_STRING_TABLE_LOOKUP_FROM_STRING_FALLBACK(name,type,max) \
|
|
_DEFINE_STRING_TABLE_LOOKUP_FROM_STRING_FALLBACK(name,type,max,static)
|
|
|
|
#define DUMP_STRING_TABLE(name,type,max) \
|
|
do { \
|
|
type _k; \
|
|
flockfile(stdout); \
|
|
for (_k = 0; _k < (max); _k++) { \
|
|
const char *_t; \
|
|
_t = name##_to_string(_k); \
|
|
if (!_t) \
|
|
continue; \
|
|
fputs_unlocked(_t, stdout); \
|
|
fputc_unlocked('\n', stdout); \
|
|
} \
|
|
funlockfile(stdout); \
|
|
} while(false)
|