52ef5dd798
Let's clean up hostname_is_valid() a bit: let's turn the second boolean argument into a more explanatory flags field, and add a flag that accepts the special name ".host" as valid. This is useful for the container logic, where the special hostname ".host" refers to the "root container", i.e. the host system itself, and can be specified at various places. let's also get rid of machine_name_is_valid(). It was just an alias, which is confusing and even more so now that we have the flags param.
173 lines
7.4 KiB
C
173 lines
7.4 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
#include <unistd.h>
|
|
|
|
#include "alloc-util.h"
|
|
#include "fileio.h"
|
|
#include "hostname-util.h"
|
|
#include "string-util.h"
|
|
#include "tmpfile-util.h"
|
|
#include "util.h"
|
|
|
|
static void test_hostname_is_valid(void) {
|
|
assert_se(hostname_is_valid("foobar", 0));
|
|
assert_se(hostname_is_valid("foobar.com", 0));
|
|
assert_se(!hostname_is_valid("foobar.com.", 0));
|
|
assert_se(hostname_is_valid("fooBAR", 0));
|
|
assert_se(hostname_is_valid("fooBAR.com", 0));
|
|
assert_se(!hostname_is_valid("fooBAR.", 0));
|
|
assert_se(!hostname_is_valid("fooBAR.com.", 0));
|
|
assert_se(!hostname_is_valid("fööbar", 0));
|
|
assert_se(!hostname_is_valid("", 0));
|
|
assert_se(!hostname_is_valid(".", 0));
|
|
assert_se(!hostname_is_valid("..", 0));
|
|
assert_se(!hostname_is_valid("foobar.", 0));
|
|
assert_se(!hostname_is_valid(".foobar", 0));
|
|
assert_se(!hostname_is_valid("foo..bar", 0));
|
|
assert_se(!hostname_is_valid("foo.bar..", 0));
|
|
assert_se(!hostname_is_valid("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx", 0));
|
|
assert_se(!hostname_is_valid("au-xph5-rvgrdsb5hcxc-47et3a5vvkrc-server-wyoz4elpdpe3.openstack.local", 0));
|
|
|
|
assert_se(hostname_is_valid("foobar", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(hostname_is_valid("foobar.com", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(hostname_is_valid("foobar.com.", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(hostname_is_valid("fooBAR", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(hostname_is_valid("fooBAR.com", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("fooBAR.", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(hostname_is_valid("fooBAR.com.", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("fööbar", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid(".", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("..", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("foobar.", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid(".foobar", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("foo..bar", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("foo.bar..", VALID_HOSTNAME_TRAILING_DOT));
|
|
assert_se(!hostname_is_valid("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx", VALID_HOSTNAME_TRAILING_DOT));
|
|
}
|
|
|
|
static void test_hostname_cleanup(void) {
|
|
char *s;
|
|
|
|
s = strdupa("foobar");
|
|
assert_se(streq(hostname_cleanup(s), "foobar"));
|
|
s = strdupa("foobar.com");
|
|
assert_se(streq(hostname_cleanup(s), "foobar.com"));
|
|
s = strdupa("foobar.com.");
|
|
assert_se(streq(hostname_cleanup(s), "foobar.com"));
|
|
s = strdupa("foo-bar.-com-.");
|
|
assert_se(streq(hostname_cleanup(s), "foo-bar.com"));
|
|
s = strdupa("foo-bar-.-com-.");
|
|
assert_se(streq(hostname_cleanup(s), "foo-bar--com"));
|
|
s = strdupa("--foo-bar.-com");
|
|
assert_se(streq(hostname_cleanup(s), "foo-bar.com"));
|
|
s = strdupa("fooBAR");
|
|
assert_se(streq(hostname_cleanup(s), "fooBAR"));
|
|
s = strdupa("fooBAR.com");
|
|
assert_se(streq(hostname_cleanup(s), "fooBAR.com"));
|
|
s = strdupa("fooBAR.");
|
|
assert_se(streq(hostname_cleanup(s), "fooBAR"));
|
|
s = strdupa("fooBAR.com.");
|
|
assert_se(streq(hostname_cleanup(s), "fooBAR.com"));
|
|
s = strdupa("fööbar");
|
|
assert_se(streq(hostname_cleanup(s), "fbar"));
|
|
s = strdupa("");
|
|
assert_se(isempty(hostname_cleanup(s)));
|
|
s = strdupa(".");
|
|
assert_se(isempty(hostname_cleanup(s)));
|
|
s = strdupa("..");
|
|
assert_se(isempty(hostname_cleanup(s)));
|
|
s = strdupa("foobar.");
|
|
assert_se(streq(hostname_cleanup(s), "foobar"));
|
|
s = strdupa(".foobar");
|
|
assert_se(streq(hostname_cleanup(s), "foobar"));
|
|
s = strdupa("foo..bar");
|
|
assert_se(streq(hostname_cleanup(s), "foo.bar"));
|
|
s = strdupa("foo.bar..");
|
|
assert_se(streq(hostname_cleanup(s), "foo.bar"));
|
|
s = strdupa("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx");
|
|
assert_se(streq(hostname_cleanup(s), "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"));
|
|
s = strdupa("xxxx........xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx");
|
|
assert_se(streq(hostname_cleanup(s), "xxxx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"));
|
|
}
|
|
|
|
static void test_read_etc_hostname(void) {
|
|
char path[] = "/tmp/hostname.XXXXXX";
|
|
char *hostname;
|
|
int fd;
|
|
|
|
fd = mkostemp_safe(path);
|
|
assert(fd > 0);
|
|
close(fd);
|
|
|
|
/* simple hostname */
|
|
assert_se(write_string_file(path, "foo", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_etc_hostname(path, &hostname) == 0);
|
|
assert_se(streq(hostname, "foo"));
|
|
hostname = mfree(hostname);
|
|
|
|
/* with comment */
|
|
assert_se(write_string_file(path, "# comment\nfoo", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_etc_hostname(path, &hostname) == 0);
|
|
assert_se(hostname);
|
|
assert_se(streq(hostname, "foo"));
|
|
hostname = mfree(hostname);
|
|
|
|
/* with comment and extra whitespace */
|
|
assert_se(write_string_file(path, "# comment\n\n foo ", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_etc_hostname(path, &hostname) == 0);
|
|
assert_se(hostname);
|
|
assert_se(streq(hostname, "foo"));
|
|
hostname = mfree(hostname);
|
|
|
|
/* cleans up name */
|
|
assert_se(write_string_file(path, "!foo/bar.com", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_etc_hostname(path, &hostname) == 0);
|
|
assert_se(hostname);
|
|
assert_se(streq(hostname, "foobar.com"));
|
|
hostname = mfree(hostname);
|
|
|
|
/* no value set */
|
|
hostname = (char*) 0x1234;
|
|
assert_se(write_string_file(path, "# nothing here\n", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_etc_hostname(path, &hostname) == -ENOENT);
|
|
assert_se(hostname == (char*) 0x1234); /* does not touch argument on error */
|
|
|
|
/* nonexisting file */
|
|
assert_se(read_etc_hostname("/non/existing", &hostname) == -ENOENT);
|
|
assert_se(hostname == (char*) 0x1234); /* does not touch argument on error */
|
|
|
|
unlink(path);
|
|
}
|
|
|
|
static void test_hostname_malloc(void) {
|
|
_cleanup_free_ char *h = NULL, *l = NULL;
|
|
|
|
assert_se(h = gethostname_malloc());
|
|
log_info("hostname_malloc: \"%s\"", h);
|
|
|
|
assert_se(l = gethostname_short_malloc());
|
|
log_info("hostname_short_malloc: \"%s\"", l);
|
|
}
|
|
|
|
static void test_fallback_hostname(void) {
|
|
if (!hostname_is_valid(FALLBACK_HOSTNAME, 0)) {
|
|
log_error("Configured fallback hostname \"%s\" is not valid.", FALLBACK_HOSTNAME);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
}
|
|
|
|
int main(int argc, char *argv[]) {
|
|
log_parse_environment();
|
|
log_open();
|
|
|
|
test_hostname_is_valid();
|
|
test_hostname_cleanup();
|
|
test_read_etc_hostname();
|
|
test_hostname_malloc();
|
|
|
|
test_fallback_hostname();
|
|
|
|
return 0;
|
|
}
|