3ca1fab70a
They are not really boolean, because we have both ipv4 and ipv6, but
for each protocol we have either unset, no, and yes.
From https://github.com/systemd/systemd/issues/13316#issuecomment-582906817:
LinkLocalAddressing must be a boolean option, at least for ipv4:
- LinkLocalAddressing=no => no LL at all.
- LinkLocalAddressing=yes + Static Address => invalid configuration, warn and
interpret as LinkLocalAddressing=no, no LL at all.
(we check that during parsing and reject)
- LinkLocalAddressing=yes + DHCP => LL process should be subordinated to the
DHCP one, an LL address must be acquired at start or after a short N
unsuccessful DHCP attemps, and must not stop DHCP to keeping trying. When a
DHCP address is acquired, drop the LL address. If the DHCP address is lost,
re-adquire a new LL address.
(next patch will move in this direction)
- LinkLocalAddressing=fallback has no reason to exist, because LL address must
always be allocated as a fallback option when using DHCP. Having both DHCP
and LL address at the same time is an RFC violation, so
LinkLocalAdressing=yes correctly implemented is already the "fallback"
behavior. The fallback option must be deprecated and if present in older
configs must be interpreted as LinkLocalAddressing=yes.
(removed)
- And for IPv6, the LinkLocalAddress option has any sense at all? IPv6-LL
address aren't required to be always set for every IPv6 enabled interface (in
this case, coexisting with static or dynamic address if any)? Shouldn't be
always =yes?
(good question)
This effectively reverts 29e81083bd. There is no
special "fallback" mode now, so the check doesn't make sense anymore.
81 lines
3.3 KiB
C
81 lines
3.3 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
#pragma once
|
|
|
|
#include "sd-dhcp-lease.h"
|
|
#include "sd-netlink.h"
|
|
|
|
#include "conf-parser.h"
|
|
#include "hashmap.h"
|
|
#include "log.h"
|
|
#include "macro.h"
|
|
#include "string-util.h"
|
|
|
|
typedef enum AddressFamily {
|
|
/* This is a bitmask, though it usually doesn't feel that way! */
|
|
ADDRESS_FAMILY_NO = 0,
|
|
ADDRESS_FAMILY_IPV4 = 1 << 0,
|
|
ADDRESS_FAMILY_IPV6 = 1 << 1,
|
|
ADDRESS_FAMILY_YES = ADDRESS_FAMILY_IPV4 | ADDRESS_FAMILY_IPV6,
|
|
_ADDRESS_FAMILY_MAX,
|
|
_ADDRESS_FAMILY_INVALID = -1,
|
|
} AddressFamily;
|
|
|
|
typedef struct NetworkConfigSection {
|
|
unsigned line;
|
|
bool invalid;
|
|
char filename[];
|
|
} NetworkConfigSection;
|
|
|
|
CONFIG_PARSER_PROTOTYPE(config_parse_link_local_address_family);
|
|
CONFIG_PARSER_PROTOTYPE(config_parse_address_family_with_kernel);
|
|
|
|
const char *address_family_to_string(AddressFamily b) _const_;
|
|
AddressFamily address_family_from_string(const char *s) _pure_;
|
|
|
|
AddressFamily link_local_address_family_from_string(const char *s) _pure_;
|
|
|
|
const char *routing_policy_rule_address_family_to_string(AddressFamily b) _const_;
|
|
AddressFamily routing_policy_rule_address_family_from_string(const char *s) _pure_;
|
|
|
|
const char *duplicate_address_detection_address_family_to_string(AddressFamily b) _const_;
|
|
AddressFamily duplicate_address_detection_address_family_from_string(const char *s) _pure_;
|
|
|
|
const char *dhcp_lease_server_type_to_string(sd_dhcp_lease_server_type t) _const_;
|
|
sd_dhcp_lease_server_type dhcp_lease_server_type_from_string(const char *s) _pure_;
|
|
|
|
int kernel_route_expiration_supported(void);
|
|
|
|
int network_config_section_new(const char *filename, unsigned line, NetworkConfigSection **s);
|
|
void network_config_section_free(NetworkConfigSection *network);
|
|
DEFINE_TRIVIAL_CLEANUP_FUNC(NetworkConfigSection*, network_config_section_free);
|
|
extern const struct hash_ops network_config_hash_ops;
|
|
unsigned hashmap_find_free_section_line(Hashmap *hashmap);
|
|
|
|
static inline bool section_is_invalid(NetworkConfigSection *section) {
|
|
/* If this returns false, then it does _not_ mean the section is valid. */
|
|
|
|
if (!section)
|
|
return false;
|
|
|
|
return section->invalid;
|
|
}
|
|
|
|
#define DEFINE_NETWORK_SECTION_FUNCTIONS(type, free_func) \
|
|
static inline void free_func##_or_set_invalid(type *p) { \
|
|
assert(p); \
|
|
\
|
|
if (p->section) \
|
|
p->section->invalid = true; \
|
|
else \
|
|
free_func(p); \
|
|
} \
|
|
DEFINE_TRIVIAL_CLEANUP_FUNC(type*, free_func); \
|
|
DEFINE_TRIVIAL_CLEANUP_FUNC(type*, free_func##_or_set_invalid);
|
|
|
|
static inline int log_message_warning_errno(sd_netlink_message *m, int err, const char *msg) {
|
|
const char *err_msg = NULL;
|
|
|
|
(void) sd_netlink_message_read_string(m, NLMSGERR_ATTR_MSG, &err_msg);
|
|
return log_warning_errno(err, "%s: %s%s%m", msg, strempty(err_msg), err_msg ? " " : "");
|
|
}
|