53aa0d02ad
In various circumstances, overriding the kernel commandline can be inconvenient. People have different bootloaders, and e.g. the grub config can be pretty scary. grubby helps, but it isn't always available. This option adds an alternative mechanism that can quite convenient on EFI systems. cmdline settings have higher priority, because they can be (usually) changed on the bootloader prompt. $SYSTEMD_EFI_OPTIONS can be used to override, same as $SYSTEMD_PROC_CMDLINE.
264 lines
12 KiB
C
264 lines
12 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
|
|
#include "alloc-util.h"
|
|
#include "env-util.h"
|
|
#include "log.h"
|
|
#include "macro.h"
|
|
#include "proc-cmdline.h"
|
|
#include "special.h"
|
|
#include "string-util.h"
|
|
#include "tests.h"
|
|
#include "util.h"
|
|
|
|
static int obj;
|
|
|
|
static int parse_item(const char *key, const char *value, void *data) {
|
|
assert_se(key);
|
|
assert_se(data == &obj);
|
|
|
|
log_info("kernel cmdline option <%s> = <%s>", key, strna(value));
|
|
return 0;
|
|
}
|
|
|
|
static void test_proc_cmdline_parse(void) {
|
|
log_info("/* %s */", __func__);
|
|
|
|
assert_se(proc_cmdline_parse(parse_item, &obj, PROC_CMDLINE_STRIP_RD_PREFIX) >= 0);
|
|
}
|
|
|
|
static void test_proc_cmdline_override(void) {
|
|
log_info("/* %s */", __func__);
|
|
|
|
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=foo_bar=quux wuff-piep=tuet zumm some_arg_with_space='foo bar' and_one_more=\"zzz aaa\"") == 0);
|
|
assert_se(putenv((char*) "SYSTEMD_EFI_OPTIONS=differnt") == 0);
|
|
|
|
/* First test if the overrides for /proc/cmdline still work */
|
|
_cleanup_free_ char *line = NULL, *value = NULL;
|
|
assert_se(proc_cmdline(&line) >= 0);
|
|
|
|
/* Test if parsing makes uses of the override */
|
|
assert_se(streq(line, "foo_bar=quux wuff-piep=tuet zumm some_arg_with_space='foo bar' and_one_more=\"zzz aaa\""));
|
|
assert_se(proc_cmdline_get_key("foo_bar", 0, &value) > 0 && streq_ptr(value, "quux"));
|
|
value = mfree(value);
|
|
|
|
assert_se(proc_cmdline_get_key("some_arg_with_space", 0, &value) > 0 && streq_ptr(value, "foo bar"));
|
|
value = mfree(value);
|
|
|
|
assert_se(proc_cmdline_get_key("and_one_more", 0, &value) > 0 && streq_ptr(value, "zzz aaa"));
|
|
value = mfree(value);
|
|
|
|
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=") == 0);
|
|
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=foo_bar=quux wuff-piep=tuet zumm some_arg_with_space='foo bar' and_one_more=\"zzz aaa\"") == 0);
|
|
|
|
assert_se(streq(line, "foo_bar=quux wuff-piep=tuet zumm some_arg_with_space='foo bar' and_one_more=\"zzz aaa\""));
|
|
assert_se(proc_cmdline_get_key("foo_bar", 0, &value) > 0 && streq_ptr(value, "quux"));
|
|
value = mfree(value);
|
|
|
|
assert_se(proc_cmdline_get_key("some_arg_with_space", 0, &value) > 0 && streq_ptr(value, "foo bar"));
|
|
value = mfree(value);
|
|
|
|
assert_se(proc_cmdline_get_key("and_one_more", 0, &value) > 0 && streq_ptr(value, "zzz aaa"));
|
|
value = mfree(value);
|
|
}
|
|
|
|
static int parse_item_given(const char *key, const char *value, void *data) {
|
|
assert_se(key);
|
|
assert_se(data);
|
|
|
|
bool *strip = data;
|
|
|
|
log_info("%s: option <%s> = <%s>", __func__, key, strna(value));
|
|
if (proc_cmdline_key_streq(key, "foo_bar"))
|
|
assert_se(streq(value, "quux"));
|
|
else if (proc_cmdline_key_streq(key, "wuff-piep"))
|
|
assert_se(streq(value, "tuet "));
|
|
else if (proc_cmdline_key_streq(key, "space"))
|
|
assert_se(streq(value, "x y z"));
|
|
else if (proc_cmdline_key_streq(key, "miepf"))
|
|
assert_se(streq(value, "uuu"));
|
|
else if (in_initrd() && *strip && proc_cmdline_key_streq(key, "zumm"))
|
|
assert_se(!value);
|
|
else if (in_initrd() && !*strip && proc_cmdline_key_streq(key, "rd.zumm"))
|
|
assert_se(!value);
|
|
else
|
|
assert_not_reached("Bad key!");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void test_proc_cmdline_given(bool flip_initrd) {
|
|
log_info("/* %s (flip: %s) */", __func__, yes_no(flip_initrd));
|
|
|
|
if (flip_initrd)
|
|
in_initrd_force(!in_initrd());
|
|
|
|
bool t = true, f = false;
|
|
assert_se(proc_cmdline_parse_given("foo_bar=quux wuff-piep=\"tuet \" rd.zumm space='x y z' miepf=\"uuu\"",
|
|
parse_item_given, &t, PROC_CMDLINE_STRIP_RD_PREFIX) >= 0);
|
|
|
|
assert_se(proc_cmdline_parse_given("foo_bar=quux wuff-piep=\"tuet \" rd.zumm space='x y z' miepf=\"uuu\"",
|
|
parse_item_given, &f, 0) >= 0);
|
|
|
|
if (flip_initrd)
|
|
in_initrd_force(!in_initrd());
|
|
}
|
|
|
|
static void test_proc_cmdline_get_key(void) {
|
|
_cleanup_free_ char *value = NULL;
|
|
|
|
log_info("/* %s */", __func__);
|
|
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=foo_bar=quux wuff-piep=tuet zumm spaaace='ö ü ß' ticks=\"''\"\n\nkkk=uuu\n\n\n") == 0);
|
|
|
|
assert_se(proc_cmdline_get_key("", 0, &value) == -EINVAL);
|
|
assert_se(proc_cmdline_get_key("abc", 0, NULL) == 0);
|
|
assert_se(proc_cmdline_get_key("abc", 0, &value) == 0 && value == NULL);
|
|
assert_se(proc_cmdline_get_key("abc", PROC_CMDLINE_VALUE_OPTIONAL, &value) == 0 && value == NULL);
|
|
|
|
assert_se(proc_cmdline_get_key("foo_bar", 0, &value) > 0 && streq_ptr(value, "quux"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("foo_bar", PROC_CMDLINE_VALUE_OPTIONAL, &value) > 0 && streq_ptr(value, "quux"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("foo-bar", 0, &value) > 0 && streq_ptr(value, "quux"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("foo-bar", PROC_CMDLINE_VALUE_OPTIONAL, &value) > 0 && streq_ptr(value, "quux"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("foo-bar", 0, NULL) == 0);
|
|
assert_se(proc_cmdline_get_key("foo-bar", PROC_CMDLINE_VALUE_OPTIONAL, NULL) == -EINVAL);
|
|
|
|
assert_se(proc_cmdline_get_key("wuff-piep", 0, &value) > 0 && streq_ptr(value, "tuet"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("wuff-piep", PROC_CMDLINE_VALUE_OPTIONAL, &value) > 0 && streq_ptr(value, "tuet"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("wuff_piep", 0, &value) > 0 && streq_ptr(value, "tuet"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("wuff_piep", PROC_CMDLINE_VALUE_OPTIONAL, &value) > 0 && streq_ptr(value, "tuet"));
|
|
value = mfree(value);
|
|
assert_se(proc_cmdline_get_key("wuff_piep", 0, NULL) == 0);
|
|
assert_se(proc_cmdline_get_key("wuff_piep", PROC_CMDLINE_VALUE_OPTIONAL, NULL) == -EINVAL);
|
|
|
|
assert_se(proc_cmdline_get_key("zumm", 0, &value) == 0 && value == NULL);
|
|
assert_se(proc_cmdline_get_key("zumm", PROC_CMDLINE_VALUE_OPTIONAL, &value) > 0 && value == NULL);
|
|
assert_se(proc_cmdline_get_key("zumm", 0, NULL) > 0);
|
|
|
|
assert_se(proc_cmdline_get_key("spaaace", 0, &value) > 0 && streq_ptr(value, "ö ü ß"));
|
|
value = mfree(value);
|
|
|
|
assert_se(proc_cmdline_get_key("ticks", 0, &value) > 0 && streq_ptr(value, "''"));
|
|
value = mfree(value);
|
|
|
|
assert_se(proc_cmdline_get_key("kkk", 0, &value) > 0 && streq_ptr(value, "uuu"));
|
|
}
|
|
|
|
static void test_proc_cmdline_get_bool(void) {
|
|
bool value = false;
|
|
|
|
log_info("/* %s */", __func__);
|
|
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=foo_bar bar-waldo=1 x_y-z=0 quux=miep\nda=yes\nthe=1") == 0);
|
|
assert_se(putenv((char*) "SYSTEMD_EFI_OPTIONS=") == 0);
|
|
|
|
assert_se(proc_cmdline_get_bool("", &value) == -EINVAL);
|
|
assert_se(proc_cmdline_get_bool("abc", &value) == 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("foo_bar", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("foo-bar", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("bar-waldo", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("bar_waldo", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("x_y-z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("x-y-z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("x-y_z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("x_y_z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("quux", &value) == -EINVAL && value == false);
|
|
assert_se(proc_cmdline_get_bool("da", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("the", &value) > 0 && value == true);
|
|
|
|
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=") == 0);
|
|
assert_se(putenv((char*) "SYSTEMD_EFI_OPTIONS=foo_bar bar-waldo=1 x_y-z=0 quux=miep\nda=yes\nthe=1") == 0);
|
|
|
|
assert_se(proc_cmdline_get_bool("", &value) == -EINVAL);
|
|
assert_se(proc_cmdline_get_bool("abc", &value) == 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("foo_bar", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("foo-bar", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("bar-waldo", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("bar_waldo", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("x_y-z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("x-y-z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("x-y_z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("x_y_z", &value) > 0 && value == false);
|
|
assert_se(proc_cmdline_get_bool("quux", &value) == -EINVAL && value == false);
|
|
assert_se(proc_cmdline_get_bool("da", &value) > 0 && value == true);
|
|
assert_se(proc_cmdline_get_bool("the", &value) > 0 && value == true);
|
|
}
|
|
|
|
static void test_proc_cmdline_get_key_many(void) {
|
|
_cleanup_free_ char *value1 = NULL, *value2 = NULL, *value3 = NULL, *value4 = NULL, *value5 = NULL, *value6 = NULL, *value7 = NULL;
|
|
|
|
log_info("/* %s */", __func__);
|
|
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=foo_bar=quux wuff-piep=tuet zumm SPACE='one two' doubleticks=\" aaa aaa \"\n\nzummm='\n'\n") == 0);
|
|
|
|
assert_se(proc_cmdline_get_key_many(0,
|
|
"wuff-piep", &value3,
|
|
"foo_bar", &value1,
|
|
"idontexist", &value2,
|
|
"zumm", &value4,
|
|
"SPACE", &value5,
|
|
"doubleticks", &value6,
|
|
"zummm", &value7) == 5);
|
|
|
|
assert_se(streq_ptr(value1, "quux"));
|
|
assert_se(!value2);
|
|
assert_se(streq_ptr(value3, "tuet"));
|
|
assert_se(!value4);
|
|
assert_se(streq_ptr(value5, "one two"));
|
|
assert_se(streq_ptr(value6, " aaa aaa "));
|
|
assert_se(streq_ptr(value7, "\n"));
|
|
}
|
|
|
|
static void test_proc_cmdline_key_streq(void) {
|
|
log_info("/* %s */", __func__);
|
|
|
|
assert_se(proc_cmdline_key_streq("", ""));
|
|
assert_se(proc_cmdline_key_streq("a", "a"));
|
|
assert_se(!proc_cmdline_key_streq("", "a"));
|
|
assert_se(!proc_cmdline_key_streq("a", ""));
|
|
assert_se(proc_cmdline_key_streq("a", "a"));
|
|
assert_se(!proc_cmdline_key_streq("a", "b"));
|
|
assert_se(proc_cmdline_key_streq("x-y-z", "x-y-z"));
|
|
assert_se(proc_cmdline_key_streq("x-y-z", "x_y_z"));
|
|
assert_se(proc_cmdline_key_streq("x-y-z", "x-y_z"));
|
|
assert_se(proc_cmdline_key_streq("x-y-z", "x_y-z"));
|
|
assert_se(proc_cmdline_key_streq("x_y-z", "x-y_z"));
|
|
assert_se(!proc_cmdline_key_streq("x_y-z", "x-z_z"));
|
|
}
|
|
|
|
static void test_proc_cmdline_key_startswith(void) {
|
|
log_info("/* %s */", __func__);
|
|
|
|
assert_se(proc_cmdline_key_startswith("", ""));
|
|
assert_se(proc_cmdline_key_startswith("x", ""));
|
|
assert_se(!proc_cmdline_key_startswith("", "x"));
|
|
assert_se(proc_cmdline_key_startswith("x", "x"));
|
|
assert_se(!proc_cmdline_key_startswith("x", "y"));
|
|
assert_se(!proc_cmdline_key_startswith("foo-bar", "quux"));
|
|
assert_se(proc_cmdline_key_startswith("foo-bar", "foo"));
|
|
assert_se(proc_cmdline_key_startswith("foo-bar", "foo-bar"));
|
|
assert_se(proc_cmdline_key_startswith("foo-bar", "foo_bar"));
|
|
assert_se(proc_cmdline_key_startswith("foo-bar", "foo_"));
|
|
assert_se(!proc_cmdline_key_startswith("foo-bar", "foo_xx"));
|
|
}
|
|
|
|
int main(void) {
|
|
test_setup_logging(LOG_INFO);
|
|
|
|
test_proc_cmdline_parse();
|
|
test_proc_cmdline_override();
|
|
test_proc_cmdline_given(false);
|
|
/* Repeat the same thing, but now flip our ininitrdness */
|
|
test_proc_cmdline_given(true);
|
|
test_proc_cmdline_key_streq();
|
|
test_proc_cmdline_key_startswith();
|
|
test_proc_cmdline_get_key();
|
|
test_proc_cmdline_get_bool();
|
|
test_proc_cmdline_get_key_many();
|
|
|
|
return 0;
|
|
}
|