picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Systemd/src/libsystemd-network
History
Thomas Haller a507737e5c dhcp: fix assertion starting DHCP client without MAC address (#10054) 
An assertion in dhcp_network_bind_raw_socket() is triggered when
starting an sd_dhcp_client without setting a MAC address first.

  - sd_dhcp_client_start()
    - client_start()
      - client_start_delayed()
        - dhcp_network_bind_raw_socket()

In that case, the arp-type and MAC address is still unset. Note that
dhcp_network_bind_raw_socket() already checks for a valid arp-type
and MAC address below, so we should just gracefully return -EINVAL.

Maybe sd_dhcp_client_start() should fail earlier when starting without
MAC address. But the failure here will be correctly propagated and
the start aborted.

Fixes: 76253e73f9
 		2018-09-11 09:45:47 +09:00
..
arp-util.c tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
arp-util.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
dhcp-identifier.c Merge pull request #9406 from yuwata/rfe-9228 2018-08-23 11:11:13 +02:00
dhcp-identifier.h sd-dhcp: use MAC address when DUIDType=link-layer-time or link-layer but DUIDRawData= is not set 2018-08-08 10:15:00 +09:00
dhcp-internal.h tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
dhcp-lease-internal.h tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
dhcp-network.c dhcp: fix assertion starting DHCP client without MAC address (#10054) 2018-09-11 09:45:47 +09:00
dhcp-option.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
dhcp-packet.c tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
dhcp-protocol.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
dhcp-server-internal.h tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
dhcp6-internal.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
dhcp6-lease-internal.h tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
dhcp6-network.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
dhcp6-option.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
dhcp6-protocol.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
icmp6-util.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
icmp6-util.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
lldp-internal.h tree-wide: drop double newline 2018-06-29 11:02:17 +09:00
lldp-neighbor.c tree-wide: Convert compare_func's to use CMP() macro wherever possible. 2018-08-06 19:26:35 -07:00
lldp-neighbor.h tree-wide: remove Lennart's copyright lines 2018-06-14 10:20:20 +02:00
lldp-network.c tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
lldp-network.h tree-wide: drop double newline 2018-06-29 11:02:17 +09:00
meson.build Drop my copyright headers 2018-06-14 13:03:20 +02:00
ndisc-internal.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
ndisc-router.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
ndisc-router.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
network-internal.c network: replace udev_device by sd_device 2018-08-23 04:57:39 +09:00
network-internal.h network: replace udev_device by sd_device 2018-08-23 04:57:39 +09:00
radv-internal.h tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
sd-dhcp-client.c sd-dhcp: drop meaningless checking 2018-09-04 13:07:37 -07:00
sd-dhcp-lease.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
sd-dhcp-server.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
sd-dhcp6-client.c sd-dhcp6: set requested time for DUID-LLT 2018-09-04 13:07:37 -07:00
sd-dhcp6-lease.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
sd-ipv4acd.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
sd-ipv4ll.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
sd-lldp.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
sd-ndisc.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
sd-radv.c tree-wide: use DEFINE_TRIVIAL_REF_UNREF_FUNC() macro or friends where applicable 2018-08-27 14:01:46 +09:00
test-acd.c tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
test-dhcp-client.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
test-dhcp-option.c Merge pull request #2589 from keszybz/resolve-tool-2 2016-02-13 11:15:41 +01:00
test-dhcp-server.c tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
test-dhcp6-client.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
test-ipv4ll-manual.c tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
test-ipv4ll.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
test-lldp.c tree-wide: drop copyright headers from frequent contributors 2018-06-20 11:58:53 +02:00
test-ndisc-ra.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
test-ndisc-rs.c tree-wide: use proper unicode © instead of (C) where we can 2018-06-14 10:20:20 +02:00
test-sd-dhcp-lease.c network: Implement DHCP Option 119 (Domain Search List) (#5932) 2017-05-13 10:19:32 -04:00