905ca72a8f
In udev man page, "PROGRAM" key is part of the keys which are used for matching purposes so it should only be used with the compare operator "==". Actually it doesn't really make sense to assign it a value. udev code allows both "=" and "==" for PROGRAM and both are handled the same way but for consistencies it's better to have only the compare operator allowed by the rule syntax checker. No rules shipped by systemd use PROGRAM key so nothing need to be changed in our rule files.
69 lines
2.3 KiB
Python
Executable file
69 lines
2.3 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# SPDX-License-Identifier: LGPL-2.1+
|
|
#
|
|
# Simple udev rules syntax checker
|
|
#
|
|
# (C) 2010 Canonical Ltd.
|
|
# Author: Martin Pitt <martin.pitt@ubuntu.com>
|
|
#
|
|
# systemd is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU Lesser General Public License as published by
|
|
# the Free Software Foundation; either version 2.1 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# systemd is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public License
|
|
# along with systemd; If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
import re
|
|
import sys
|
|
import os
|
|
from glob import glob
|
|
|
|
rules_files = sys.argv[1:]
|
|
if not rules_files:
|
|
sys.exit('Specify files to test as arguments')
|
|
|
|
no_args_tests = re.compile(r'(ACTION|DEVPATH|KERNELS?|NAME|SYMLINK|SUBSYSTEMS?|DRIVERS?|TAG|PROGRAM|RESULT|TEST)\s*(?:=|!)=\s*"([^"]*)"$')
|
|
args_tests = re.compile(r'(ATTRS?|ENV|TEST){([a-zA-Z0-9/_.*%-]+)}\s*(?:=|!)=\s*"([^"]*)"$')
|
|
no_args_assign = re.compile(r'(NAME|SYMLINK|OWNER|GROUP|MODE|TAG|RUN|LABEL|GOTO|OPTIONS|IMPORT)\s*(?:\+=|:=|=)\s*"([^"]*)"$')
|
|
args_assign = re.compile(r'(ATTR|ENV|IMPORT|RUN){([a-zA-Z0-9/_.*%-]+)}\s*(=|\+=)\s*"([^"]*)"$')
|
|
|
|
result = 0
|
|
buffer = ''
|
|
for path in rules_files:
|
|
print('# looking at {}'.format(path))
|
|
lineno = 0
|
|
for line in open(path):
|
|
lineno += 1
|
|
|
|
# handle line continuation
|
|
if line.endswith('\\\n'):
|
|
buffer += line[:-2]
|
|
continue
|
|
else:
|
|
line = buffer + line
|
|
buffer = ''
|
|
|
|
# filter out comments and empty lines
|
|
line = line.strip()
|
|
if not line or line.startswith('#'):
|
|
continue
|
|
|
|
for clause in line.split(','):
|
|
clause = clause.strip()
|
|
if not (no_args_tests.match(clause) or args_tests.match(clause) or
|
|
no_args_assign.match(clause) or args_assign.match(clause)):
|
|
|
|
print('Invalid line {}:{}: {}'.format(path, lineno, line))
|
|
print(' clause:', clause)
|
|
print()
|
|
result = 1
|
|
break
|
|
|
|
sys.exit(result)
|