d200735e13
The way the various properties[] arrays are initialized is inefficient: - only the .data members change at runtime, yet the whole arrays of properties with all the fields are constructed on the stack one by one by the code. - there's duplication, eg. the properties of "org.freedesktop.systemd1.Unit" are repeated in several unit types. Fix it by moving the information about properties into static const sections. Instead of storing the .data directly in the property, store a constant offset from a run-time base. The small arrays of struct BusBoundProperties bind together the constant information with the right runtime information (the base pointer). On my system the code shrinks by 60 KB, data increases by 10 KB.
94 lines
3.4 KiB
C
94 lines
3.4 KiB
C
/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
|
|
|
|
/***
|
|
This file is part of systemd.
|
|
|
|
Copyright 2010 Lennart Poettering
|
|
|
|
systemd is free software; you can redistribute it and/or modify it
|
|
under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
systemd is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with systemd; If not, see <http://www.gnu.org/licenses/>.
|
|
***/
|
|
|
|
#include "dbus-unit.h"
|
|
#include "dbus-snapshot.h"
|
|
#include "dbus-common.h"
|
|
|
|
#define BUS_SNAPSHOT_INTERFACE \
|
|
" <interface name=\"org.freedesktop.systemd1.Snapshot\">\n" \
|
|
" <method name=\"Remove\"/>\n" \
|
|
" <property name=\"Cleanup\" type=\"b\" access=\"read\"/>\n" \
|
|
" </interface>\n"
|
|
|
|
#define INTROSPECTION \
|
|
DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE \
|
|
"<node>\n" \
|
|
BUS_UNIT_INTERFACE \
|
|
BUS_SNAPSHOT_INTERFACE \
|
|
BUS_PROPERTIES_INTERFACE \
|
|
BUS_PEER_INTERFACE \
|
|
BUS_INTROSPECTABLE_INTERFACE \
|
|
"</node>\n"
|
|
|
|
#define INTERFACES_LIST \
|
|
BUS_UNIT_INTERFACES_LIST \
|
|
"org.freedesktop.systemd1.Snapshot\0"
|
|
|
|
const char bus_snapshot_interface[] _introspect_("Snapshot") = BUS_SNAPSHOT_INTERFACE;
|
|
|
|
static const BusProperty bus_snapshot_properties[] = {
|
|
{ "Cleanup", bus_property_append_bool, "b", offsetof(Snapshot, cleanup) },
|
|
{ NULL, }
|
|
};
|
|
|
|
DBusHandlerResult bus_snapshot_message_handler(Unit *u, DBusConnection *c, DBusMessage *message) {
|
|
Snapshot *s = SNAPSHOT(u);
|
|
|
|
DBusMessage *reply = NULL;
|
|
DBusError error;
|
|
|
|
dbus_error_init(&error);
|
|
|
|
if (dbus_message_is_method_call(message, "org.freedesktop.systemd1.Snapshot", "Remove")) {
|
|
|
|
snapshot_remove(SNAPSHOT(u));
|
|
|
|
if (!(reply = dbus_message_new_method_return(message)))
|
|
goto oom;
|
|
|
|
} else {
|
|
const BusBoundProperties bps[] = {
|
|
{ "org.freedesktop.systemd1.Unit", bus_unit_properties, u },
|
|
{ "org.freedesktop.systemd1.Snapshot", bus_snapshot_properties, s },
|
|
{ NULL, }
|
|
};
|
|
return bus_default_message_handler(c, message, INTROSPECTION, INTERFACES_LIST, bps);
|
|
}
|
|
|
|
if (reply) {
|
|
if (!dbus_connection_send(c, reply, NULL))
|
|
goto oom;
|
|
|
|
dbus_message_unref(reply);
|
|
}
|
|
|
|
return DBUS_HANDLER_RESULT_HANDLED;
|
|
|
|
oom:
|
|
if (reply)
|
|
dbus_message_unref(reply);
|
|
|
|
dbus_error_free(&error);
|
|
|
|
return DBUS_HANDLER_RESULT_NEED_MEMORY;
|
|
}
|