fc9de36a3b
systemd-analyze verify command now results in segmentation fault if two consecutive non-existent unit file names are given: # ./build/systemd-analyze a.service b.service ...<snip irrelevant part>... Unit a.service not found. Unit b.service not found. Segmentation fault (core dumped) The cause of this is a wrong handling of return value of manager_load_startable_unit_or_warn() in verify_units() in failure case. It looks that the current logic wants to assign the first error status throughout verify_units() into variable r and count up variable count only when a given unit file exists. However, due to the wrong handling of the return value of manager_load_startable_unit_or_warn() in verify_units(), the variable count is unexpectedly incremented even when there is no such unit file because the variable r already contains non-zero value in the 2nd failure, set by the 1st failure, and then the condition k < 0 && r == 0 evaluates to false. This commit fixes the wrong handling of return value of manager_load_startable_unit_or_warn() in verify_units().
291 lines
8.4 KiB
C
291 lines
8.4 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "alloc-util.h"
|
|
#include "all-units.h"
|
|
#include "analyze-verify.h"
|
|
#include "bus-error.h"
|
|
#include "bus-util.h"
|
|
#include "log.h"
|
|
#include "manager.h"
|
|
#include "pager.h"
|
|
#include "path-util.h"
|
|
#include "strv.h"
|
|
#include "unit-name.h"
|
|
|
|
static int prepare_filename(const char *filename, char **ret) {
|
|
int r;
|
|
const char *name;
|
|
_cleanup_free_ char *abspath = NULL;
|
|
_cleanup_free_ char *dir = NULL;
|
|
_cleanup_free_ char *with_instance = NULL;
|
|
char *c;
|
|
|
|
assert(filename);
|
|
assert(ret);
|
|
|
|
r = path_make_absolute_cwd(filename, &abspath);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
name = basename(abspath);
|
|
if (!unit_name_is_valid(name, UNIT_NAME_ANY))
|
|
return -EINVAL;
|
|
|
|
if (unit_name_is_valid(name, UNIT_NAME_TEMPLATE)) {
|
|
r = unit_name_replace_instance(name, "i", &with_instance);
|
|
if (r < 0)
|
|
return r;
|
|
}
|
|
|
|
dir = dirname_malloc(abspath);
|
|
if (!dir)
|
|
return -ENOMEM;
|
|
|
|
c = path_join(dir, with_instance ?: name);
|
|
if (!c)
|
|
return -ENOMEM;
|
|
|
|
*ret = c;
|
|
return 0;
|
|
}
|
|
|
|
static int generate_path(char **var, char **filenames) {
|
|
const char *old;
|
|
char **filename;
|
|
|
|
_cleanup_strv_free_ char **ans = NULL;
|
|
int r;
|
|
|
|
STRV_FOREACH(filename, filenames) {
|
|
char *t;
|
|
|
|
t = dirname_malloc(*filename);
|
|
if (!t)
|
|
return -ENOMEM;
|
|
|
|
r = strv_consume(&ans, t);
|
|
if (r < 0)
|
|
return r;
|
|
}
|
|
|
|
assert_se(strv_uniq(ans));
|
|
|
|
/* First, prepend our directories. Second, if some path was specified, use that, and
|
|
* otherwise use the defaults. Any duplicates will be filtered out in path-lookup.c.
|
|
* Treat explicit empty path to mean that nothing should be appended.
|
|
*/
|
|
old = getenv("SYSTEMD_UNIT_PATH");
|
|
if (!streq_ptr(old, "")) {
|
|
if (!old)
|
|
old = ":";
|
|
|
|
r = strv_extend(&ans, old);
|
|
if (r < 0)
|
|
return r;
|
|
}
|
|
|
|
*var = strv_join(ans, ":");
|
|
if (!*var)
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int verify_socket(Unit *u) {
|
|
int r;
|
|
|
|
assert(u);
|
|
|
|
if (u->type != UNIT_SOCKET)
|
|
return 0;
|
|
|
|
/* Cannot run this without the service being around */
|
|
|
|
/* This makes sure instance is created if necessary. */
|
|
r = socket_instantiate_service(SOCKET(u));
|
|
if (r < 0)
|
|
return log_unit_error_errno(u, r, "Socket cannot be started, failed to create instance: %m");
|
|
|
|
/* This checks both type of sockets */
|
|
if (UNIT_ISSET(SOCKET(u)->service)) {
|
|
Service *service;
|
|
|
|
service = SERVICE(UNIT_DEREF(SOCKET(u)->service));
|
|
log_unit_debug(u, "Using %s", UNIT(service)->id);
|
|
|
|
if (UNIT(service)->load_state != UNIT_LOADED) {
|
|
log_unit_error(u, "Service %s not loaded, %s cannot be started.", UNIT(service)->id, u->id);
|
|
return -ENOENT;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int verify_executable(Unit *u, ExecCommand *exec) {
|
|
if (!exec)
|
|
return 0;
|
|
|
|
if (access(exec->path, X_OK) < 0)
|
|
return log_unit_error_errno(u, errno, "Command %s is not executable: %m", exec->path);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int verify_executables(Unit *u) {
|
|
ExecCommand *exec;
|
|
int r = 0, k;
|
|
unsigned i;
|
|
|
|
assert(u);
|
|
|
|
exec = u->type == UNIT_SOCKET ? SOCKET(u)->control_command :
|
|
u->type == UNIT_MOUNT ? MOUNT(u)->control_command :
|
|
u->type == UNIT_SWAP ? SWAP(u)->control_command : NULL;
|
|
k = verify_executable(u, exec);
|
|
if (k < 0 && r == 0)
|
|
r = k;
|
|
|
|
if (u->type == UNIT_SERVICE)
|
|
for (i = 0; i < ELEMENTSOF(SERVICE(u)->exec_command); i++) {
|
|
k = verify_executable(u, SERVICE(u)->exec_command[i]);
|
|
if (k < 0 && r == 0)
|
|
r = k;
|
|
}
|
|
|
|
if (u->type == UNIT_SOCKET)
|
|
for (i = 0; i < ELEMENTSOF(SOCKET(u)->exec_command); i++) {
|
|
k = verify_executable(u, SOCKET(u)->exec_command[i]);
|
|
if (k < 0 && r == 0)
|
|
r = k;
|
|
}
|
|
|
|
return r;
|
|
}
|
|
|
|
static int verify_documentation(Unit *u, bool check_man) {
|
|
char **p;
|
|
int r = 0, k;
|
|
|
|
STRV_FOREACH(p, u->documentation) {
|
|
log_unit_debug(u, "Found documentation item: %s", *p);
|
|
|
|
if (check_man && startswith(*p, "man:")) {
|
|
k = show_man_page(*p + 4, true);
|
|
if (k != 0) {
|
|
if (k < 0)
|
|
log_unit_error_errno(u, k, "Can't show %s: %m", *p + 4);
|
|
else {
|
|
log_unit_error(u, "Command 'man %s' failed with code %d", *p + 4, k);
|
|
k = -ENOEXEC;
|
|
}
|
|
if (r == 0)
|
|
r = k;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Check remote URLs? */
|
|
|
|
return r;
|
|
}
|
|
|
|
static int verify_unit(Unit *u, bool check_man) {
|
|
_cleanup_(sd_bus_error_free) sd_bus_error err = SD_BUS_ERROR_NULL;
|
|
int r, k;
|
|
|
|
assert(u);
|
|
|
|
if (DEBUG_LOGGING)
|
|
unit_dump(u, stdout, "\t");
|
|
|
|
log_unit_debug(u, "Creating %s/start job", u->id);
|
|
r = manager_add_job(u->manager, JOB_START, u, JOB_REPLACE, NULL, &err, NULL);
|
|
if (r < 0)
|
|
log_unit_error_errno(u, r, "Failed to create %s/start: %s", u->id, bus_error_message(&err, r));
|
|
|
|
k = verify_socket(u);
|
|
if (k < 0 && r == 0)
|
|
r = k;
|
|
|
|
k = verify_executables(u);
|
|
if (k < 0 && r == 0)
|
|
r = k;
|
|
|
|
k = verify_documentation(u, check_man);
|
|
if (k < 0 && r == 0)
|
|
r = k;
|
|
|
|
return r;
|
|
}
|
|
|
|
int verify_units(char **filenames, UnitFileScope scope, bool check_man, bool run_generators) {
|
|
const ManagerTestRunFlags flags =
|
|
MANAGER_TEST_RUN_BASIC |
|
|
MANAGER_TEST_RUN_ENV_GENERATORS |
|
|
run_generators * MANAGER_TEST_RUN_GENERATORS;
|
|
|
|
_cleanup_(manager_freep) Manager *m = NULL;
|
|
Unit *units[strv_length(filenames)];
|
|
_cleanup_free_ char *var = NULL;
|
|
int r = 0, k, i, count = 0;
|
|
char **filename;
|
|
|
|
if (strv_isempty(filenames))
|
|
return 0;
|
|
|
|
/* set the path */
|
|
r = generate_path(&var, filenames);
|
|
if (r < 0)
|
|
return log_error_errno(r, "Failed to generate unit load path: %m");
|
|
|
|
assert_se(set_unit_path(var) >= 0);
|
|
|
|
r = manager_new(scope, flags, &m);
|
|
if (r < 0)
|
|
return log_error_errno(r, "Failed to initialize manager: %m");
|
|
|
|
log_debug("Starting manager...");
|
|
|
|
r = manager_startup(m, NULL, NULL);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
manager_clear_jobs(m);
|
|
|
|
log_debug("Loading remaining units from the command line...");
|
|
|
|
STRV_FOREACH(filename, filenames) {
|
|
_cleanup_free_ char *prepared = NULL;
|
|
|
|
log_debug("Handling %s...", *filename);
|
|
|
|
k = prepare_filename(*filename, &prepared);
|
|
if (k < 0) {
|
|
log_error_errno(k, "Failed to prepare filename %s: %m", *filename);
|
|
if (r == 0)
|
|
r = k;
|
|
continue;
|
|
}
|
|
|
|
k = manager_load_startable_unit_or_warn(m, NULL, prepared, &units[count]);
|
|
if (k < 0) {
|
|
if (r == 0)
|
|
r = k;
|
|
continue;
|
|
}
|
|
|
|
count++;
|
|
}
|
|
|
|
for (i = 0; i < count; i++) {
|
|
k = verify_unit(units[i], check_man);
|
|
if (k < 0 && r == 0)
|
|
r = k;
|
|
}
|
|
|
|
return r;
|
|
}
|