![Lennart Poettering](/assets/img/avatar_default.png)
This is just some refactoring: shifting around of code, not change in codeflow. This splits up the way too huge systemctl.c in multiple more easily digestable files. It roughly follows the rule that each family of verbs gets its own .c/.h file pair, and so do all the compat executable names we support. Plus three extra files for sysv compat (which existed before already, but I renamed slightly, to get the systemctl- prefix lik everything else), a -util file with generic stuff everything uses, and a -logind file with everything that talks directly to logind instead of PID1. systemctl is still a bit too complex for my taste, but I think this way itc omes in a more digestable bits at least. No change of behaviour, just reshuffling of some code.
45 lines
1.6 KiB
C
45 lines
1.6 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
|
|
#include "bus-error.h"
|
|
#include "bus-locator.h"
|
|
#include "systemctl-trivial-method.h"
|
|
#include "systemctl-util.h"
|
|
#include "systemctl.h"
|
|
|
|
/* A generic implementation for cases we just need to invoke a simple method call on the Manager object. */
|
|
|
|
int trivial_method(int argc, char *argv[], void *userdata) {
|
|
_cleanup_(sd_bus_error_free) sd_bus_error error = SD_BUS_ERROR_NULL;
|
|
const char *method;
|
|
sd_bus *bus;
|
|
int r;
|
|
|
|
if (arg_dry_run)
|
|
return 0;
|
|
|
|
r = acquire_bus(BUS_MANAGER, &bus);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
polkit_agent_open_maybe();
|
|
|
|
method =
|
|
streq(argv[0], "clear-jobs") ||
|
|
streq(argv[0], "cancel") ? "ClearJobs" :
|
|
streq(argv[0], "reset-failed") ? "ResetFailed" :
|
|
streq(argv[0], "halt") ? "Halt" :
|
|
streq(argv[0], "reboot") ? "Reboot" :
|
|
streq(argv[0], "kexec") ? "KExec" :
|
|
streq(argv[0], "exit") ? "Exit" :
|
|
/* poweroff */ "PowerOff";
|
|
|
|
r = bus_call_method(bus, bus_systemd_mgr, method, &error, NULL, NULL);
|
|
if (r < 0 && arg_action == ACTION_SYSTEMCTL)
|
|
return log_error_errno(r, "Failed to execute operation: %s", bus_error_message(&error, r));
|
|
|
|
/* Note that for the legacy commands (i.e. those with action != ACTION_SYSTEMCTL) we support
|
|
* fallbacks to the old ways of doing things, hence don't log any error in that case here. */
|
|
|
|
return r < 0 ? r : 0;
|
|
}
|