da6053d0a7
Previously we were a bit sloppy with the index and size types of arrays, we'd regularly use unsigned. While I don't think this ever resulted in real issues I think we should be more careful there and follow a stricter regime: unless there's a strong reason not to use size_t for array sizes and indexes, size_t it should be. Any allocations we do ultimately will use size_t anyway, and converting forth and back between unsigned and size_t will always be a source of problems. Note that on 32bit machines "unsigned" and "size_t" are equivalent, and on 64bit machines our arrays shouldn't grow that large anyway, and if they do we have a problem, however that kind of overly large allocation we have protections for usually, but for overflows we do not have that so much, hence let's add it. So yeah, it's a story of the current code being already "good enough", but I think some extra type hygiene is better. This patch tries to be comprehensive, but it probably isn't and I missed a few cases. But I guess we can cover that later as we notice it. Among smaller fixes, this changes: 1. strv_length()' return type becomes size_t 2. the unit file changes array size becomes size_t 3. DNS answer and query array sizes become size_t Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=76745
47 lines
1 KiB
C
47 lines
1 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
#pragma once
|
|
|
|
/***
|
|
This file is part of systemd.
|
|
|
|
Copyright 2010 Lennart Poettering
|
|
***/
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include "hashmap.h"
|
|
#include "macro.h"
|
|
#include "set.h"
|
|
|
|
typedef struct FDSet FDSet;
|
|
|
|
FDSet* fdset_new(void);
|
|
FDSet* fdset_free(FDSet *s);
|
|
|
|
int fdset_put(FDSet *s, int fd);
|
|
int fdset_put_dup(FDSet *s, int fd);
|
|
|
|
bool fdset_contains(FDSet *s, int fd);
|
|
int fdset_remove(FDSet *s, int fd);
|
|
|
|
int fdset_new_array(FDSet **ret, const int *fds, size_t n_fds);
|
|
int fdset_new_fill(FDSet **ret);
|
|
int fdset_new_listen_fds(FDSet **ret, bool unset);
|
|
|
|
int fdset_cloexec(FDSet *fds, bool b);
|
|
|
|
int fdset_close_others(FDSet *fds);
|
|
|
|
unsigned fdset_size(FDSet *fds);
|
|
bool fdset_isempty(FDSet *fds);
|
|
|
|
int fdset_iterate(FDSet *s, Iterator *i);
|
|
|
|
int fdset_steal_first(FDSet *fds);
|
|
|
|
#define FDSET_FOREACH(fd, fds, i) \
|
|
for ((i) = ITERATOR_FIRST, (fd) = fdset_iterate((fds), &(i)); (fd) >= 0; (fd) = fdset_iterate((fds), &(i)))
|
|
|
|
DEFINE_TRIVIAL_CLEANUP_FUNC(FDSet*, fdset_free);
|
|
#define _cleanup_fdset_free_ _cleanup_(fdset_freep)
|