91b6833686
Today, with the tests inside a `tests` intermingled with the
corresponding library's source code, we have a few problems:
- We have to be careful that wildcards don't end up with tests being
built as part of Nix proper, or test headers being installed as part
of Nix proper.
- Tests in libraries but not executables is not right:
- It means each executable runs the previous unit tests again, because
it needs the libraries.
- It doesn't work right on Windows, which doesn't want you to load a
DLL just for the side global variable . It could be made to work
with the dlopen equivalent, but that's gross!
This reorg solves these problems.
There is a remaining problem which is that sibbling headers (like
`hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end
up shadowing each other. This PR doesn't solve that. That is left as
future work for a future PR.
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
76 lines
2 KiB
C++
76 lines
2 KiB
C++
#pragma once
|
|
///@file
|
|
|
|
#include <nlohmann/json.hpp>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "tests/libstore.hh"
|
|
#include "tests/characterization.hh"
|
|
|
|
namespace nix {
|
|
|
|
template<class Proto, const char * protocolDir>
|
|
class ProtoTest : public CharacterizationTest, public LibStoreTest
|
|
{
|
|
Path unitTestData = getUnitTestData() + "/" + protocolDir;
|
|
|
|
Path goldenMaster(std::string_view testStem) const override {
|
|
return unitTestData + "/" + testStem + ".bin";
|
|
}
|
|
};
|
|
|
|
template<class Proto, const char * protocolDir>
|
|
class VersionedProtoTest : public ProtoTest<Proto, protocolDir>
|
|
{
|
|
public:
|
|
/**
|
|
* Golden test for `T` reading
|
|
*/
|
|
template<typename T>
|
|
void readProtoTest(PathView testStem, typename Proto::Version version, T expected)
|
|
{
|
|
CharacterizationTest::readTest(testStem, [&](const auto & encoded) {
|
|
T got = ({
|
|
StringSource from { encoded };
|
|
Proto::template Serialise<T>::read(
|
|
*LibStoreTest::store,
|
|
typename Proto::ReadConn {
|
|
.from = from,
|
|
.version = version,
|
|
});
|
|
});
|
|
|
|
ASSERT_EQ(got, expected);
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Golden test for `T` write
|
|
*/
|
|
template<typename T>
|
|
void writeProtoTest(PathView testStem, typename Proto::Version version, const T & decoded)
|
|
{
|
|
CharacterizationTest::writeTest(testStem, [&]() {
|
|
StringSink to;
|
|
Proto::template Serialise<T>::write(
|
|
*LibStoreTest::store,
|
|
typename Proto::WriteConn {
|
|
.to = to,
|
|
.version = version,
|
|
},
|
|
decoded);
|
|
return std::move(to.s);
|
|
});
|
|
}
|
|
};
|
|
|
|
#define VERSIONED_CHARACTERIZATION_TEST(FIXTURE, NAME, STEM, VERSION, VALUE) \
|
|
TEST_F(FIXTURE, NAME ## _read) { \
|
|
readProtoTest(STEM, VERSION, VALUE); \
|
|
} \
|
|
TEST_F(FIXTURE, NAME ## _write) { \
|
|
writeProtoTest(STEM, VERSION, VALUE); \
|
|
}
|
|
|
|
}
|