2017-11-18 17:09:20 +01:00
|
|
|
/* SPDX-License-Identifier: LGPL-2.1+ */
|
2016-04-20 15:28:28 +02:00
|
|
|
#pragma once
|
|
|
|
|
2017-12-23 08:59:56 +01:00
|
|
|
#include "sd-bus.h"
|
2019-03-06 19:47:06 +01:00
|
|
|
|
|
|
|
#include "install.h"
|
2017-12-23 08:59:56 +01:00
|
|
|
#include "unit-def.h"
|
2016-04-20 15:28:28 +02:00
|
|
|
|
2016-04-20 17:43:13 +02:00
|
|
|
typedef struct UnitInfo {
|
|
|
|
const char *machine;
|
|
|
|
const char *id;
|
|
|
|
const char *description;
|
|
|
|
const char *load_state;
|
|
|
|
const char *active_state;
|
|
|
|
const char *sub_state;
|
|
|
|
const char *following;
|
|
|
|
const char *unit_path;
|
|
|
|
uint32_t job_id;
|
|
|
|
const char *job_type;
|
|
|
|
const char *job_path;
|
|
|
|
} UnitInfo;
|
|
|
|
|
|
|
|
int bus_parse_unit_info(sd_bus_message *message, UnitInfo *u);
|
|
|
|
|
2017-12-23 08:59:56 +01:00
|
|
|
int bus_append_unit_property_assignment(sd_bus_message *m, UnitType t, const char *assignment);
|
|
|
|
int bus_append_unit_property_assignment_many(sd_bus_message *m, UnitType t, char **l);
|
2016-04-20 17:43:13 +02:00
|
|
|
|
tree-wide: be more careful with the type of array sizes
Previously we were a bit sloppy with the index and size types of arrays,
we'd regularly use unsigned. While I don't think this ever resulted in
real issues I think we should be more careful there and follow a
stricter regime: unless there's a strong reason not to use size_t for
array sizes and indexes, size_t it should be. Any allocations we do
ultimately will use size_t anyway, and converting forth and back between
unsigned and size_t will always be a source of problems.
Note that on 32bit machines "unsigned" and "size_t" are equivalent, and
on 64bit machines our arrays shouldn't grow that large anyway, and if
they do we have a problem, however that kind of overly large allocation
we have protections for usually, but for overflows we do not have that
so much, hence let's add it.
So yeah, it's a story of the current code being already "good enough",
but I think some extra type hygiene is better.
This patch tries to be comprehensive, but it probably isn't and I missed
a few cases. But I guess we can cover that later as we notice it. Among
smaller fixes, this changes:
1. strv_length()' return type becomes size_t
2. the unit file changes array size becomes size_t
3. DNS answer and query array sizes become size_t
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=76745
2018-04-27 14:09:31 +02:00
|
|
|
int bus_deserialize_and_dump_unit_file_changes(sd_bus_message *m, bool quiet, UnitFileChange **changes, size_t *n_changes);
|
2016-04-20 17:43:13 +02:00
|
|
|
|
2018-04-10 12:35:36 +02:00
|
|
|
int unit_load_state(sd_bus *bus, const char *name, char **load_state);
|