picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

selinux: always use *_raw API from libselinux

Browse source 
When mcstransd* is running non-raw functions will return translated SELinux
context. Problem is that libselinux will cache this information and in the
future it will return same context even though mcstransd maybe not running at
that time. If you then check with such context against SELinux policy then
selinux_check_access may fail depending on whether mcstransd is running or not.

To workaround this problem/bug in libselinux, we should always get raw context
instead. Most users will not notice because result of access check is logged
only in debug mode.

* SELinux context translation service, which will translates labels to human
  readable form
This commit is contained in:
Michal Sekletar 2015-09-01 16:02:58 +02:00
parent 3f010fe095
commit 2415487984
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/basic/selinux-util.c
View file

@ -199,11 +199,11 @@ int mac_selinux_get_create_label_from_exe(const char *exe, char **label) {
if (!mac_selinux_use())
return -EOPNOTSUPP;
r = getcon(&mycon);
r = getcon_raw(&mycon);
if (r < 0)
return -errno;
r = getfilecon(exe, &fcon);
r = getfilecon_raw(exe, &fcon);
if (r < 0)
return -errno;
@ -225,7 +225,7 @@ int mac_selinux_get_our_label(char **label) {
if (!mac_selinux_use())
return -EOPNOTSUPP;
r = getcon(label);
r = getcon_raw(label);
if (r < 0)
return -errno;
#endif
@ -249,7 +249,7 @@ int mac_selinux_get_child_mls_label(int socket_fd, const char *exe, const char *
if (!mac_selinux_use())
return -EOPNOTSUPP;
r = getcon(&mycon);
r = getcon_raw(&mycon);
if (r < 0)
return -errno;
@ -260,7 +260,7 @@ int mac_selinux_get_child_mls_label(int socket_fd, const char *exe, const char *
if (!exec_label) {
/* If there is no context set for next exec let's use context
of target executable */
r = getfilecon(exe, &fcon);
r = getfilecon_raw(exe, &fcon);
if (r < 0)
return -errno;
}

4
src/core/selinux-access.c
View file

@ -246,7 +246,7 @@ int mac_selinux_generic_access_check(
if (path) {
/* Get the file context of the unit file */
r = getfilecon(path, &fcon);
r = getfilecon_raw(path, &fcon);
if (r < 0) {
r = sd_bus_error_setf(error, SD_BUS_ERROR_ACCESS_DENIED, "Failed to get file context on %s.", path);
goto finish;
@ -254,7 +254,7 @@ int mac_selinux_generic_access_check(
tclass = "service";
} else {
r = getcon(&fcon);
r = getcon_raw(&fcon);
if (r < 0) {
r = sd_bus_error_setf(error, SD_BUS_ERROR_ACCESS_DENIED, "Failed to get current context.");
goto finish;