picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

sysusers: fix memory leak when /etc/passwd contains multiple identical lines

Browse source 
Fixes: #8718
This commit is contained in:
Lennart Poettering 2018-04-18 17:58:53 +02:00
parent 2dc993722b
commit 43e948eea6
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/sysusers/sysusers.c
View file

@ -97,8 +97,8 @@ static int load_user_database(void) {
return r;
while ((r = fgetpwent_sane(f, &pw)) > 0) {
char *n;
int k, q;
char *n;
n = strdup(pw->pw_name);
if (!n)
@ -112,12 +112,12 @@ static int load_user_database(void) {
q = hashmap_put(database_uid, UID_TO_PTR(pw->pw_uid), n);
if (q < 0 && q != -EEXIST) {
if (k < 0)
if (k <= 0)
free(n);
return q;
}
if (q < 0 && k < 0)
if (q <= 0 && k <= 0)
free(n);
}
return r;
@ -159,12 +159,12 @@ static int load_group_database(void) {
q = hashmap_put(database_gid, GID_TO_PTR(gr->gr_gid), n);
if (q < 0 && q != -EEXIST) {
if (k < 0)
if (k <= 0)
free(n);
return q;
}
if (q < 0 && k < 0)
if (q <= 0 && k <= 0)
free(n);
errno = 0;