picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

hashmap: optimize set_put_strdup() a bit

Browse source 
Hashing should be quicker than allocating, hence let's first check if the
string already exists and only then allocate a new copy for it.
This commit is contained in:
Lennart Poettering 2016-04-29 17:33:29 +02:00
parent 934e749e18
commit 454f0f8680
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/basic/hashmap.c
View file

@ -1773,20 +1773,18 @@ int set_consume(Set *s, void *value) {
int set_put_strdup(Set *s, const char *p) {
char *c;
int r;
assert(s);
assert(p);
if (set_contains(s, (char*) p))
return 0;
c = strdup(p);
if (!c)
return -ENOMEM;
r = set_consume(s, c);
if (r == -EEXIST)
return 0;
return r;
return set_consume(s, c);
}
int set_put_strdupv(Set *s, char **l) {