meson: stop setting -fPIE globally

Setting -fPIE globally can lead to miscompilations on certain
architectures.
This is caused by both -fPIE and -fPIC options being added to various
compilation commands. Only -fPIC is being recorded in the LTO options
section of the object. The gcc-8 LTO plugin merges -fPIC + -fPIE to
nothing. So, the compilations done by the plugin are not
position-independent and fail to link with -pie.

The simplest solution is to stop setting -fPIE globally and instead
using meson's b_pie=true option. This requires meson 0.49 or later.

Since we don't set this option in meson.build but leave it up to the
distro maintainer to set this option, do not bump the meson version
requirement.

Fixes: #10548
This commit is contained in:
Michael Biebl 2019-01-10 12:58:27 +01:00 committed by Zbigniew Jędrzejewski-Szmek
parent c0f34168d4
commit 4e4bbc439e
1 changed files with 0 additions and 7 deletions

View File

@ -359,13 +359,6 @@ possible_link_flags = [
'-Wl,-z,now',
]
# the oss-fuzz fuzzers are not built with -fPIE, so don't
# enable it when we are linking against them
if not fuzzer_build
possible_cc_flags += '-fPIE'
possible_link_flags += '-pie'
endif
if cc.get_id() == 'clang'
possible_cc_flags += [
'-Wno-typedef-redefinition',