diff --git a/coccinelle/errno.cocci b/coccinelle/errno.cocci index ed74c0a98a..c928266481 100644 --- a/coccinelle/errno.cocci +++ b/coccinelle/errno.cocci @@ -30,3 +30,12 @@ expression e; + return log_LEVEL_errno(e, ...); - return -e; +@@ +identifier log_LEVEL_errno =~ "^log_(debug|info|notice|warning|error|emergency)_errno$"; +expression list args; +expression e; +local idexpression r; +@@ +- log_LEVEL_errno(e, args); +- r = e; ++ r = log_LEVEL_errno(e, args); diff --git a/coccinelle/synthetic-errno.cocci b/coccinelle/synthetic-errno.cocci index 3ddb69cb4c..650c37e08b 100644 --- a/coccinelle/synthetic-errno.cocci +++ b/coccinelle/synthetic-errno.cocci @@ -44,5 +44,5 @@ identifier log_LEVEL_errno =~ "^log_(debug|info|notice|warning|error|emergency)_ identifier ERRNO =~ "^E[A-Z]+$"; expression list args; @@ -- return log_LEVEL_errno(ERRNO, args); -+ return log_LEVEL_errno(SYNTHETIC_ERRNO(ERRNO), args); +- log_LEVEL_errno(ERRNO, args); ++ log_LEVEL_errno(SYNTHETIC_ERRNO(ERRNO), args); diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index 74412ef17a..bcf2e01d5c 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -2019,13 +2019,12 @@ static int verify(sd_journal *j) { #endif k = journal_file_verify(f, arg_verify_key, &first, &validated, &last, true); - if (k == -EINVAL) { + if (k == -EINVAL) /* If the key was invalid give up right-away. */ return k; - } else if (k < 0) { - log_warning_errno(k, "FAIL: %s (%m)", f->path); - r = k; - } else { + else if (k < 0) + r = log_warning_errno(k, "FAIL: %s (%m)", f->path); + else { char a[FORMAT_TIMESTAMP_MAX], b[FORMAT_TIMESTAMP_MAX], c[FORMAT_TIMESPAN_MAX]; log_info("PASS: %s", f->path); @@ -2374,10 +2373,8 @@ int main(int argc, char *argv[]) { int q; q = journal_directory_vacuum(d->path, arg_vacuum_size, arg_vacuum_n_files, arg_vacuum_time, NULL, !arg_quiet); - if (q < 0) { - log_error_errno(q, "Failed to vacuum %s: %m", d->path); - r = q; - } + if (q < 0) + r = log_error_errno(q, "Failed to vacuum %s: %m", d->path); } goto finish; diff --git a/src/libsystemd/sd-device/device-enumerator.c b/src/libsystemd/sd-device/device-enumerator.c index b9d4db323a..6888b58b67 100644 --- a/src/libsystemd/sd-device/device-enumerator.c +++ b/src/libsystemd/sd-device/device-enumerator.c @@ -743,16 +743,12 @@ static int enumerator_scan_devices_all(sd_device_enumerator *enumerator) { int k; k = enumerator_scan_dir(enumerator, "bus", "devices", NULL); - if (k < 0) { - log_debug_errno(k, "sd-device-enumerator: Failed to scan /sys/bus: %m"); - r = k; - } + if (k < 0) + r = log_debug_errno(k, "sd-device-enumerator: Failed to scan /sys/bus: %m"); k = enumerator_scan_dir(enumerator, "class", NULL, NULL); - if (k < 0) { - log_debug_errno(k, "sd-device-enumerator: Failed to scan /sys/class: %m"); - r = k; - } + if (k < 0) + r = log_debug_errno(k, "sd-device-enumerator: Failed to scan /sys/class: %m"); } return r; @@ -870,10 +866,8 @@ int device_enumerator_scan_subsystems(sd_device_enumerator *enumerator) { /* modules */ if (match_subsystem(enumerator, "module")) { k = enumerator_scan_dir_and_add_devices(enumerator, "module", NULL, NULL); - if (k < 0) { - log_debug_errno(k, "sd-device-enumerator: Failed to scan modules: %m"); - r = k; - } + if (k < 0) + r = log_debug_errno(k, "sd-device-enumerator: Failed to scan modules: %m"); } if (access("/sys/subsystem", F_OK) >= 0) @@ -884,19 +878,15 @@ int device_enumerator_scan_subsystems(sd_device_enumerator *enumerator) { /* subsystems (only buses support coldplug) */ if (match_subsystem(enumerator, "subsystem")) { k = enumerator_scan_dir_and_add_devices(enumerator, subsysdir, NULL, NULL); - if (k < 0) { - log_debug_errno(k, "sd-device-enumerator: Failed to scan subsystems: %m"); - r = k; - } + if (k < 0) + r = log_debug_errno(k, "sd-device-enumerator: Failed to scan subsystems: %m"); } /* subsystem drivers */ if (match_subsystem(enumerator, "drivers")) { k = enumerator_scan_dir(enumerator, subsysdir, "drivers", "drivers"); - if (k < 0) { - log_debug_errno(k, "sd-device-enumerator: Failed to scan drivers: %m"); - r = k; - } + if (k < 0) + r = log_debug_errno(k, "sd-device-enumerator: Failed to scan drivers: %m"); } typesafe_qsort(enumerator->devices, enumerator->n_devices, device_compare); diff --git a/src/pstore/pstore.c b/src/pstore/pstore.c index 05046b57ea..db8a71fbab 100644 --- a/src/pstore/pstore.c +++ b/src/pstore/pstore.c @@ -304,7 +304,7 @@ static void process_dmesg_files(PStoreList *list) { * output either. */ size_t needed = strlen(pe->dirent.d_name) + strlen(":\n") + pe->content_size + 1; if (!GREEDY_REALLOC(dmesg, dmesg_allocated, dmesg_size + needed)) { - log_warning_errno(ENOMEM, "Failed to write dmesg file: %m"); + log_oom(); dmesg_bad = true; continue; } diff --git a/src/resolve/resolved-dns-query.c b/src/resolve/resolved-dns-query.c index f4bca54e19..c4d620ac8b 100644 --- a/src/resolve/resolved-dns-query.c +++ b/src/resolve/resolved-dns-query.c @@ -282,8 +282,7 @@ void dns_query_candidate_notify(DnsQueryCandidate *c) { return; fail: - log_warning_errno(r, "Failed to follow search domains: %m"); - c->error_code = r; + c->error_code = log_warning_errno(r, "Failed to follow search domains: %m"); dns_query_ready(c->query); } diff --git a/src/update-utmp/update-utmp.c b/src/update-utmp/update-utmp.c index 0546486f73..59c49f2a80 100644 --- a/src/update-utmp/update-utmp.c +++ b/src/update-utmp/update-utmp.c @@ -133,10 +133,8 @@ static int on_reboot(Context *c) { t = get_startup_time(c); q = utmp_put_reboot(t); - if (q < 0) { - log_error_errno(q, "Failed to write utmp record: %m"); - r = q; - } + if (q < 0) + r = log_error_errno(q, "Failed to write utmp record: %m"); return r; } @@ -157,10 +155,8 @@ static int on_shutdown(Context *c) { #endif q = utmp_put_shutdown(); - if (q < 0) { - log_error_errno(q, "Failed to write utmp record: %m"); - r = q; - } + if (q < 0) + r = log_error_errno(q, "Failed to write utmp record: %m"); return r; }