picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

unit: don't emit PropertiesChanged signal if adding a dependency to a unit is a no-op

This commit is contained in:
Renaud Métrich 2020-10-02 17:30:35 +02:00 committed by Lennart Poettering
parent b8aaceb9b5
commit 5177cb0a9a
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/core/unit.c
View File

@ -3020,6 +3020,9 @@ int unit_add_dependency(
};
Unit *original_u = u, *original_other = other;
int r;
/* Helper to know whether sending a notification is necessary or not:
* if the dependency is already there, no need to notify! */
bool noop = true;
assert(u);
assert(d >= 0 && d < _UNIT_DEPENDENCY_MAX);
@ -3057,24 +3060,33 @@ int unit_add_dependency(
r = unit_add_dependency_hashmap(u->dependencies + d, other, mask, 0);
if (r < 0)
return r;
else if (r > 0)
noop = false;
if (inverse_table[d] != _UNIT_DEPENDENCY_INVALID && inverse_table[d] != d) {
r = unit_add_dependency_hashmap(other->dependencies + inverse_table[d], u, 0, mask);
if (r < 0)
return r;
else if (r > 0)
noop = false;
}
if (add_reference) {
r = unit_add_dependency_hashmap(u->dependencies + UNIT_REFERENCES, other, mask, 0);
if (r < 0)
return r;
else if (r > 0)
noop = false;
r = unit_add_dependency_hashmap(other->dependencies + UNIT_REFERENCED_BY, u, 0, mask);
if (r < 0)
return r;
else if (r > 0)
noop = false;
}
unit_add_to_dbus_queue(u);
if (!noop)
unit_add_to_dbus_queue(u);
return 0;
}