picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

network: change log level when sd_rtnl_message_get_family() returns invalid family (#6923)

Browse source 
From bce67bbee3, systemd-networkd always shows
```
rtnl: received address with invalid family type 32, ignoring.
```
during boot-up. In the code, there are log_warning() and log_debug() for the
same situation, and the log_debug() is never called. So, let's lower the
log level and remove never called function.
This commit is contained in:
Yu Watanabe 2017-09-28 00:55:13 +09:00 committed by Lennart Poettering
parent 2e4025c0f9
commit 615ded6233
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/network/networkd-manager.c
View file

@ -757,8 +757,11 @@ int manager_rtnl_process_rule(sd_netlink *rtnl, sd_netlink_message *message, voi
}
r = sd_rtnl_message_get_family(message, &family);
if (r < 0 || !IN_SET(family, AF_INET, AF_INET6)) {
log_warning_errno(r, "rtnl: received address with invalid family type %u, ignoring.", type);
if (r < 0) {
log_warning_errno(r, "rtnl: could not get rule family: %m");
return 0;
} else if (!IN_SET(family, AF_INET, AF_INET6)) {
log_debug("rtnl: received address with invalid family %u, ignoring.", family);
return 0;
}
@ -798,7 +801,7 @@ int manager_rtnl_process_rule(sd_netlink *rtnl, sd_netlink_message *message, voi
break;
default:
log_debug("rtnl: ignoring unsupported rule family: %d", family);
assert_not_reached("Received unsupported rule family");
}
if (from_prefixlen == 0 && to_prefixlen == 0)