picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

xdg-autostart: Ignore all files with GNOME autostart phase

Browse source 
If an autostart file for GNOME has a phase specified, then this implies
it is a session service that needs to be started at a specific time.

We have no way of handling the ordering, and while it does make sense
to explicitly hide these services with X-systemd-skip, there is no point
in even trying to handle them.
This commit is contained in:
Benjamin Berg 2020-06-23 10:44:50 +02:00
parent 566cb7e23b
commit 9d9a9500cd
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/xdg-autostart-generator/xdg-autostart-service.c
View file

@ -527,8 +527,9 @@ int xdg_autostart_service_generate_unit(
return 0;
}
if (streq_ptr(service->gnome_autostart_phase, "EarlyInitialization")) {
log_info("Not generating service for XDG autostart %s, EarlyInitialization needs to be handled separately.",
if (service->gnome_autostart_phase) {
/* There is no explicit value for the "Application" phase. */
log_info("Not generating service for XDG autostart %s, startup phases are not supported.",
service->name);
return 0;
}
@ -563,10 +564,7 @@ int xdg_autostart_service_generate_unit(
fprintf(f, "Description=%s\n", t);
}
/* Only start after the session is ready.
* XXX: GNOME has an autostart order which we may want to support.
* It is not clear how this can be implemented reliably, which
* is why it is skipped for now. */
/* Only start after the session is ready. */
fprintf(f,
"After=graphical-session.target\n");