picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

network: fix signed/unsigned confusion

Browse source 
sd_dhcp_lease_get_servers() returns int, which would never be negative when
cast to size_t, so we condition check was wrong.

CID#1425417.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2020-05-21 07:40:31 +02:00
parent a60416f319
commit a27060759b
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/network/networkd-dhcp-server.c
View file

@ -160,12 +160,12 @@ static int link_push_uplink_to_dhcp_server(
if (lease_condition && link->dhcp_lease) {
const struct in_addr *da;
size_t n = sd_dhcp_lease_get_servers(link->dhcp_lease, what, &da);
int n = sd_dhcp_lease_get_servers(link->dhcp_lease, what, &da);
if (n > 0) {
if (!GREEDY_REALLOC(addresses, n_allocated, n_addresses + n))
return log_oom();
for (unsigned i = 0; i < n; i++)
for (int i = 0; i < n; i++)
if (in4_addr_is_non_local(&da[i]))
addresses[n_addresses++] = da[i];
}