From b81b9d406de7cf5d6ec603d9769817402867aa7b Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Thu, 4 Oct 2018 16:22:11 +0900 Subject: [PATCH] test: fix memleak in test-fs-util Fixes #10267 and CID#1395997. --- src/test/test-fs-util.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test/test-fs-util.c b/src/test/test-fs-util.c index a687fd7fa8..d5f652c938 100644 --- a/src/test/test-fs-util.c +++ b/src/test/test-fs-util.c @@ -702,17 +702,17 @@ static void test_rename_noreplace(void) { } STRV_FOREACH(b, (char**) table) { - y = strjoin(z, *b); - assert_se(y); + _cleanup_free_ char *w = NULL; - if (access(y, F_OK) < 0) { + w = strjoin(w, *b); + assert_se(w); + + if (access(w, F_OK) < 0) { assert_se(errno == ENOENT); continue; } - assert_se(rename_noreplace(AT_FDCWD, x, AT_FDCWD, y) == -EEXIST); - - y = mfree(y); + assert_se(rename_noreplace(AT_FDCWD, w, AT_FDCWD, y) == -EEXIST); } y = strjoin(z, "/somethingelse");