picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

networkd: fix reversed arguments

Browse source 
Found by coverity.

Also drop unused return value while at it.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2017-11-27 12:08:37 +00:00
parent 93f9da6e0a
commit bbd1590085
3 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/network/networkd-manager.c
View file

@ -471,7 +471,7 @@ int manager_rtnl_process_route(sd_netlink *rtnl, sd_netlink_message *message, vo
return 0;
}
route_update(route, &src, src_prefixlen, &gw, &prefsrc, scope, rt_type, protocol);
route_update(route, &src, src_prefixlen, &gw, &prefsrc, scope, protocol, rt_type);
break;

4
src/network/networkd-route.c
View file

@ -368,7 +368,7 @@ int route_add(
return 0;
}
int route_update(Route *route,
void route_update(Route *route,
const union in_addr_union *src,
unsigned char src_prefixlen,
const union in_addr_union *gw,
@ -389,8 +389,6 @@ int route_update(Route *route,
route->scope = scope;
route->protocol = protocol;
route->type = type;
return 0;
}
int route_remove(Route *route, Link *link,

2
src/network/networkd-route.h
View file

@ -64,7 +64,7 @@ int route_remove(Route *route, Link *link, sd_netlink_message_handler_t callback
int route_get(Link *link, int family, const union in_addr_union *dst, unsigned char dst_prefixlen, unsigned char tos, uint32_t priority, uint32_t table, Route **ret);
int route_add(Link *link, int family, const union in_addr_union *dst, unsigned char dst_prefixlen, unsigned char tos, uint32_t priority, uint32_t table, Route **ret);
int route_add_foreign(Link *link, int family, const union in_addr_union *dst, unsigned char dst_prefixlen, unsigned char tos, uint32_t priority, uint32_t table, Route **ret);
int route_update(Route *route, const union in_addr_union *src, unsigned char src_prefixlen, const union in_addr_union *gw, const union in_addr_union *prefsrc, unsigned char scope, unsigned char protocol, unsigned char type);
void route_update(Route *route, const union in_addr_union *src, unsigned char src_prefixlen, const union in_addr_union *gw, const union in_addr_union *prefsrc, unsigned char scope, unsigned char protocol, unsigned char type);
int route_expire_handler(sd_event_source *s, uint64_t usec, void *userdata);