picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

main: interpret all argv[] arguments unconditionally when run in a container

This commit is contained in:
Lennart Poettering 2011-03-16 03:35:59 +01:00
parent a2c422cbbe
commit d821e6d69a
1 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/main.c
View File

@ -828,30 +828,28 @@ static int parse_argv(int argc, char *argv[]) {
break;
}
if (optind < argc) {
if (getpid() != 1) {
/* Hmm, when we aren't run as init system
* let's complain about excess arguments */
if (optind < argc && getpid() != 1) {
/* Hmm, when we aren't run as init system
* let's complain about excess arguments */
log_error("Excess arguments.");
return -EINVAL;
log_error("Excess arguments.");
return -EINVAL;
}
} else if (detect_container(NULL) > 0) {
char **a;
if (detect_container(NULL) > 0) {
char **a;
/* All /proc/cmdline arguments the kernel
* didn't understand it passed to us. We're
* note really interested in that usually
* since /proc/cmdline is more interesting and
* complete. With one exception: if we are run
* in a container /proc/cmdline is not
* relevant for us, hence we rely on argv[]
* instead. */
/* All /proc/cmdline arguments the kernel didn't
* understand it passed to us. We're not really
* interested in that usually since /proc/cmdline is
* more interesting and complete. With one exception:
* if we are run in a container /proc/cmdline is not
* relevant for the container, hence we rely on argv[]
* instead. */
for (a = argv; a < argv + argc; a++)
if ((r = parse_proc_cmdline_word(*a)) < 0)
return r;
}
for (a = argv; a < argv + argc; a++)
if ((r = parse_proc_cmdline_word(*a)) < 0)
return r;
}
return 0;