picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

journalctl: fix memleak

Browse source 
This is harmless, it would only happen if --verify-key is used multiple times.
But let's fix it for correctness.

CID ##1368415.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2017-01-15 11:55:46 -05:00
parent 6fefc0eded
commit e50412ef19
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/journal/journalctl.c
View file

@ -683,11 +683,12 @@ static int parse_argv(int argc, char *argv[]) {
case ARG_VERIFY_KEY:
arg_action = ACTION_VERIFY;
arg_verify_key = strdup(optarg);
if (!arg_verify_key)
return -ENOMEM;
arg_merge = false;
r = free_and_strdup(&arg_verify_key, optarg);
if (r < 0)
return r;
string_erase(optarg);
arg_merge = false;
break;
case ARG_INTERVAL:
@ -888,7 +889,7 @@ static int parse_argv(int argc, char *argv[]) {
* to users, and automatically turn --unit= into --user-unit= if combined with --user. */
r = strv_extend_strv(&arg_user_units, arg_system_units, true);
if (r < 0)
return -ENOMEM;
return r;
arg_system_units = strv_free(arg_system_units);
}