picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Call getgroups() to know size of supplementary groups array to allocate

Browse source 
Resolves RHBZ #1743230 - journalctl dumps core when stack limit is reduced to 256 KB
This commit is contained in:
Renaud Métrich 2019-09-13 11:18:18 +02:00 committed by Zbigniew Jędrzejewski-Szmek
parent 9870c55ef5
commit f5e0b942af
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/basic/user-util.c
View file

@ -410,9 +410,8 @@ char* gid_to_name(gid_t gid) {
}
int in_gid(gid_t gid) {
long ngroups_max;
gid_t *gids;
int r, i;
int ngroups, r, i;
if (getgid() == gid)
return 1;
@ -423,12 +422,15 @@ int in_gid(gid_t gid) {
if (!gid_is_valid(gid))
return -EINVAL;
ngroups_max = sysconf(_SC_NGROUPS_MAX);
assert(ngroups_max > 0);
ngroups = getgroups(0, NULL);
if (ngroups < 0)
return -errno;
if (ngroups == 0)
return 0;
gids = newa(gid_t, ngroups_max);
gids = newa(gid_t, ngroups);
r = getgroups(ngroups_max, gids);
r = getgroups(ngroups, gids);
if (r < 0)
return -errno;